<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172399] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172399">172399</a></dd>
<dt>Author</dt> <dd>timothy@apple.com</dd>
<dt>Date</dt> <dd>2014-08-11 11:43:11 -0700 (Mon, 11 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: DataGrid and its clients are a cluster-cuss of styles
https://bugs.webkit.org/show_bug.cgi?id=135788
Clean up DataGrid and its subclasses and client styles.
Reviewed by Joseph Pecoraro.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/ApplicationCacheFrameContentView.css:
(.content-view.application-cache-frame > .data-grid):
* UserInterface/Views/CookieStorageContentView.css:
(.content-view.cookie-storage > .data-grid):
* UserInterface/Views/DOMStorageContentView.css:
(.content-view.dom-storage > .data-grid):
* UserInterface/Views/DOMTreeDataGrid.css:
(.dom-tree-data-grid .data-grid):
(.dom-tree-data-grid .name-column .icon):
* UserInterface/Views/DOMTreeDataGrid.js:
(WebInspector.DOMTreeDataGrid):
* UserInterface/Views/DataGrid.css:
(.data-grid):
(.data-grid table):
(.data-grid .data-container):
(.data-grid.inline):
(.data-grid th):
(.data-grid :-webkit-any(th, td):not(:last-child)):
(.data-grid th.sortable:active):
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending)):
(.data-grid table.data):
(.data-grid td):
(.data-grid:focus tr.selected td:not(:last-child)):
(body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)):
(.data-grid :-webkit-any(th, td) > div):
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child):
(.data-grid th.sort-ascending > div:first-child::after):
(.data-grid th.sort-descending > div:first-child::after):
(.data-grid td .subtitle):
(.data-grid td .subtitle::before):
(.data-grid:focus tr.selected td .subtitle):
(.data-grid td.error):
(.data-grid tr.selected td.error):
(.data-grid td .icon):
(.data-grid td .go-to-arrow):
(.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow):
* UserInterface/Views/DatabaseContentView.css:
(.storage-view):
* UserInterface/Views/DatabaseTableContentView.css:
(.content-view.database-table > .data-grid):
* UserInterface/Views/DetailsSection.css:
(.details-section > .content .data-grid):
* UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
(.content-view.indexed-database-object-store > .data-grid):
* UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
(WebInspector.LayerTreeDataGridNode.prototype._updateNameCellData):
* UserInterface/Views/LayerTreeSidebarPanel.css:
(.layer-tree.panel .data-grid):
(.layer-tree.panel .name-column .icon):
(.layer-tree.panel tr.reflection .name-column .icon):
(.layer-tree.panel tr.pseudo-element .name-column .icon):
(.layer-tree.panel .name-column .reflection):
(.layer-tree.panel tr.selected .name-column .reflection):
(.layer-tree.panel .bottom-bar):
(body.mac-platform.legacy .layer-tree.panel .bottom-bar):
(.layer-tree.panel .bottom-bar > div):
(body.mac-platform.legacy .layer-tree.panel .bottom-bar > div):
(body.mac-platform.legacy .layer-tree-popover):
* UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel):
(WebInspector.LayerTreeSidebarPanel.prototype._buildLayerInfoSection):
(WebInspector.LayerTreeSidebarPanel.prototype._buildDataGridSection):
(WebInspector.LayerTreeSidebarPanel.prototype._buildBottomBar):
(WebInspector.LayerTreeSidebarPanel.prototype._updateMetrics):
* UserInterface/Views/LegacyJavaScriptProfileView.css:
(.content-view.profile-view > .data-grid):
* UserInterface/Views/LegacyProfileView.css:
* UserInterface/Views/LogContentView.css:
(.console-message .bubble):
* UserInterface/Views/NetworkTimelineView.css:
(.timeline-view.network > .data-grid):
* UserInterface/Views/OverviewTimelineView.css:
(.timeline-view.overview > .timeline-ruler > .header):
(.timeline-view.overview > .data-grid):
* UserInterface/Views/OverviewTimelineView.js:
* UserInterface/Views/ProbeDetailsSidebarPanel.css:
(.details-section.probe-set .options > .probe-add):
(.popover .probe-popover):
* UserInterface/Views/ProbeSetDataGrid.css:
(.details-section.probe-set .data-grid tr.past-value td):
(.details-section.probe-set .data-grid > td.unknown-value):
(.details-section.probe-set .data-grid tr.revealed.highlighted):
(.details-section.probe-set .data-grid tr.separator):
(.details-section.probe-set .data-grid > tr.data-updated):
(.details-section.probe-set .data-grid .selected .section *):
(.details-section.probe-set .data-grid .selected td.unknown-value):
(.details-section.probe-set .data-grid .section):
* UserInterface/Views/QuickConsole.css:
(.quick-console):
* UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline th):
(.data-grid.timeline > .navigation-bar-container > .navigation-bar):
* UserInterface/Views/TimelineRuler.css:
(.timeline-ruler > .header):
(.timeline-ruler > .header > .divider):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs">trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsApplicationCacheFrameContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsCookieStorageContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMStorageContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeDataGridcss">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeDataGridjs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDataGridcss">trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDatabaseContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDatabaseTableContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDetailsSectioncss">trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsIndexedDatabaseObjectStoreContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLayerTreeDataGridNodejs">trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLayerTreeSidebarPanelcss">trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLayerTreeSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLegacyJavaScriptProfileViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/LegacyJavaScriptProfileView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLegacyProfileViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/LegacyProfileView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNetworkTimelineViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsOverviewTimelineViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsOverviewTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsProbeDetailsSidebarPanelcss">trunk/Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsProbeSetDataGridcss">trunk/Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsQuickConsolecss">trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineDataGridcss">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineRulercss">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (172398 => 172399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2014-08-11 18:39:52 UTC (rev 172398)
+++ trunk/Source/WebInspectorUI/ChangeLog        2014-08-11 18:43:11 UTC (rev 172399)
</span><span class="lines">@@ -1,3 +1,110 @@
</span><ins>+2014-08-11 Timothy Hatcher <timothy@apple.com>
+
+ Web Inspector: DataGrid and its clients are a cluster-cuss of styles
+ https://bugs.webkit.org/show_bug.cgi?id=135788
+
+ Clean up DataGrid and its subclasses and client styles.
+
+ Reviewed by Joseph Pecoraro.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Views/ApplicationCacheFrameContentView.css:
+ (.content-view.application-cache-frame > .data-grid):
+ * UserInterface/Views/CookieStorageContentView.css:
+ (.content-view.cookie-storage > .data-grid):
+ * UserInterface/Views/DOMStorageContentView.css:
+ (.content-view.dom-storage > .data-grid):
+ * UserInterface/Views/DOMTreeDataGrid.css:
+ (.dom-tree-data-grid .data-grid):
+ (.dom-tree-data-grid .name-column .icon):
+ * UserInterface/Views/DOMTreeDataGrid.js:
+ (WebInspector.DOMTreeDataGrid):
+ * UserInterface/Views/DataGrid.css:
+ (.data-grid):
+ (.data-grid table):
+ (.data-grid .data-container):
+ (.data-grid.inline):
+ (.data-grid th):
+ (.data-grid :-webkit-any(th, td):not(:last-child)):
+ (.data-grid th.sortable:active):
+ (.data-grid th:-webkit-any(.sort-ascending, .sort-descending)):
+ (.data-grid table.data):
+ (.data-grid td):
+ (.data-grid:focus tr.selected td:not(:last-child)):
+ (body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)):
+ (.data-grid :-webkit-any(th, td) > div):
+ (.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child):
+ (.data-grid th.sort-ascending > div:first-child::after):
+ (.data-grid th.sort-descending > div:first-child::after):
+ (.data-grid td .subtitle):
+ (.data-grid td .subtitle::before):
+ (.data-grid:focus tr.selected td .subtitle):
+ (.data-grid td.error):
+ (.data-grid tr.selected td.error):
+ (.data-grid td .icon):
+ (.data-grid td .go-to-arrow):
+ (.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow):
+ * UserInterface/Views/DatabaseContentView.css:
+ (.storage-view):
+ * UserInterface/Views/DatabaseTableContentView.css:
+ (.content-view.database-table > .data-grid):
+ * UserInterface/Views/DetailsSection.css:
+ (.details-section > .content .data-grid):
+ * UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
+ (.content-view.indexed-database-object-store > .data-grid):
+ * UserInterface/Views/LayerTreeDataGridNode.js:
+ (WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
+ (WebInspector.LayerTreeDataGridNode.prototype._updateNameCellData):
+ * UserInterface/Views/LayerTreeSidebarPanel.css:
+ (.layer-tree.panel .data-grid):
+ (.layer-tree.panel .name-column .icon):
+ (.layer-tree.panel tr.reflection .name-column .icon):
+ (.layer-tree.panel tr.pseudo-element .name-column .icon):
+ (.layer-tree.panel .name-column .reflection):
+ (.layer-tree.panel tr.selected .name-column .reflection):
+ (.layer-tree.panel .bottom-bar):
+ (body.mac-platform.legacy .layer-tree.panel .bottom-bar):
+ (.layer-tree.panel .bottom-bar > div):
+ (body.mac-platform.legacy .layer-tree.panel .bottom-bar > div):
+ (body.mac-platform.legacy .layer-tree-popover):
+ * UserInterface/Views/LayerTreeSidebarPanel.js:
+ (WebInspector.LayerTreeSidebarPanel):
+ (WebInspector.LayerTreeSidebarPanel.prototype._buildLayerInfoSection):
+ (WebInspector.LayerTreeSidebarPanel.prototype._buildDataGridSection):
+ (WebInspector.LayerTreeSidebarPanel.prototype._buildBottomBar):
+ (WebInspector.LayerTreeSidebarPanel.prototype._updateMetrics):
+ * UserInterface/Views/LegacyJavaScriptProfileView.css:
+ (.content-view.profile-view > .data-grid):
+ * UserInterface/Views/LegacyProfileView.css:
+ * UserInterface/Views/LogContentView.css:
+ (.console-message .bubble):
+ * UserInterface/Views/NetworkTimelineView.css:
+ (.timeline-view.network > .data-grid):
+ * UserInterface/Views/OverviewTimelineView.css:
+ (.timeline-view.overview > .timeline-ruler > .header):
+ (.timeline-view.overview > .data-grid):
+ * UserInterface/Views/OverviewTimelineView.js:
+ * UserInterface/Views/ProbeDetailsSidebarPanel.css:
+ (.details-section.probe-set .options > .probe-add):
+ (.popover .probe-popover):
+ * UserInterface/Views/ProbeSetDataGrid.css:
+ (.details-section.probe-set .data-grid tr.past-value td):
+ (.details-section.probe-set .data-grid > td.unknown-value):
+ (.details-section.probe-set .data-grid tr.revealed.highlighted):
+ (.details-section.probe-set .data-grid tr.separator):
+ (.details-section.probe-set .data-grid > tr.data-updated):
+ (.details-section.probe-set .data-grid .selected .section *):
+ (.details-section.probe-set .data-grid .selected td.unknown-value):
+ (.details-section.probe-set .data-grid .section):
+ * UserInterface/Views/QuickConsole.css:
+ (.quick-console):
+ * UserInterface/Views/TimelineDataGrid.css:
+ (.data-grid.timeline th):
+ (.data-grid.timeline > .navigation-bar-container > .navigation-bar):
+ * UserInterface/Views/TimelineRuler.css:
+ (.timeline-ruler > .header):
+ (.timeline-ruler > .header > .divider):
+
</ins><span class="cx"> 2014-08-11 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Adjust build script for Windows production build.
</span></span></pre></div>
<a id="trunkSourceWebInspectorUILocalizationsenlprojlocalizedStringsjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (172398 => 172399)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2014-08-11 18:39:52 UTC (rev 172398)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js        2014-08-11 18:43:11 UTC (rev 172399)
</span><span class="lines">@@ -250,8 +250,8 @@
</span><span class="cx">