<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[172355] trunk/Source</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172355">172355</a></dd>

<dt>Author</dt> <dd>burg@cs.washington.edu</dd>

<dt>Date</dt> <dd>2014-08-08 13:21:59 -0700 (Fri, 08 Aug 2014)</dd>

</dl>

<h3>Log Message</h3>

<pre>Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr

https://bugs.webkit.org/show_bug.cgi?id=135726

Reviewed by Timothy Hatcher.

Source/WebCore:

Add a bridge so that InspectorTest can synchronously log to the console.

* inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::unbufferedLog): Added.

* inspector/InspectorFrontendHost.h:

* inspector/InspectorFrontendHost.idl:

Source/WebInspectorUI:

Added a flag for debugging inspector tests which will synchronously log messages.

This avoids failure modes that prevent logging from being added to the test page.

* UserInterface/Base/Test.js:

(InspectorTest.debugLog):

(InspectorTest.addResult):</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>

<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHostcpp">trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp</a></li>

<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHosth">trunk/Source/WebCore/inspector/InspectorFrontendHost.h</a></li>

<li><a href="#trunkSourceWebCoreinspectorInspectorFrontendHostidl">trunk/Source/WebCore/inspector/InspectorFrontendHost.idl</a></li>

<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>

<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseTestjs">trunk/Source/WebInspectorUI/UserInterface/Base/Test.js</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkSourceWebCoreChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (172354 => 172355)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-08-08 20:09:09 UTC (rev 172354)

+++ trunk/Source/WebCore/ChangeLog        2014-08-08 20:21:59 UTC (rev 172355)

</span><span class="lines">@@ -1,3 +1,17 @@

</span><ins>+2014-08-08  Brian J. Burg  &lt;burg@cs.washington.edu&gt;

+

+        Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr

+        https://bugs.webkit.org/show_bug.cgi?id=135726

+

+        Reviewed by Timothy Hatcher.

+

+        Add a bridge so that InspectorTest can synchronously log to the console.

+

+        * inspector/InspectorFrontendHost.cpp:

+        (WebCore::InspectorFrontendHost::unbufferedLog): Added.

+        * inspector/InspectorFrontendHost.h:

+        * inspector/InspectorFrontendHost.idl:

+

</ins><span class="cx"> 2014-08-08  Roger Fong  &lt;roger_fong@apple.com&gt;

</span><span class="cx"> 

<span class="cx">         Adjustments to CueBox CSS Width calculations.

</span></span></pre></div>

<a id="trunkSourceWebCoreinspectorInspectorFrontendHostcpp"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (172354 => 172355)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp        2014-08-08 20:09:09 UTC (rev 172354)

+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp        2014-08-08 20:21:59 UTC (rev 172355)

</span><span class="lines">@@ -302,6 +302,12 @@

</span><span class="cx">     return m_client &amp;&amp; m_client-&gt;isUnderTest();

</span><span class="cx"> }

</span><span class="cx"> 

</span><ins>+void InspectorFrontendHost::unbufferedLog(const String&amp; message)

+{

+    // This is used only for debugging inspector tests.

+    WTFLogAlways(&quot;InspectorTest: %s&quot;, message.utf8().data());

+}

+

</ins><span class="cx"> void InspectorFrontendHost::beep()

</span><span class="cx"> {

</span><span class="cx">     systemBeep();

</span></span></pre></div>

<a id="trunkSourceWebCoreinspectorInspectorFrontendHosth"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (172354 => 172355)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h        2014-08-08 20:09:09 UTC (rev 172354)

+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h        2014-08-08 20:21:59 UTC (rev 172355)

</span><span class="lines">@@ -84,6 +84,7 @@

</span><span class="cx">     void dispatchEventAsContextMenuEvent(Event*);

</span><span class="cx"> 

</span><span class="cx">     bool isUnderTest();

</span><ins>+    void unbufferedLog(const String&amp; message);

</ins><span class="cx"> 

</span><span class="cx">     void beep();

</span><span class="cx"> 

</span></span></pre></div>

<a id="trunkSourceWebCoreinspectorInspectorFrontendHostidl"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (172354 => 172355)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl        2014-08-08 20:09:09 UTC (rev 172354)

+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl        2014-08-08 20:21:59 UTC (rev 172355)

</span><span class="lines">@@ -64,6 +64,7 @@

</span><span class="cx">     [Custom] void showContextMenu(MouseEvent event, any items);

</span><span class="cx">     void dispatchEventAsContextMenuEvent(Event event);

</span><span class="cx">     void sendMessageToBackend(DOMString message);

</span><ins>+    void unbufferedLog(DOMString message);

</ins><span class="cx"> 

</span><span class="cx">     [Custom] void recordActionTaken(unsigned long actionCode);

</span><span class="cx">     [Custom] void recordPanelShown(unsigned long panelCode);

</span></span></pre></div>

<a id="trunkSourceWebInspectorUIChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (172354 => 172355)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2014-08-08 20:09:09 UTC (rev 172354)

+++ trunk/Source/WebInspectorUI/ChangeLog        2014-08-08 20:21:59 UTC (rev 172355)

</span><span class="lines">@@ -1,3 +1,17 @@

</span><ins>+2014-08-08  Brian J. Burg  &lt;burg@cs.washington.edu&gt;

+

+        Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr

+        https://bugs.webkit.org/show_bug.cgi?id=135726

+

+        Reviewed by Timothy Hatcher.

+

+        Added a flag for debugging inspector tests which will synchronously log messages.

+        This avoids failure modes that prevent logging from being added to the test page.

+

+        * UserInterface/Base/Test.js:

+        (InspectorTest.debugLog):

+        (InspectorTest.addResult):

+

</ins><span class="cx"> 2014-08-08  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         Web Inspector: When Switching Recordings, the UI datagrids do not update to match selection

</span></span></pre></div>

<a id="trunkSourceWebInspectorUIUserInterfaceBaseTestjs"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Test.js (172354 => 172355)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Test.js        2014-08-08 20:09:09 UTC (rev 172354)

+++ trunk/Source/WebInspectorUI/UserInterface/Base/Test.js        2014-08-08 20:21:59 UTC (rev 172355)

</span><span class="lines">@@ -78,6 +78,9 @@

<span class="cx"> // which are provided by `inspector-test.js`.

</span><span class="cx"> InspectorTest = {};

</span><span class="cx"> 

<ins>+// This is useful for debugging Inspector tests by synchronously logging messages.

+InspectorTest.dumpMessagesToConsole = false;

+

</ins><span class="cx"> // This is a workaround for the fact that it would be hard to set up a constructor,

<span class="cx"> // prototype, and prototype chain for the singleton InspectorTest.

</span><span class="cx"> InspectorTest.EventDispatcher = function()

</span><span class="lines">@@ -132,11 +135,17 @@

<span class="cx"> // This function should only be used to debug tests and not to produce normal test output.

</span><span class="cx"> InspectorTest.debugLog = function(message)

</span><span class="cx"> {

</span><ins>+    if (InspectorTest.dumpMessagesToConsole)

+        InspectorFrontendHost.unbufferedLog(&quot;debugLog: &quot; + message);

+

</ins><span class="cx">     this.evaluateInPage(&quot;InspectorTestProxy.debugLog(unescape('&quot; + escape(JSON.stringify(message)) + &quot;'))&quot;);

</span><span class="cx"> }

</span><span class="cx"> 

</span><span class="cx"> InspectorTest.completeTest = function()

</span><span class="cx"> {

</span><ins>+    if (InspectorTest.dumpMessagesToConsole)

+        InspectorFrontendHost.unbufferedLog(&quot;InspectorTest.completeTest()&quot;);

+

</ins><span class="cx">     function signalCompletionToTestPage() {

</span><span class="cx">         InspectorBackend.runAfterPendingDispatches(this.evaluateInPage.bind(this, &quot;InspectorTestProxy.completeTest()&quot;));

</span><span class="cx">     }

</span><span class="lines">@@ -165,6 +174,9 @@

</span><span class="cx"> {

</span><span class="cx">     this._results.push(text);

</span><span class="cx"> 

</span><ins>+    if (InspectorTest.dumpMessagesToConsole)

+        InspectorFrontendHost.unbufferedLog(&quot;addResult: &quot; + text);

+

</ins><span class="cx">     if (!this._testPageIsReloading)

</span><span class="cx">         this.evaluateInPage(&quot;InspectorTestProxy.addResult(unescape('&quot; + escape(text) + &quot;'))&quot;);

</span><span class="cx"> }

</span></span></pre>

</div>

</div>

</body>

</html>