<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[172080] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/172080">172080</a></dd>
<dt>Author</dt> <dd>burg@cs.washington.edu</dd>
<dt>Date</dt> <dd>2014-08-05 14:28:38 -0700 (Tue, 05 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Replay: rename protocol methods for getting replay session/segment data
https://bugs.webkit.org/show_bug.cgi?id=135618
Reviewed by Timothy Hatcher.
Source/WebCore:
* inspector/InspectorReplayAgent.cpp:
(WebCore::InspectorReplayAgent::getSessionData):
(WebCore::InspectorReplayAgent::getSegmentData):
(WebCore::InspectorReplayAgent::getSerializedSession): Deleted.
(WebCore::InspectorReplayAgent::getSerializedSegment): Deleted.
* inspector/InspectorReplayAgent.h:
* inspector/protocol/Replay.json:
Source/WebInspectorUI:
* UserInterface/Controllers/ReplayManager.js:
(WebInspector.ReplayManager.prototype.getSession.get var):
(WebInspector.ReplayManager.prototype.getSegment.get var):
* UserInterface/Models/ReplaySession.js:
(WebInspector.ReplaySession.prototype.segmentsChanged):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorReplayAgentcpp">trunk/Source/WebCore/inspector/InspectorReplayAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorReplayAgenth">trunk/Source/WebCore/inspector/InspectorReplayAgent.h</a></li>
<li><a href="#trunkSourceWebCoreinspectorprotocolReplayjson">trunk/Source/WebCore/inspector/protocol/Replay.json</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersReplayManagerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsReplaySessionjs">trunk/Source/WebInspectorUI/UserInterface/Models/ReplaySession.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (172079 => 172080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-08-05 21:21:31 UTC (rev 172079)
+++ trunk/Source/WebCore/ChangeLog 2014-08-05 21:28:38 UTC (rev 172080)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-08-05 Brian J. Burg <burg@cs.washington.edu>
+
+ Web Replay: rename protocol methods for getting replay session/segment data
+ https://bugs.webkit.org/show_bug.cgi?id=135618
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/InspectorReplayAgent.cpp:
+ (WebCore::InspectorReplayAgent::getSessionData):
+ (WebCore::InspectorReplayAgent::getSegmentData):
+ (WebCore::InspectorReplayAgent::getSerializedSession): Deleted.
+ (WebCore::InspectorReplayAgent::getSerializedSegment): Deleted.
+ * inspector/InspectorReplayAgent.h:
+ * inspector/protocol/Replay.json:
+
</ins><span class="cx"> 2014-08-05 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION: Extremely flashy scrolling while a page is still loading (because of flush throttling)
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorReplayAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorReplayAgent.cpp (172079 => 172080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorReplayAgent.cpp 2014-08-05 21:21:31 UTC (rev 172079)
+++ trunk/Source/WebCore/inspector/InspectorReplayAgent.cpp 2014-08-05 21:28:38 UTC (rev 172080)
</span><span class="lines">@@ -471,7 +471,7 @@
</span><span class="cx"> sessionsList->addItem(pair.key);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorReplayAgent::getSerializedSession(ErrorString* errorString, SessionIdentifier identifier, RefPtr<Inspector::TypeBuilder::Replay::ReplaySession>& serializedObject)
</del><ins>+void InspectorReplayAgent::getSessionData(ErrorString* errorString, SessionIdentifier identifier, RefPtr<Inspector::TypeBuilder::Replay::ReplaySession>& serializedObject)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<ReplaySession> session = findSession(errorString, identifier);
</span><span class="cx"> if (!session) {
</span><span class="lines">@@ -482,7 +482,7 @@
</span><span class="cx"> serializedObject = buildInspectorObjectForSession(session);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InspectorReplayAgent::getSerializedSegment(ErrorString* errorString, SegmentIdentifier identifier, RefPtr<Inspector::TypeBuilder::Replay::SessionSegment>& serializedObject)
</del><ins>+void InspectorReplayAgent::getSegmentData(ErrorString* errorString, SegmentIdentifier identifier, RefPtr<Inspector::TypeBuilder::Replay::SessionSegment>& serializedObject)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<ReplaySessionSegment> segment = findSegment(errorString, identifier);
</span><span class="cx"> if (!segment) {
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorReplayAgenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorReplayAgent.h (172079 => 172080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorReplayAgent.h 2014-08-05 21:21:31 UTC (rev 172079)
+++ trunk/Source/WebCore/inspector/InspectorReplayAgent.h 2014-08-05 21:28:38 UTC (rev 172080)
</span><span class="lines">@@ -105,8 +105,8 @@
</span><span class="cx"> virtual void removeSessionSegment(ErrorString*, SessionIdentifier, int segmentIndex) override;
</span><span class="cx">
</span><span class="cx"> virtual void getAvailableSessions(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<SessionIdentifier>>&) override;
</span><del>- virtual void getSerializedSession(ErrorString*, SessionIdentifier, RefPtr<Inspector::TypeBuilder::Replay::ReplaySession>&) override;
- virtual void getSerializedSegment(ErrorString*, SegmentIdentifier, RefPtr<Inspector::TypeBuilder::Replay::SessionSegment>&) override;
</del><ins>+ virtual void getSessionData(ErrorString*, SessionIdentifier, RefPtr<Inspector::TypeBuilder::Replay::ReplaySession>&) override;
+ virtual void getSegmentData(ErrorString*, SegmentIdentifier, RefPtr<Inspector::TypeBuilder::Replay::SessionSegment>&) override;
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> PassRefPtr<ReplaySession> findSession(ErrorString*, SessionIdentifier);
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorprotocolReplayjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/protocol/Replay.json (172079 => 172080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/protocol/Replay.json 2014-08-05 21:21:31 UTC (rev 172079)
+++ trunk/Source/WebCore/inspector/protocol/Replay.json 2014-08-05 21:28:38 UTC (rev 172080)
</span><span class="lines">@@ -119,8 +119,8 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "getSerializedSession",
- "description": "Returns the specified session serialized to a JSON object.",
</del><ins>+ "name": "getSessionData",
+ "description": "Returns an object for the specified session.",
</ins><span class="cx"> "parameters": [
</span><span class="cx"> { "name": "sessionIdentifier", "$ref": "SessionIdentifier" }
</span><span class="cx"> ],
</span><span class="lines">@@ -129,8 +129,8 @@
</span><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><del>- "name": "getSerializedSegment",
- "description": "Returns the session segment serialized to a JSON object.",
</del><ins>+ "name": "getSegmentData",
+ "description": "Returns an object for the specified session segment.",
</ins><span class="cx"> "parameters": [
</span><span class="cx"> { "name": "id", "$ref": "SegmentIdentifier" }
</span><span class="cx"> ],
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (172079 => 172080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-08-05 21:21:31 UTC (rev 172079)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-08-05 21:28:38 UTC (rev 172080)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2014-08-05 Brian J. Burg <burg@cs.washington.edu>
</span><span class="cx">
</span><ins>+ Web Replay: rename protocol methods for getting replay session/segment data
+ https://bugs.webkit.org/show_bug.cgi?id=135618
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Controllers/ReplayManager.js:
+ (WebInspector.ReplayManager.prototype.getSession.get var):
+ (WebInspector.ReplayManager.prototype.getSegment.get var):
+ * UserInterface/Models/ReplaySession.js:
+ (WebInspector.ReplaySession.prototype.segmentsChanged):
+
+2014-08-05 Brian J. Burg <burg@cs.washington.edu>
+
</ins><span class="cx"> Web Inspector: cannot navigate between multiple applicable dashboards
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=135130
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersReplayManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js (172079 => 172080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js 2014-08-05 21:21:31 UTC (rev 172079)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js 2014-08-05 21:28:38 UTC (rev 172080)
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx"> if (this._sessionPromises.has(sessionId))
</span><span class="cx"> return this._sessionPromises.get(sessionId);
</span><span class="cx">
</span><del>- var newPromise = ReplayAgent.getSerializedSession.promise(sessionId)
</del><ins>+ var newPromise = ReplayAgent.getSessionData.promise(sessionId)
</ins><span class="cx"> .then(function(payload) {
</span><span class="cx"> return Promise.resolve(WebInspector.ReplaySession.fromPayload(sessionId, payload));
</span><span class="cx"> });
</span><span class="lines">@@ -154,7 +154,7 @@
</span><span class="cx"> if (this._segmentPromises.has(segmentId))
</span><span class="cx"> return this._segmentPromises.get(segmentId);
</span><span class="cx">
</span><del>- var newPromise = ReplayAgent.getSerializedSegment.promise(segmentId)
</del><ins>+ var newPromise = ReplayAgent.getSegmentData.promise(segmentId)
</ins><span class="cx"> .then(function(payload) {
</span><span class="cx"> return Promise.resolve(new WebInspector.ReplaySessionSegment(segmentId, payload));
</span><span class="cx"> });
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsReplaySessionjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ReplaySession.js (172079 => 172080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/ReplaySession.js 2014-08-05 21:21:31 UTC (rev 172079)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ReplaySession.js 2014-08-05 21:28:38 UTC (rev 172080)
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx"> segmentsChanged: function()
</span><span class="cx"> {
</span><span class="cx"> // The replay manager won't update the session's list of segments nor create a new session.
</span><del>- ReplayAgent.getSerializedSession.promise(this.identifier)
</del><ins>+ ReplayAgent.getSessionData.promise(this.identifier)
</ins><span class="cx"> .then(this._updateFromPayload.bind(this));
</span><span class="cx"> },
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>