<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171940] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171940">171940</a></dd>
<dt>Author</dt> <dd>jonowells@apple.com</dd>
<dt>Date</dt> <dd>2014-08-01 12:06:55 -0700 (Fri, 01 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Timeline header height doesn't match style updates.
https://bugs.webkit.org/show_bug.cgi?id=135516
Reviewed by Timothy Hatcher.
Update the timeline header height to match the updates
to the navigation bars in other panels made in
https://bugs.webkit.org/show_bug.cgi?id=135445. Also
update the shadows on some of the search bars.
* UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]):
(body.mac-platform.legacy .filter-bar > input[type="search"]):
* UserInterface/Views/FindBanner.css:
(.find-banner > input[type="search"]):
(body.mac-platform.legacy .find-banner > input[type="search"]):
* UserInterface/Views/LogContentView.css:
(.search-bar.log-search-bar > input[type="search"]):
(body.mac-platform.legacy .search-bar.log-search-bar > input[type="search"]):
Remove inset shadows on search bars.
* UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .status-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(.sidebar > .panel.navigation.timeline > .title-bar.timelines):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timelines):
(.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(.sidebar > .panel.navigation.timeline > .timelines-content):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content):
(.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder):
Update the height of the timeline status bar.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsFilterBarcss">trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsFindBannercss">trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPanelcss">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (171939 => 171940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-08-01 18:57:39 UTC (rev 171939)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-08-01 19:06:55 UTC (rev 171940)
</span><span class="lines">@@ -1,3 +1,43 @@
</span><ins>+2014-08-01 Jonathan Wells <jonowells@apple.com>
+
+ Web Inspector: Timeline header height doesn't match style updates.
+ https://bugs.webkit.org/show_bug.cgi?id=135516
+
+ Reviewed by Timothy Hatcher.
+
+ Update the timeline header height to match the updates
+ to the navigation bars in other panels made in
+ https://bugs.webkit.org/show_bug.cgi?id=135445. Also
+ update the shadows on some of the search bars.
+
+ * UserInterface/Views/FilterBar.css:
+ (.filter-bar > input[type="search"]):
+ (body.mac-platform.legacy .filter-bar > input[type="search"]):
+ * UserInterface/Views/FindBanner.css:
+ (.find-banner > input[type="search"]):
+ (body.mac-platform.legacy .find-banner > input[type="search"]):
+ * UserInterface/Views/LogContentView.css:
+ (.search-bar.log-search-bar > input[type="search"]):
+ (body.mac-platform.legacy .search-bar.log-search-bar > input[type="search"]):
+ Remove inset shadows on search bars.
+
+ * UserInterface/Views/TimelineSidebarPanel.css:
+ (.sidebar > .panel.navigation.timeline > .status-bar):
+ (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar):
+ (.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
+ (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
+ (.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
+ (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-status):
+ (.sidebar > .panel.navigation.timeline > .title-bar.timelines):
+ (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timelines):
+ (.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
+ (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
+ (.sidebar > .panel.navigation.timeline > .timelines-content):
+ (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content):
+ (.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
+ (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder):
+ Update the height of the timeline status bar.
+
</ins><span class="cx"> 2014-07-31 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: "Stop Recording" button feels unresponsive, recording takes a long time to stop
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsFilterBarcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.css (171939 => 171940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.css 2014-08-01 18:57:39 UTC (rev 171939)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.css 2014-08-01 19:06:55 UTC (rev 171940)
</span><span class="lines">@@ -49,7 +49,6 @@
</span><span class="cx"> border: 1px solid rgba(0, 0, 0, 0.25);
</span><span class="cx"> border-radius: 3px;
</span><span class="cx"> background-color: rgba(255, 255, 255, 0.2);
</span><del>- box-shadow: inset rgba(0, 0, 0, 0.1) 0 1px 0;
</del><span class="cx"> background-clip: padding-box;
</span><span class="cx">
</span><span class="cx"> height: 22px;
</span><span class="lines">@@ -58,6 +57,7 @@
</span><span class="cx"> body.mac-platform.legacy .filter-bar > input[type="search"] {
</span><span class="cx"> border: 1px solid rgba(0, 0, 0, 0.35);
</span><span class="cx"> border-radius: 10px;
</span><ins>+ box-shadow: inset rgba(0, 0, 0, 0.1) 0 1px 0;
</ins><span class="cx">
</span><span class="cx"> height: 19px;
</span><span class="cx"> transition: background-color 200ms ease-in-out;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsFindBannercss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.css (171939 => 171940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.css 2014-08-01 18:57:39 UTC (rev 171939)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.css 2014-08-01 19:06:55 UTC (rev 171940)
</span><span class="lines">@@ -88,6 +88,9 @@
</span><span class="cx"> border: 1px solid rgb(146, 146, 146);
</span><span class="cx"> border-radius: 4px;
</span><span class="cx"> background-color: white;
</span><ins>+}
+
+body.mac-platform.legacy .find-banner > input[type="search"] {
</ins><span class="cx"> box-shadow: inset rgba(0, 0, 0, 0.1) 0 1px 0;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (171939 => 171940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2014-08-01 18:57:39 UTC (rev 171939)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2014-08-01 19:06:55 UTC (rev 171940)
</span><span class="lines">@@ -415,8 +415,13 @@
</span><span class="cx"> .search-bar.log-search-bar > input[type="search"] {
</span><span class="cx"> width: 150px;
</span><span class="cx"> border: 1px solid rgba(0, 0, 0, 0.35);
</span><ins>+ padding-left: 4px;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+body.mac-platform.legacy .search-bar.log-search-bar > input[type="search"] {
+ padding-left: 0;
+}
+
</ins><span class="cx"> .search-in-progress .console-item.filtered-out-by-search {
</span><span class="cx"> display: none;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPanelcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css (171939 => 171940)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css 2014-08-01 18:57:39 UTC (rev 171939)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.css 2014-08-01 19:06:55 UTC (rev 171940)
</span><span class="lines">@@ -28,13 +28,17 @@
</span><span class="cx"> top: 0;
</span><span class="cx"> left: 0;
</span><span class="cx"> right: 0;
</span><del>- height: 22px;
</del><ins>+ height: 29px;
</ins><span class="cx"> border-bottom: 1px solid rgb(179, 179, 179);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar {
+ height: 22px;
+}
+
</ins><span class="cx"> .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph {
</span><span class="cx"> position: absolute;
</span><del>- top: 0;
</del><ins>+ top: 3px;
</ins><span class="cx"> left: 5px;
</span><span class="cx"> width: 21px;
</span><span class="cx"> height: 21px;
</span><span class="lines">@@ -52,6 +56,10 @@
</span><span class="cx"> background-size: 21px 21px;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph {
+ top: 0;
+}
+
</ins><span class="cx"> .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording {
</span><span class="cx"> background-image: -webkit-image-set(url(../Images/Recording.png) 1x, url(../Images/Recording@2x.png) 2x);
</span><span class="cx"> }
</span><span class="lines">@@ -74,7 +82,7 @@
</span><span class="cx">
</span><span class="cx"> .sidebar > .panel.navigation.timeline > .status-bar > .record-status {
</span><span class="cx"> position: absolute;
</span><del>- top: 0;
</del><ins>+ top: 3px;
</ins><span class="cx"> right: 21px;
</span><span class="cx"> left: 27px;
</span><span class="cx">
</span><span class="lines">@@ -87,6 +95,10 @@
</span><span class="cx"> text-shadow: rgba(255, 255, 255, 0.5) 0 1px 0;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-status {
+ top: 0;
+}
+
</ins><span class="cx"> .sidebar > .panel.navigation.timeline > .title-bar {
</span><span class="cx"> position: absolute;
</span><span class="cx"> left: 0;
</span><span class="lines">@@ -117,18 +129,26 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .sidebar > .panel.navigation.timeline > .title-bar.timelines {
</span><ins>+ top: 29px;
+}
+
+body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timelines {
</ins><span class="cx"> top: 22px;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .sidebar > .panel.navigation.timeline > .title-bar.timeline-events {
</span><span class="cx"> height: 23px;
</span><span class="cx"> border-top: 1px solid rgb(179, 179, 179);
</span><ins>+ top: 159px;
+}
+
+body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar.timeline-events {
</ins><span class="cx"> top: 152px;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .sidebar > .panel.navigation.timeline > .timelines-content {
</span><span class="cx"> position: absolute;
</span><del>- top: 44px;
</del><ins>+ top: 51px;
</ins><span class="cx"> height: 108px;
</span><span class="cx"> left: 0;
</span><span class="cx"> right: 0;
</span><span class="lines">@@ -136,6 +156,10 @@
</span><span class="cx"> overflow: hidden;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content {
+ top: 44px;
+}
+
</ins><span class="cx"> .sidebar > .panel.navigation.timeline > .timelines-content .close-button {
</span><span class="cx"> margin-top: 2px;
</span><span class="cx"> width: 12px;
</span><span class="lines">@@ -191,6 +215,11 @@
</span><span class="cx">
</span><span class="cx"> .sidebar > .panel.navigation.timeline > .content,
</span><span class="cx"> .sidebar > .panel.navigation.timeline > .empty-content-placeholder {
</span><ins>+ top: 182px;
+}
+
+body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content,
+body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder {
</ins><span class="cx"> top: 175px;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>