<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171897] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171897">171897</a></dd>
<dt>Author</dt> <dd>bfulgham@apple.com</dd>
<dt>Date</dt> <dd>2014-07-31 17:15:16 -0700 (Thu, 31 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
https://bugs.webkit.org/show_bug.cgi?id=135482
Reviewed by Simon Fraser.
Source/WebKit2:
Add accessors for the missing Fullscreen API so that MiniBrowser
can use them.
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _fullScreenIsEnabled]): Added.
(-[WKPreferences _setFullScreenEnabled:]): Added.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h: Add accessor for
Fullscreen mode.
Tools:
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
feature.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKPreferencesmm">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKPreferencesPrivateh">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsMiniBrowsermacWK2BrowserWindowControllerm">trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (171896 => 171897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Source/WebKit2/ChangeLog 2014-08-01 00:15:16 UTC (rev 171897)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-07-31 Brent Fulgham <bfulgham@apple.com>
+
+ MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
+ https://bugs.webkit.org/show_bug.cgi?id=135482
+
+ Reviewed by Simon Fraser.
+
+ Add accessors for the missing Fullscreen API so that MiniBrowser
+ can use them.
+
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences _fullScreenIsEnabled]): Added.
+ (-[WKPreferences _setFullScreenEnabled:]): Added.
+ * UIProcess/API/Cocoa/WKPreferencesPrivate.h: Add accessor for
+ Fullscreen mode.
+
</ins><span class="cx"> 2014-07-31 Beth Dakin <bdakin@apple.com>
</span><span class="cx">
</span><span class="cx"> Hit-testing broken in WebKit 1 views with AppKit's contentInsets
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (171896 => 171897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-08-01 00:15:16 UTC (rev 171897)
</span><span class="lines">@@ -163,6 +163,16 @@
</span><span class="cx"> _preferences->setOfflineWebApplicationCacheEnabled(offlineApplicationCacheIsEnabled);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (BOOL)_fullScreenIsEnabled
+{
+ return _preferences->fullScreenEnabled();
+}
+
+- (void)_setFullScreenEnabled:(BOOL)fullScreenEnabled
+{
+ _preferences->setFullScreenEnabled(fullScreenEnabled);
+}
+
</ins><span class="cx"> - (BOOL)_compositingBordersVisible
</span><span class="cx"> {
</span><span class="cx"> return _preferences->compositingBordersVisible();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h (171896 => 171897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2014-08-01 00:15:16 UTC (rev 171897)
</span><span class="lines">@@ -50,6 +50,7 @@
</span><span class="cx"> // FIXME: This should be configured on the WKWebsiteDataStore.
</span><span class="cx"> // FIXME: This property should not have the verb "is" in it.
</span><span class="cx"> @property (nonatomic, setter=_setOfflineApplicationCacheIsEnabled:) BOOL _offlineApplicationCacheIsEnabled;
</span><ins>+@property (nonatomic, setter=_setFullScreenEnabled:) BOOL _fullScreenIsEnabled;
</ins><span class="cx">
</span><span class="cx"> @end
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (171896 => 171897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Tools/ChangeLog 2014-08-01 00:15:16 UTC (rev 171897)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-07-31 Brent Fulgham <bfulgham@apple.com>
+
+ MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
+ https://bugs.webkit.org/show_bug.cgi?id=135482
+
+ Reviewed by Simon Fraser.
+
+ * MiniBrowser/mac/WK2BrowserWindowController.m:
+ (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
+ feature.
+
</ins><span class="cx"> 2014-07-31 Alexey Proskuryakov <ap@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
</span></span></pre></div>
<a id="trunkToolsMiniBrowsermacWK2BrowserWindowControllerm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (171896 => 171897)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-07-31 23:55:31 UTC (rev 171896)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-08-01 00:15:16 UTC (rev 171897)
</span><span class="lines">@@ -59,6 +59,7 @@
</span><span class="cx"> configuration.preferences._tiledScrollingIndicatorVisible = [self tiledScrollingIndicatorVisible];
</span><span class="cx"> configuration.preferences._compositingBordersVisible = [self layerBordersVisible];
</span><span class="cx"> configuration.preferences._compositingRepaintCountersVisible = [self layerBordersVisible];
</span><ins>+ configuration.preferences._fullScreenIsEnabled = YES;
</ins><span class="cx"> }
</span><span class="cx"> _webView = [[WKWebView alloc] initWithFrame:[containerView bounds] configuration:configuration];
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>