<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171831] trunk/Source/WebCore</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171831">171831</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-30 20:15:10 -0700 (Wed, 30 Jul 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Clean up YouTubeEmbedShadowElement
https://bugs.webkit.org/show_bug.cgi?id=135437

Patch by Benjamin Poulain &lt;bpoulain@apple.com&gt; on 2014-07-30
Reviewed by Andreas Kling.

* html/shadow/YouTubeEmbedShadowElement.cpp:
(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement): Deleted.
This is unused in WebCore.

(WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Deleted.
Use the generic pseudo path instead of a custom shadowPseudoId.
* html/shadow/YouTubeEmbedShadowElement.h:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowYouTubeEmbedShadowElementcpp">trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlshadowYouTubeEmbedShadowElementh">trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171830 => 171831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-07-31 03:14:11 UTC (rev 171830)
+++ trunk/Source/WebCore/ChangeLog        2014-07-31 03:15:10 UTC (rev 171831)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2014-07-30  Benjamin Poulain  &lt;bpoulain@apple.com&gt;
</span><span class="cx"> 
</span><ins>+        Clean up YouTubeEmbedShadowElement
+        https://bugs.webkit.org/show_bug.cgi?id=135437
+
+        Reviewed by Andreas Kling.
+
+        * html/shadow/YouTubeEmbedShadowElement.cpp:
+        (WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
+        (WebCore::YouTubeEmbedShadowElement::pluginElement): Deleted.
+        This is unused in WebCore.
+
+        (WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Deleted.
+        Use the generic pseudo path instead of a custom shadowPseudoId.
+        * html/shadow/YouTubeEmbedShadowElement.h:
+
+2014-07-30  Benjamin Poulain  &lt;bpoulain@apple.com&gt;
+
</ins><span class="cx">         Remove shadowPseudoId() from InputFieldSpeechButtonElement and SearchFieldCancelButtonElement
</span><span class="cx">         https://bugs.webkit.org/show_bug.cgi?id=135438
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowYouTubeEmbedShadowElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp (171830 => 171831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp        2014-07-31 03:14:11 UTC (rev 171830)
+++ trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp        2014-07-31 03:15:10 UTC (rev 171831)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2012 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2012, 2014 Apple Inc. All rights reserved.
</ins><span class="cx">  *
</span><span class="cx">  * Redistribution and use in source and binary forms, with or without
</span><span class="cx">  * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -30,8 +30,6 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-using namespace HTMLNames;
-
</del><span class="cx"> PassRefPtr&lt;YouTubeEmbedShadowElement&gt; YouTubeEmbedShadowElement::create(Document&amp; doc)
</span><span class="cx"> {
</span><span class="cx">     return adoptRef(new YouTubeEmbedShadowElement(doc));
</span><span class="lines">@@ -40,7 +38,7 @@
</span><span class="cx"> YouTubeEmbedShadowElement::YouTubeEmbedShadowElement(Document&amp; document)
</span><span class="cx">     : HTMLDivElement(HTMLNames::divTag, document)
</span><span class="cx"> {
</span><del>-    setPseudo(shadowPseudoId());
</del><ins>+    setPseudo(AtomicString(&quot;-webkit-plugin-replacement&quot;, AtomicString::ConstructFromLiteral));
</ins><span class="cx"> 
</span><span class="cx">     setInlineStyleProperty(CSSPropertyDisplay, CSSValueInlineBlock);
</span><span class="cx">     setInlineStyleProperty(CSSPropertyPosition, CSSValueRelative);
</span><span class="lines">@@ -48,17 +46,4 @@
</span><span class="cx">     setInlineStyleProperty(CSSPropertyHeight, CSSValue100);
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-HTMLPlugInImageElement* YouTubeEmbedShadowElement::pluginElement() const
-{
-    Node* node = const_cast&lt;YouTubeEmbedShadowElement*&gt;(this)-&gt;deprecatedShadowAncestorNode();
-    ASSERT(!node || embedTag == toElement(node)-&gt;tagQName() || objectTag == toElement(node)-&gt;tagQName());
-    return static_cast&lt;HTMLPlugInImageElement*&gt;(node);
</del><span class="cx"> }
</span><del>-
-const AtomicString&amp; YouTubeEmbedShadowElement::shadowPseudoId() const
-{
-    DEPRECATED_DEFINE_STATIC_LOCAL(AtomicString, pseudoId, (&quot;-webkit-plugin-replacement&quot;));
-    return pseudoId;
-}
-
-}
</del></span></pre></div>
<a id="trunkSourceWebCorehtmlshadowYouTubeEmbedShadowElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h (171830 => 171831)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h        2014-07-31 03:14:11 UTC (rev 171830)
+++ trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h        2014-07-31 03:15:10 UTC (rev 171831)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> /*
</span><del>- * Copyright (C) 2012 Apple Inc. All rights reserved.
</del><ins>+ * Copyright (C) 2012, 2014 Apple Inc. All rights reserved.
</ins><span class="cx">  *
</span><span class="cx">  * Redistribution and use in source and binary forms, with or without
</span><span class="cx">  * modification, are permitted provided that the following conditions
</span><span class="lines">@@ -31,15 +31,10 @@
</span><span class="cx"> 
</span><span class="cx"> namespace WebCore {
</span><span class="cx"> 
</span><del>-class HTMLPlugInImageElement;
-
</del><span class="cx"> class YouTubeEmbedShadowElement final : public HTMLDivElement {
</span><span class="cx"> public:
</span><span class="cx">     static PassRefPtr&lt;YouTubeEmbedShadowElement&gt; create(Document&amp;);
</span><span class="cx"> 
</span><del>-    virtual const AtomicString&amp; shadowPseudoId() const override;
-    HTMLPlugInImageElement* pluginElement() const;
-
</del><span class="cx"> private:
</span><span class="cx">     YouTubeEmbedShadowElement(Document&amp;);
</span><span class="cx"> };
</span></span></pre>
</div>
</div>

</body>
</html>