<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171795] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171795">171795</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2014-07-30 00:47:33 -0700 (Wed, 30 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[TexMap] Move TextureMapperLayer::textureMapper() definition into the header
https://bugs.webkit.org/show_bug.cgi?id=135384
Reviewed by Martin Robinson.
Move the definitions of TextureMapperLayer::textureMapper() and TextureMapperLayer::rootLayer()
into the TextureMapperLayer header. This makes both functions inline-able, removing unnecessary
calling overhead in GraphicsLayerTextureMapper::flushCompositingState() and
GraphicsLayerTextureMapper::updateBackingStoreIfNeeded().
TextureMapperLayer::rootLayer() now also returns a reference.
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer): Deleted.
(WebCore::TextureMapperLayer::textureMapper): Deleted.
* platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::textureMapper):
(WebCore::TextureMapperLayer::rootLayer):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicstexmapTextureMapperLayercpp">trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicstexmapTextureMapperLayerh">trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171794 => 171795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-30 07:47:22 UTC (rev 171794)
+++ trunk/Source/WebCore/ChangeLog 2014-07-30 07:47:33 UTC (rev 171795)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2014-07-30 Zan Dobersek <zdobersek@igalia.com>
+
+ [TexMap] Move TextureMapperLayer::textureMapper() definition into the header
+ https://bugs.webkit.org/show_bug.cgi?id=135384
+
+ Reviewed by Martin Robinson.
+
+ Move the definitions of TextureMapperLayer::textureMapper() and TextureMapperLayer::rootLayer()
+ into the TextureMapperLayer header. This makes both functions inline-able, removing unnecessary
+ calling overhead in GraphicsLayerTextureMapper::flushCompositingState() and
+ GraphicsLayerTextureMapper::updateBackingStoreIfNeeded().
+
+ TextureMapperLayer::rootLayer() now also returns a reference.
+
+ * platform/graphics/texmap/TextureMapperLayer.cpp:
+ (WebCore::TextureMapperLayer::~TextureMapperLayer):
+ (WebCore::TextureMapperLayer::rootLayer): Deleted.
+ (WebCore::TextureMapperLayer::textureMapper): Deleted.
+ * platform/graphics/texmap/TextureMapperLayer.h:
+ (WebCore::TextureMapperLayer::textureMapper):
+ (WebCore::TextureMapperLayer::rootLayer):
+
</ins><span class="cx"> 2014-07-29 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> Crash when using 'em' units to specify font-size inside animation keyframe.
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicstexmapTextureMapperLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (171794 => 171795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2014-07-30 07:47:22 UTC (rev 171794)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2014-07-30 07:47:33 UTC (rev 171795)
</span><span class="lines">@@ -41,15 +41,6 @@
</span><span class="cx"> { }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-const TextureMapperLayer* TextureMapperLayer::rootLayer() const
-{
- if (m_effectTarget)
- return m_effectTarget->rootLayer();
- if (m_parent)
- return m_parent->rootLayer();
- return this;
-}
-
</del><span class="cx"> void TextureMapperLayer::computeTransformsRecursive()
</span><span class="cx"> {
</span><span class="cx"> if (m_state.size.isEmpty() && m_state.masksToBounds)
</span><span class="lines">@@ -467,11 +458,6 @@
</span><span class="cx"> removeFromParent();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-TextureMapper* TextureMapperLayer::textureMapper() const
-{
- return rootLayer()->m_textureMapper;
-}
-
</del><span class="cx"> void TextureMapperLayer::setChildren(const Vector<TextureMapperLayer*>& newChildren)
</span><span class="cx"> {
</span><span class="cx"> removeAllChildren();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicstexmapTextureMapperLayerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h (171794 => 171795)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2014-07-30 07:47:22 UTC (rev 171794)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2014-07-30 07:47:33 UTC (rev 171795)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> void setIsScrollable(bool isScrollable) { m_isScrollable = isScrollable; }
</span><span class="cx"> bool isScrollable() const { return m_isScrollable; }
</span><span class="cx">
</span><del>- TextureMapper* textureMapper() const;
</del><ins>+ TextureMapper* textureMapper() const { return rootLayer().m_textureMapper; }
</ins><span class="cx"> void setTextureMapper(TextureMapper* texmap) { m_textureMapper = texmap; }
</span><span class="cx">
</span><span class="cx"> void setChildren(const Vector<TextureMapperLayer*>&);
</span><span class="lines">@@ -134,7 +134,14 @@
</span><span class="cx"> void addChild(TextureMapperLayer*);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- const TextureMapperLayer* rootLayer() const;
</del><ins>+ const TextureMapperLayer& rootLayer() const
+ {
+ if (m_effectTarget)
+ return m_effectTarget->rootLayer();
+ if (m_parent)
+ return m_parent->rootLayer();
+ return *this;
+ }
</ins><span class="cx"> void computeTransformsRecursive();
</span><span class="cx">
</span><span class="cx"> static int compareGraphicsLayersZValue(const void* a, const void* b);
</span></span></pre>
</div>
</div>
</body>
</html>