<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171838] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171838">171838</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-07-30 22:38:30 -0700 (Wed, 30 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>PropertyName's internal string is always atomic.
<https://webkit.org/b/135451>
Source/JavaScriptCore:
Now that we've merged the JSC::Identifier and WTF::AtomicString tables,
we know that any string that's an Identifier is guaranteed to be atomic.
A PropertyName can be either an Identifier or a PrivateName, and the
private names are also guaranteed to be atomic internally.
Make PropertyName vend AtomicStringImpl* instead of StringImpl*.
Reviewed by Benjamin Poulain.
* runtime/PropertyName.h:
(JSC::PropertyName::PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):
Source/WebCore:
Use PropertyName::publicName() directly instead of taking the slow route
through AtomicString::findStringWithHash().
These strings are always atomic, and findStringWithHash() would trudge
through a full hash lookup just to discover that indeed, they are!
Reviewed by Benjamin Poulain.
* bindings/js/JSDOMBinding.cpp:
(WebCore::findAtomicString): Deleted.
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):
Source/WTF:
Remove AtomicString::findStringWithHash() since nobody uses it anymore.
Reviewed by Benjamin Poulain.
* wtf/text/AtomicString.cpp:
(WTF::findString): Deleted.
(WTF::AtomicString::findStringWithHash): Deleted.
* wtf/text/AtomicString.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimePropertyNameh">trunk/Source/JavaScriptCore/runtime/PropertyName.h</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtftextAtomicStringcpp">trunk/Source/WTF/wtf/text/AtomicString.cpp</a></li>
<li><a href="#trunkSourceWTFwtftextAtomicStringh">trunk/Source/WTF/wtf/text/AtomicString.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBindingcpp">trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBindingh">trunk/Source/WebCore/bindings/js/JSDOMBinding.h</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp">trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSHTMLDocumentCustomcpp">trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-07-30 Andreas Kling <akling@apple.com>
+
+ PropertyName's internal string is always atomic.
+ <https://webkit.org/b/135451>
+
+ Now that we've merged the JSC::Identifier and WTF::AtomicString tables,
+ we know that any string that's an Identifier is guaranteed to be atomic.
+
+ A PropertyName can be either an Identifier or a PrivateName, and the
+ private names are also guaranteed to be atomic internally.
+
+ Make PropertyName vend AtomicStringImpl* instead of StringImpl*.
+
+ Reviewed by Benjamin Poulain.
+
+ * runtime/PropertyName.h:
+ (JSC::PropertyName::PropertyName):
+ (JSC::PropertyName::uid):
+ (JSC::PropertyName::publicName):
+
</ins><span class="cx"> 2014-07-30 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimePropertyNameh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/PropertyName.h (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/PropertyName.h 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/JavaScriptCore/runtime/PropertyName.h 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -79,25 +79,27 @@
</span><span class="cx"> class PropertyName {
</span><span class="cx"> public:
</span><span class="cx"> PropertyName(const Identifier& propertyName)
</span><del>- : m_impl(propertyName.impl())
</del><ins>+ : m_impl(static_cast<AtomicStringImpl*>(propertyName.impl()))
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!m_impl || m_impl->isAtomic());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PropertyName(const PrivateName& propertyName)
</span><del>- : m_impl(propertyName.uid())
</del><ins>+ : m_impl(static_cast<AtomicStringImpl*>(propertyName.uid()))
</ins><span class="cx"> {
</span><del>- ASSERT(m_impl && m_impl->isEmptyUnique());
</del><ins>+ ASSERT(m_impl);
+ ASSERT(m_impl->isEmptyUnique());
+ ASSERT(m_impl->isAtomic());
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- StringImpl* uid() const
</del><ins>+ AtomicStringImpl* uid() const
</ins><span class="cx"> {
</span><span class="cx"> return m_impl;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- StringImpl* publicName() const
</del><ins>+ AtomicStringImpl* publicName() const
</ins><span class="cx"> {
</span><del>- return m_impl->isEmptyUnique() ? 0 : m_impl;
</del><ins>+ return m_impl->isEmptyUnique() ? nullptr : m_impl;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static const uint32_t NotAnIndex = UINT_MAX;
</span><span class="lines">@@ -108,7 +110,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- StringImpl* m_impl;
</del><ins>+ AtomicStringImpl* m_impl;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> inline bool operator==(PropertyName a, const Identifier& b)
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/WTF/ChangeLog 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-07-30 Andreas Kling <akling@apple.com>
+
+ PropertyName's internal string is always atomic.
+ <https://webkit.org/b/135451>
+
+ Remove AtomicString::findStringWithHash() since nobody uses it anymore.
+
+ Reviewed by Benjamin Poulain.
+
+ * wtf/text/AtomicString.cpp:
+ (WTF::findString): Deleted.
+ (WTF::AtomicString::findStringWithHash): Deleted.
+ * wtf/text/AtomicString.h:
+
</ins><span class="cx"> 2014-07-30 Andy Estes <aestes@apple.com>
</span><span class="cx">
</span><span class="cx"> USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
</span></span></pre></div>
<a id="trunkSourceWTFwtftextAtomicStringcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/AtomicString.cpp (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/AtomicString.cpp 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/WTF/wtf/text/AtomicString.cpp 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -432,31 +432,6 @@
</span><span class="cx"> return *addResult.iterator;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-template<typename CharacterType>
-static inline HashSet<StringImpl*>::iterator findString(const StringImpl* stringImpl)
-{
- HashAndCharacters<CharacterType> buffer = { stringImpl->existingHash(), stringImpl->characters<CharacterType>(), stringImpl->length() };
- return stringTable().find<HashAndCharactersTranslator<CharacterType>>(buffer);
-}
-
-AtomicStringImpl* AtomicString::findStringWithHash(const StringImpl& stringImpl)
-{
- ASSERT(stringImpl.existingHash());
-
- if (!stringImpl.length())
- return static_cast<AtomicStringImpl*>(StringImpl::empty());
-
- AtomicStringTableLocker locker;
- HashSet<StringImpl*>::iterator iterator;
- if (stringImpl.is8Bit())
- iterator = findString<LChar>(&stringImpl);
- else
- iterator = findString<UChar>(&stringImpl);
- if (iterator == stringTable().end())
- return 0;
- return static_cast<AtomicStringImpl*>(*iterator);
-}
-
</del><span class="cx"> void AtomicString::remove(StringImpl* string)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(string->isAtomic());
</span></span></pre></div>
<a id="trunkSourceWTFwtftextAtomicStringh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/AtomicString.h (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/AtomicString.h 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/WTF/wtf/text/AtomicString.h 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -86,7 +86,6 @@
</span><span class="cx"> AtomicString(WTF::HashTableDeletedValueType) : m_string(WTF::HashTableDeletedValue) { }
</span><span class="cx"> bool isHashTableDeletedValue() const { return m_string.isHashTableDeletedValue(); }
</span><span class="cx">
</span><del>- WTF_EXPORT_STRING_API static AtomicStringImpl* findStringWithHash(const StringImpl&);
</del><span class="cx"> WTF_EXPORT_STRING_API static AtomicStringImpl* find(LChar*, unsigned length);
</span><span class="cx"> WTF_EXPORT_STRING_API static AtomicStringImpl* find(UChar*, unsigned length);
</span><span class="cx"> static AtomicStringImpl* find(StringImpl* string)
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/WebCore/ChangeLog 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2014-07-30 Andreas Kling <akling@apple.com>
+
+ PropertyName's internal string is always atomic.
+ <https://webkit.org/b/135451>
+
+ Use PropertyName::publicName() directly instead of taking the slow route
+ through AtomicString::findStringWithHash().
+
+ These strings are always atomic, and findStringWithHash() would trudge
+ through a full hash lookup just to discover that indeed, they are!
+
+ Reviewed by Benjamin Poulain.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::findAtomicString): Deleted.
+ * bindings/js/JSDOMBinding.h:
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::namedItemGetter):
+ (WebCore::JSDOMWindow::getOwnPropertySlot):
+ (WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::JSHTMLDocument::canGetItemsForName):
+ (WebCore::JSHTMLDocument::nameGetter):
+
</ins><span class="cx"> 2014-07-30 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><span class="cx"> ElementRuleCollector: group the shadow tree code
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBindingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -98,15 +98,6 @@
</span><span class="cx"> return jsStringWithCache(exec, url.string());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-AtomicStringImpl* findAtomicString(PropertyName propertyName)
-{
- StringImpl* impl = propertyName.publicName();
- if (!impl)
- return 0;
- ASSERT(impl->existingHash());
- return AtomicString::findStringWithHash(*impl);
-}
-
</del><span class="cx"> String valueToStringWithNullCheck(ExecState* exec, JSValue value)
</span><span class="cx"> {
</span><span class="cx"> if (value.isNull())
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBindingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -283,7 +283,6 @@
</span><span class="cx"> String propertyNameToString(JSC::PropertyName);
</span><span class="cx">
</span><span class="cx"> AtomicString propertyNameToAtomicString(JSC::PropertyName);
</span><del>-AtomicStringImpl* findAtomicString(JSC::PropertyName);
</del><span class="cx">
</span><span class="cx"> String valueToStringWithNullCheck(JSC::ExecState*, JSC::JSValue); // null if the value is null
</span><span class="cx"> String valueToStringWithUndefinedOrNullCheck(JSC::ExecState*, JSC::JSValue); // null if the value is null or undefined
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMWindowCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> ASSERT(document);
</span><span class="cx"> ASSERT(document->isHTMLDocument());
</span><span class="cx">
</span><del>- AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName);
</del><ins>+ AtomicStringImpl* atomicPropertyName = propertyName.publicName();
</ins><span class="cx"> if (!atomicPropertyName || !toHTMLDocument(document)->hasWindowNamedItem(*atomicPropertyName))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx">
</span><span class="lines">@@ -245,7 +245,7 @@
</span><span class="cx"> // Allow shortcuts like 'Image1' instead of document.images.Image1
</span><span class="cx"> Document* document = thisObject->impl().frame()->document();
</span><span class="cx"> if (document->isHTMLDocument()) {
</span><del>- AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName);
</del><ins>+ AtomicStringImpl* atomicPropertyName = propertyName.publicName();
</ins><span class="cx"> if (atomicPropertyName && toHTMLDocument(document)->hasWindowNamedItem(*atomicPropertyName)) {
</span><span class="cx"> slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, namedItemGetter);
</span><span class="cx"> return true;
</span><span class="lines">@@ -322,7 +322,7 @@
</span><span class="cx"> // Allow shortcuts like 'Image1' instead of document.images.Image1
</span><span class="cx"> Document* document = thisObject->impl().frame()->document();
</span><span class="cx"> if (document->isHTMLDocument()) {
</span><del>- AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName);
</del><ins>+ AtomicStringImpl* atomicPropertyName = propertyName.publicName();
</ins><span class="cx"> if (atomicPropertyName && toHTMLDocument(document)->hasWindowNamedItem(*atomicPropertyName)) {
</span><span class="cx"> slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, namedItemGetter);
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSHTMLDocumentCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp (171837 => 171838)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2014-07-31 03:36:35 UTC (rev 171837)
+++ trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2014-07-31 05:38:30 UTC (rev 171838)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx">
</span><span class="cx"> bool JSHTMLDocument::canGetItemsForName(ExecState*, HTMLDocument* document, PropertyName propertyName)
</span><span class="cx"> {
</span><del>- AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName);
</del><ins>+ AtomicStringImpl* atomicPropertyName = propertyName.publicName();
</ins><span class="cx"> return atomicPropertyName && document->hasDocumentNamedItem(*atomicPropertyName);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> JSHTMLDocument* thisObj = jsCast<JSHTMLDocument*>(slotBase);
</span><span class="cx"> HTMLDocument& document = thisObj->impl();
</span><span class="cx">
</span><del>- AtomicStringImpl* atomicPropertyName = findAtomicString(propertyName);
</del><ins>+ AtomicStringImpl* atomicPropertyName = propertyName.publicName();
</ins><span class="cx"> if (!atomicPropertyName || !document.hasDocumentNamedItem(*atomicPropertyName))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>