<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171833] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171833">171833</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-30 20:16:52 -0700 (Wed, 30 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove UploadButtonElement::shadowPseudoId()
https://bugs.webkit.org/show_bug.cgi?id=135435
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.
Use the generic pseudo() path instead of a custom shadowPseudoId().
* html/FileInputType.cpp:
(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
(WebCore::UploadButtonElement::UploadButtonElement):
Set the type in the common constructor instead of the call sites.
(WebCore::UploadButtonElement::shadowPseudoId): Deleted.
* html/FileInputType.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlFileInputTypecpp">trunk/Source/WebCore/html/FileInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlFileInputTypeh">trunk/Source/WebCore/html/FileInputType.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171832 => 171833)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-31 03:16:05 UTC (rev 171832)
+++ trunk/Source/WebCore/ChangeLog 2014-07-31 03:16:52 UTC (rev 171833)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2014-07-30 Benjamin Poulain <bpoulain@apple.com>
</span><span class="cx">
</span><ins>+ Remove UploadButtonElement::shadowPseudoId()
+ https://bugs.webkit.org/show_bug.cgi?id=135435
+
+ Reviewed by Andreas Kling.
+
+ Use the generic pseudo() path instead of a custom shadowPseudoId().
+
+ * html/FileInputType.cpp:
+ (WebCore::UploadButtonElement::create):
+ (WebCore::UploadButtonElement::createForMultiple):
+ (WebCore::UploadButtonElement::UploadButtonElement):
+ Set the type in the common constructor instead of the call sites.
+ (WebCore::UploadButtonElement::shadowPseudoId): Deleted.
+ * html/FileInputType.h:
+
+2014-07-30 Benjamin Poulain <bpoulain@apple.com>
+
</ins><span class="cx"> Remove SpinButtonElement::shadowPseudoId
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=135436
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFileInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FileInputType.cpp (171832 => 171833)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FileInputType.cpp 2014-07-31 03:16:05 UTC (rev 171832)
+++ trunk/Source/WebCore/html/FileInputType.cpp 2014-07-31 03:16:52 UTC (rev 171833)
</span><span class="lines">@@ -45,21 +45,18 @@
</span><span class="cx">
</span><span class="cx"> using namespace HTMLNames;
</span><span class="cx">
</span><del>-class UploadButtonElement : public HTMLInputElement {
</del><ins>+class UploadButtonElement final : public HTMLInputElement {
</ins><span class="cx"> public:
</span><span class="cx"> static PassRefPtr<UploadButtonElement> create(Document&);
</span><span class="cx"> static PassRefPtr<UploadButtonElement> createForMultiple(Document&);
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> UploadButtonElement(Document&);
</span><del>-
- virtual const AtomicString& shadowPseudoId() const override;
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> PassRefPtr<UploadButtonElement> UploadButtonElement::create(Document& document)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<UploadButtonElement> button = adoptRef(new UploadButtonElement(document));
</span><del>- button->setType("button");
</del><span class="cx"> button->setValue(fileButtonChooseFileLabel());
</span><span class="cx"> return button.release();
</span><span class="cx"> }
</span><span class="lines">@@ -67,7 +64,6 @@
</span><span class="cx"> PassRefPtr<UploadButtonElement> UploadButtonElement::createForMultiple(Document& document)
</span><span class="cx"> {
</span><span class="cx"> RefPtr<UploadButtonElement> button = adoptRef(new UploadButtonElement(document));
</span><del>- button->setType("button");
</del><span class="cx"> button->setValue(fileButtonChooseMultipleFilesLabel());
</span><span class="cx"> return button.release();
</span><span class="cx"> }
</span><span class="lines">@@ -75,14 +71,10 @@
</span><span class="cx"> UploadButtonElement::UploadButtonElement(Document& document)
</span><span class="cx"> : HTMLInputElement(inputTag, document, 0, false)
</span><span class="cx"> {
</span><ins>+ setType(ASCIILiteral("button"));
+ setPseudo(AtomicString("-webkit-file-upload-button", AtomicString::ConstructFromLiteral));
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-const AtomicString& UploadButtonElement::shadowPseudoId() const
-{
- DEPRECATED_DEFINE_STATIC_LOCAL(AtomicString, pseudoId, ("-webkit-file-upload-button", AtomicString::ConstructFromLiteral));
- return pseudoId;
-}
-
</del><span class="cx"> FileInputType::FileInputType(HTMLInputElement& element)
</span><span class="cx"> : BaseClickableWithKeyInputType(element)
</span><span class="cx"> , m_fileList(FileList::create())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlFileInputTypeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/FileInputType.h (171832 => 171833)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/FileInputType.h 2014-07-31 03:16:05 UTC (rev 171832)
+++ trunk/Source/WebCore/html/FileInputType.h 2014-07-31 03:16:52 UTC (rev 171833)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx"> class FileList;
</span><span class="cx"> class Icon;
</span><span class="cx">
</span><del>-class FileInputType : public BaseClickableWithKeyInputType, private FileChooserClient, private FileIconLoaderClient {
</del><ins>+class FileInputType final : public BaseClickableWithKeyInputType, private FileChooserClient, private FileIconLoaderClient {
</ins><span class="cx"> public:
</span><span class="cx"> explicit FileInputType(HTMLInputElement&);
</span><span class="cx"> virtual ~FileInputType();
</span></span></pre>
</div>
</div>
</body>
</html>