<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171746] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171746">171746</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-29 08:47:39 -0700 (Tue, 29 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use WTF::move() instead of std::move() to help ensure move semantics
https://bugs.webkit.org/show_bug.cgi?id=135351
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
* bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::GetByIdVariant):
Source/WebCore:
* page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):
Source/WebKit2:
* UIProcess/API/Cocoa/_WKSessionState.mm:
(-[_WKSessionState _initWithSessionState:]):
* UIProcess/API/gtk/WebKitUserContent.cpp:
(toStringVector): Remove use of std::move(). It's unnecessary to call std::move() on an rvalue.
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::mouseEvent):
Source/WTF:
* wtf/HashTable.h:
(WTF::KeyTraits>::HashTable):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeGetByIdStatuscpp">trunk/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCorebytecodeGetByIdVariantcpp">trunk/Source/JavaScriptCore/bytecode/GetByIdVariant.cpp</a></li>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfHashTableh">trunk/Source/WTF/wtf/HashTable.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageCaptionUserPreferencescpp">trunk/Source/WebCore/page/CaptionUserPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoa_WKSessionStatemm">trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKSessionState.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkWebKitUserContentcpp">trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacServicesOverlayControllermm">trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-07-29 Daniel Bates <dabates@apple.com>
+
+ Use WTF::move() instead of std::move() to help ensure move semantics
+ https://bugs.webkit.org/show_bug.cgi?id=135351
+
+ Reviewed by Alexey Proskuryakov.
+
+ * bytecode/GetByIdStatus.cpp:
+ (JSC::GetByIdStatus::computeForStubInfo):
+ * bytecode/GetByIdVariant.cpp:
+ (JSC::GetByIdVariant::GetByIdVariant):
+
</ins><span class="cx"> 2014-07-28 Tamas Gergely <tgergely.u-szeged@partner.samsung.com>
</span><span class="cx">
</span><span class="cx"> BuildFix: JavaScriptCore/bytecode/StructureSet.h:262:77: warning.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeGetByIdStatuscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/JavaScriptCore/bytecode/GetByIdStatus.cpp 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -253,7 +253,7 @@
</span><span class="cx">
</span><span class="cx"> GetByIdVariant variant(
</span><span class="cx"> StructureSet(structure), myOffset, specificValue, chain.get(),
</span><del>- std::move(callLinkStatus));
</del><ins>+ WTF::move(callLinkStatus));
</ins><span class="cx">
</span><span class="cx"> if (!result.appendVariant(variant))
</span><span class="cx"> return GetByIdStatus(slowPathState, true);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebytecodeGetByIdVariantcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/bytecode/GetByIdVariant.cpp (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/bytecode/GetByIdVariant.cpp 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/JavaScriptCore/bytecode/GetByIdVariant.cpp 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -39,7 +39,7 @@
</span><span class="cx"> , m_alternateBase(nullptr)
</span><span class="cx"> , m_specificValue(specificValue)
</span><span class="cx"> , m_offset(offset)
</span><del>- , m_callLinkStatus(std::move(callLinkStatus))
</del><ins>+ , m_callLinkStatus(WTF::move(callLinkStatus))
</ins><span class="cx"> {
</span><span class="cx"> if (!structureSet.size()) {
</span><span class="cx"> ASSERT(offset == invalidOffset);
</span></span></pre></div>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WTF/ChangeLog 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-07-29 Daniel Bates <dabates@apple.com>
+
+ Use WTF::move() instead of std::move() to help ensure move semantics
+ https://bugs.webkit.org/show_bug.cgi?id=135351
+
+ Reviewed by Alexey Proskuryakov.
+
+ * wtf/HashTable.h:
+ (WTF::KeyTraits>::HashTable):
+
</ins><span class="cx"> 2014-07-28 Brian J. Burg <burg@cs.washington.edu>
</span><span class="cx">
</span><span class="cx"> Should not export symbols for base64Encode inline adapter methods
</span></span></pre></div>
<a id="trunkSourceWTFwtfHashTableh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/HashTable.h (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/HashTable.h 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WTF/wtf/HashTable.h 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -1225,7 +1225,7 @@
</span><span class="cx"> other.m_deletedCount = 0;
</span><span class="cx">
</span><span class="cx"> #if DUMP_HASHTABLE_STATS_PER_TABLE
</span><del>- m_stats = std::move(other.m_stats);
</del><ins>+ m_stats = WTF::move(other.m_stats);
</ins><span class="cx"> other.m_stats = nullptr;
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="lines">@@ -1249,7 +1249,7 @@
</span><span class="cx"> other.m_deletedCount = 0;
</span><span class="cx">
</span><span class="cx"> #if DUMP_HASHTABLE_STATS_PER_TABLE
</span><del>- m_stats = std::move(other.m_stats);
</del><ins>+ m_stats = WTF::move(other.m_stats);
</ins><span class="cx"> other.m_stats = nullptr;
</span><span class="cx"> #endif
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebCore/ChangeLog 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-07-29 Daniel Bates <dabates@apple.com>
+
+ Use WTF::move() instead of std::move() to help ensure move semantics
+ https://bugs.webkit.org/show_bug.cgi?id=135351
+
+ Reviewed by Alexey Proskuryakov.
+
+ * page/CaptionUserPreferences.cpp:
+ (WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):
+
</ins><span class="cx"> 2014-07-29 Mihnea Ovidenie <mihnea@adobe.com>
</span><span class="cx">
</span><span class="cx"> [CSSRegions] Assertion failure hit testing a region-based multicolumn in a region
</span></span></pre></div>
<a id="trunkSourceWebCorepageCaptionUserPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/CaptionUserPreferences.cpp (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/CaptionUserPreferences.cpp 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebCore/page/CaptionUserPreferences.cpp 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -253,7 +253,7 @@
</span><span class="cx"> for (auto& page : pages) {
</span><span class="cx"> if (auto* pageUserContentController = page->userContentController()) {
</span><span class="cx"> auto userStyleSheet = std::make_unique<UserStyleSheet>(captionsOverrideStyleSheet, captionsStyleSheetURL, Vector<String>(), Vector<String>(), InjectInAllFrames, UserStyleAuthorLevel);
</span><del>- pageUserContentController->addUserStyleSheet(mainThreadNormalWorld(), std::move(userStyleSheet), InjectInExistingDocuments);
</del><ins>+ pageUserContentController->addUserStyleSheet(mainThreadNormalWorld(), WTF::move(userStyleSheet), InjectInExistingDocuments);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-07-29 Daniel Bates <dabates@apple.com>
+
+ Use WTF::move() instead of std::move() to help ensure move semantics
+ https://bugs.webkit.org/show_bug.cgi?id=135351
+
+ Reviewed by Alexey Proskuryakov.
+
+ * UIProcess/API/Cocoa/_WKSessionState.mm:
+ (-[_WKSessionState _initWithSessionState:]):
+ * UIProcess/API/gtk/WebKitUserContent.cpp:
+ (toStringVector): Remove use of std::move(). It's unnecessary to call std::move() on an rvalue.
+ * WebProcess/WebPage/mac/ServicesOverlayController.mm:
+ (WebKit::ServicesOverlayController::mouseEvent):
+
</ins><span class="cx"> 2014-07-28 Pratik Solanki <psolanki@apple.com>
</span><span class="cx">
</span><span class="cx"> Get SharedBuffer.h out of ResourceBuffer.h (and a few other places)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoa_WKSessionStatemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKSessionState.mm (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKSessionState.mm 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKSessionState.mm 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> if (!(self = [super init]))
</span><span class="cx"> return nil;
</span><span class="cx">
</span><del>- _sessionState = std::move(sessionState);
</del><ins>+ _sessionState = WTF::move(sessionState);
</ins><span class="cx">
</span><span class="cx"> return self;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkWebKitUserContentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx">
</span><span class="cx"> Vector<String> result;
</span><span class="cx"> for (auto str = strv; *str; ++str)
</span><del>- result.append(std::move(String::fromUTF8(*str)));
</del><ins>+ result.append(String::fromUTF8(*str));
</ins><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacServicesOverlayControllermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm (171745 => 171746)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-29 15:11:28 UTC (rev 171745)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm 2014-07-29 15:47:39 UTC (rev 171746)
</span><span class="lines">@@ -460,7 +460,7 @@
</span><span class="cx">
</span><span class="cx"> // Check and see if the mouse went up and we have a current mouse down highlight button.
</span><span class="cx"> if (event.type() == WebEvent::MouseUp) {
</span><del>- RetainPtr<DDHighlightRef> mouseDownHighlight = std::move(m_currentMouseDownOnButtonHighlight);
</del><ins>+ RetainPtr<DDHighlightRef> mouseDownHighlight = WTF::move(m_currentMouseDownOnButtonHighlight);
</ins><span class="cx">
</span><span class="cx"> // If the mouse lifted while still over the highlight button that it went down on, then that is a click.
</span><span class="cx"> if (onButton && mouseDownHighlight) {
</span></span></pre>
</div>
</div>
</body>
</html>