<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171787] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171787">171787</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-29 21:17:28 -0700 (Tue, 29 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Only compute full ProfileNode times if needed - Legacy Profiler
https://bugs.webkit.org/show_bug.cgi?id=135406
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-07-29
Reviewed by Timothy Hatcher.
Full ProfileNode times are only used by the Legacy Profiler. The new profile
information in the Scripts Timelines currently never uses the pass. We should
avoid calculating it if we never use it.
* UserInterface/Models/ProfileNode.js:
(WebInspector.ProfileNode.prototype.get startTime):
(WebInspector.ProfileNode.prototype.get endTime):
(WebInspector.ProfileNode.prototype.get selfTime):
(WebInspector.ProfileNode.prototype.get totalTime):
(WebInspector.ProfileNode.prototype.establishRelationships):
(WebInspector.ProfileNode.prototype._computeTotalTimes):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsProfileNodejs">trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (171786 => 171787)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-07-30 04:00:39 UTC (rev 171786)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-07-30 04:17:28 UTC (rev 171787)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2014-07-29 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Only compute full ProfileNode times if needed - Legacy Profiler
+ https://bugs.webkit.org/show_bug.cgi?id=135406
+
+ Reviewed by Timothy Hatcher.
+
+ Full ProfileNode times are only used by the Legacy Profiler. The new profile
+ information in the Scripts Timelines currently never uses the pass. We should
+ avoid calculating it if we never use it.
+
+ * UserInterface/Models/ProfileNode.js:
+ (WebInspector.ProfileNode.prototype.get startTime):
+ (WebInspector.ProfileNode.prototype.get endTime):
+ (WebInspector.ProfileNode.prototype.get selfTime):
+ (WebInspector.ProfileNode.prototype.get totalTime):
+ (WebInspector.ProfileNode.prototype.establishRelationships):
+ (WebInspector.ProfileNode.prototype._computeTotalTimes):
+
+2014-07-29 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Reduce forced layouts in TimelineOverview
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=135405
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsProfileNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js (171786 => 171787)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js 2014-07-30 04:00:39 UTC (rev 171786)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js 2014-07-30 04:17:28 UTC (rev 171787)
</span><span class="lines">@@ -45,18 +45,13 @@
</span><span class="cx"> this._parentNode = null;
</span><span class="cx"> this._previousSibling = null;
</span><span class="cx"> this._nextSibling = null;
</span><ins>+ this._computedTotalTimes = false;
</ins><span class="cx">
</span><span class="cx"> for (var i = 0; i < this._childNodes.length; ++i)
</span><span class="cx"> this._childNodes[i].establishRelationships(this, this._childNodes[i - 1], this._childNodes[i + 1]);
</span><span class="cx">
</span><span class="cx"> for (var i = 0; i < this._calls.length; ++i)
</span><span class="cx"> this._calls[i].establishRelationships(this, this._calls[i - 1], this._calls[i + 1]);
</span><del>-
- var info = this.computeCallInfoForTimeRange(0, Infinity);
- this._startTime = info.startTime;
- this._endTime = info.endTime;
- this._selfTime = info.selfTime;
- this._totalTime = info.totalTime;
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> WebInspector.ProfileNode.Type = {
</span><span class="lines">@@ -99,21 +94,25 @@
</span><span class="cx">
</span><span class="cx"> get startTime()
</span><span class="cx"> {
</span><ins>+ this._computeTotalTimesIfNeeded();
</ins><span class="cx"> return this._startTime;
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> get endTime()
</span><span class="cx"> {
</span><ins>+ this._computeTotalTimesIfNeeded();
</ins><span class="cx"> return this._endTime;
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> get selfTime()
</span><span class="cx"> {
</span><ins>+ this._computeTotalTimesIfNeeded();
</ins><span class="cx"> return this._selfTime;
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> get totalTime()
</span><span class="cx"> {
</span><ins>+ this._computeTotalTimesIfNeeded();
</ins><span class="cx"> return this._totalTime;
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -216,5 +215,21 @@
</span><span class="cx"> this._parentNode = parentNode || null;
</span><span class="cx"> this._previousSibling = previousSibling || null;
</span><span class="cx"> this._nextSibling = nextSibling || null;
</span><ins>+ },
+
+ // Private
+
+ _computeTotalTimes: function()
+ {
+ if (this._computedTotalTimes)
+ return;
+
+ this._computedTotalTimes = true;
+
+ var info = this.computeCallInfoForTimeRange(0, Infinity);
+ this._startTime = info.startTime;
+ this._endTime = info.endTime;
+ this._selfTime = info.selfTime;
+ this._totalTime = info.totalTime;
</ins><span class="cx"> }
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>