<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[171673] trunk/Source/WebKit</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta">

<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171673">171673</a></dd>

<dt>Author</dt> <dd>psolanki@apple.com</dd>

<dt>Date</dt> <dd>2014-07-27 23:50:21 -0700 (Sun, 27 Jul 2014)</dd>

</dl>

<h3>Log Message</h3>

<pre>Remove unused preference keys

https://bugs.webkit.org/show_bug.cgi?id=135280

Reviewed by Darin Adler.

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:

* WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

(-[WebPreferences _setPageCacheSize:]): Deleted.

(-[WebPreferences _pageCacheSize]): Deleted.

(-[WebPreferences _setObjectCacheSize:]): Deleted.

(-[WebPreferences _objectCacheSize]): Deleted.

* WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

* WebPreferenceKeysPrivate.h:</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>

<li><a href="#trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>

<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>

<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>

<li><a href="#trunkSourceWebKitwinChangeLog">trunk/Source/WebKit/win/ChangeLog</a></li>

<li><a href="#trunkSourceWebKitwinWebPreferenceKeysPrivateh">trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkSourceWebKitmacChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (171672 => 171673)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebKit/mac/ChangeLog        2014-07-28 06:47:28 UTC (rev 171672)

+++ trunk/Source/WebKit/mac/ChangeLog        2014-07-28 06:50:21 UTC (rev 171673)

</span><span class="lines">@@ -1,3 +1,19 @@

</span><ins>+2014-07-27  Pratik Solanki  &lt;psolanki@apple.com&gt;

+

+        Remove unused preference keys

+        https://bugs.webkit.org/show_bug.cgi?id=135280

+

+        Reviewed by Darin Adler.

+

+        * WebView/WebPreferenceKeysPrivate.h:

+        * WebView/WebPreferences.mm:

+        (+[WebPreferences initialize]):

+        (-[WebPreferences _setPageCacheSize:]): Deleted.

+        (-[WebPreferences _pageCacheSize]): Deleted.

+        (-[WebPreferences _setObjectCacheSize:]): Deleted.

+        (-[WebPreferences _objectCacheSize]): Deleted.

+        * WebView/WebPreferencesPrivate.h:

+

</ins><span class="cx"> 2014-07-27  Filip Pizlo  &lt;fpizlo@apple.com&gt;

</span><span class="cx"> 

</span><span class="cx">         Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.

</span></span></pre></div>

<a id="trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (171672 => 171673)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h        2014-07-28 06:47:28 UTC (rev 171672)

+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h        2014-07-28 06:50:21 UTC (rev 171673)

</span><span class="lines">@@ -171,9 +171,6 @@

<span class="cx"> // default.

</span><span class="cx"> #define WebKitEnableDeferredUpdatesPreferenceKey @&quot;WebKitEnableDeferredUpdates&quot;

</span><span class="cx"> 

<del>-// For debugging only. Don't use these.

-#define WebKitPageCacheSizePreferenceKey @&quot;WebKitPageCacheSizePreferenceKey&quot;

-#define WebKitObjectCacheSizePreferenceKey @&quot;WebKitObjectCacheSizePreferenceKey&quot;

</del><span class="cx"> #define WebKitDebugFullPageZoomPreferenceKey @&quot;WebKitDebugFullPageZoomPreferenceKey&quot;

</span><span class="cx"> 

</span><span class="cx"> #define WebKitMinimumZoomFontSizePreferenceKey @&quot;WebKitMinimumZoomFontSizePreferenceKey&quot;

</span></span></pre></div>

<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (171672 => 171673)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm        2014-07-28 06:47:28 UTC (rev 171672)

+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm        2014-07-28 06:50:21 UTC (rev 171673)

</span><span class="lines">@@ -554,7 +554,6 @@

</span><span class="cx">         [NSNumber numberWithInt:-1],      WebKitLayoutIntervalPreferenceKey,

</span><span class="cx">         [NSNumber numberWithFloat:-1.0f], WebKitMaxParseDurationPreferenceKey,

</span><span class="cx">         [NSNumber numberWithBool:NO],     WebKitAllowMultiElementImplicitFormSubmissionPreferenceKey,

</span><del>-        [NSNumber numberWithInt:-1],      WebKitPageCacheSizePreferenceKey,

</del><span class="cx">         [NSNumber numberWithBool:NO],     WebKitAlwaysRequestGeolocationPermissionPreferenceKey,

</span><span class="cx">         [NSNumber numberWithInt:InterpolationLow], WebKitInterpolationQualityPreferenceKey,

</span><span class="cx">         [NSNumber numberWithBool:YES],    WebKitPasswordEchoEnabledPreferenceKey,

</span><span class="lines">@@ -1446,26 +1445,6 @@

</span><span class="cx">     return [self _floatValueForKey:WebKitMaxParseDurationPreferenceKey];

</span><span class="cx"> }

</span><span class="cx"> 

</span><del>-- (void)_setPageCacheSize:(int)size

-{

-    [self _setIntegerValue:size forKey:WebKitPageCacheSizePreferenceKey];

-}

-

-- (int)_pageCacheSize

-{

-    return [self _integerValueForKey:WebKitPageCacheSizePreferenceKey];

-}

-

-- (void)_setObjectCacheSize:(int)size

-{

-    [self _setIntegerValue:size forKey:WebKitObjectCacheSizePreferenceKey];

-}

-

-- (int)_objectCacheSize

-{

-    return [self _integerValueForKey:WebKitObjectCacheSizePreferenceKey];

-}

-

</del><span class="cx"> - (void)_setAlwaysUseBaselineOfPrimaryFont:(BOOL)flag

</span><span class="cx"> {

</span><span class="cx">     [self _setBoolValue:flag forKey:WebKitAlwaysUseBaselineOfPrimaryFontPreferenceKey];

</span></span></pre></div>

<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (171672 => 171673)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h        2014-07-28 06:47:28 UTC (rev 171672)

+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h        2014-07-28 06:50:21 UTC (rev 171673)

</span><span class="lines">@@ -308,10 +308,6 @@

</span><span class="cx"> - (int)_layoutInterval;

</span><span class="cx"> - (void)_setMaxParseDuration:(float)d;

</span><span class="cx"> - (float)_maxParseDuration;

</span><del>-- (void)_setPageCacheSize:(int)size;

-- (int)_pageCacheSize;

-- (void)_setObjectCacheSize:(int)size;

-- (int)_objectCacheSize;

</del><span class="cx"> - (void)_setInterpolationQuality:(int)quality;

</span><span class="cx"> - (int)_interpolationQuality;

</span><span class="cx"> - (BOOL)_allowPasswordEcho;

</span></span></pre></div>

<a id="trunkSourceWebKitwinChangeLog"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/ChangeLog (171672 => 171673)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebKit/win/ChangeLog        2014-07-28 06:47:28 UTC (rev 171672)

+++ trunk/Source/WebKit/win/ChangeLog        2014-07-28 06:50:21 UTC (rev 171673)

</span><span class="lines">@@ -1,3 +1,12 @@

</span><ins>+2014-07-27  Pratik Solanki  &lt;psolanki@apple.com&gt;

+

+        Remove unused preference keys

+        https://bugs.webkit.org/show_bug.cgi?id=135280

+

+        Reviewed by Darin Adler.

+

+        * WebPreferenceKeysPrivate.h:

+

</ins><span class="cx"> 2014-07-22  Brent Fulgham  &lt;bfulgham@apple.com&gt;

</span><span class="cx"> 

<span class="cx">         [Win] Build fix after r171370.

</span></span></pre></div>

<a id="trunkSourceWebKitwinWebPreferenceKeysPrivateh"></a>

<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (171672 => 171673)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h        2014-07-28 06:47:28 UTC (rev 171672)

+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h        2014-07-28 06:50:21 UTC (rev 171673)

</span><span class="lines">@@ -95,10 +95,6 @@

<span class="cx"> // default.

</span><span class="cx"> #define WebKitEnableDeferredUpdatesPreferenceKey &quot;WebKitEnableDeferredUpdates&quot;

</span><span class="cx"> 

<del>-// For debugging only.  Don't use these.

-#define WebKitPageCacheSizePreferenceKey &quot;WebKitPageCacheSizePreferenceKey&quot;

-#define WebKitObjectCacheSizePreferenceKey &quot;WebKitObjectCacheSizePreferenceKey&quot;

-

</del><span class="cx"> // From WebHistory.h

</span><span class="cx"> #define WebKitHistoryItemLimitKey &quot;WebKitHistoryItemLimit&quot; // default: &quot;1000&quot;

</span><span class="cx"> #define WebKitHistoryAgeInDaysLimitKey &quot;WebKitHistoryAgeInDaysLimit&quot; // default: &quot;7&quot;

</span></span></pre>

</div>

</div>

</body>

</html>