<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171645] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171645">171645</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-26 09:42:55 -0700 (Sat, 26 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Timelines performance is very slow, has many forced layouts
https://bugs.webkit.org/show_bug.cgi?id=135313
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-07-26
Reviewed by Timothy Hatcher.
* UserInterface/Views/NavigationItem.js:
(WebInspector.NavigationItem):
(WebInspector.NavigationItem.prototype.get hidden):
(WebInspector.NavigationItem.prototype.set hidden):
Don't have the parent navigation bar update layout if the hidden state did not change.
This greatly reduces the number of forced layouts as timeline nodes are added.
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
(WebInspector.NavigationSidebarPanel.prototype.hideEmptyContentPlaceholder):
Don't do any work if this is not changing the view.
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibilitySoon):
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
When first selecting a specific timeline (Layout / Scripts) we would have a very long hang
updating the content. Most of this was time spent updating the overflow shadow visibility
because every single tree element addition was causing a layout invalidation and forced layout.
Coalesce all of the tree element adds into a single update at the end.
* UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.updateLayout):
Calculating the visible duration checks offsetLeft. Calculate this once, outside
of a loop down below, to prevent or reduce possible forced layouts.
* UserInterface/Views/TreeOutline.js:
(TreeElement.prototype.revealed):
Prevent doing any work for timeline tree elements outside of the selected time range.
Previously they were considered revealed if a parent was expanded, even though that
parent was hidden. This greatly reduces the amount of work during a recording, since
previously we were potentially doing a forced layout for hidden nodes.
* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.looselyCompareRepresentedObjects):
Ignore ProfileNode, which may happen here in the Script timeline.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNavigationItemjs">trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNavigationSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineOverviewjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs">trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (171644 => 171645)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-07-26 05:59:42 UTC (rev 171644)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-07-26 16:42:55 UTC (rev 171645)
</span><span class="lines">@@ -1,3 +1,46 @@
</span><ins>+2014-07-26 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Timelines performance is very slow, has many forced layouts
+ https://bugs.webkit.org/show_bug.cgi?id=135313
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/NavigationItem.js:
+ (WebInspector.NavigationItem):
+ (WebInspector.NavigationItem.prototype.get hidden):
+ (WebInspector.NavigationItem.prototype.set hidden):
+ Don't have the parent navigation bar update layout if the hidden state did not change.
+ This greatly reduces the number of forced layouts as timeline nodes are added.
+
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
+ (WebInspector.NavigationSidebarPanel.prototype.hideEmptyContentPlaceholder):
+ Don't do any work if this is not changing the view.
+
+ (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibilitySoon):
+ (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
+ (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
+ When first selecting a specific timeline (Layout / Scripts) we would have a very long hang
+ updating the content. Most of this was time spent updating the overflow shadow visibility
+ because every single tree element addition was causing a layout invalidation and forced layout.
+ Coalesce all of the tree element adds into a single update at the end.
+
+ * UserInterface/Views/TimelineOverview.js:
+ (WebInspector.TimelineOverview.prototype.updateLayout):
+ Calculating the visible duration checks offsetLeft. Calculate this once, outside
+ of a loop down below, to prevent or reduce possible forced layouts.
+
+ * UserInterface/Views/TreeOutline.js:
+ (TreeElement.prototype.revealed):
+ Prevent doing any work for timeline tree elements outside of the selected time range.
+ Previously they were considered revealed if a parent was expanded, even though that
+ parent was hidden. This greatly reduces the amount of work during a recording, since
+ previously we were potentially doing a forced layout for hidden nodes.
+
+ * UserInterface/Views/TimelineSidebarPanel.js:
+ (WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.looselyCompareRepresentedObjects):
+ Ignore ProfileNode, which may happen here in the Script timeline.
+
</ins><span class="cx"> 2014-07-23 Brian J. Burg <burg@cs.washington.edu>
</span><span class="cx">
</span><span class="cx"> Web Inspector: InspectorBackend's promise-based agent API does not support multiple return values
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNavigationItemjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js (171644 => 171645)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js 2014-07-26 05:59:42 UTC (rev 171644)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js 2014-07-26 16:42:55 UTC (rev 171645)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx"> this._identifier = identifier || null;
</span><span class="cx">
</span><span class="cx"> this._element = document.createElement("div");
</span><ins>+ this._hidden = false;
</ins><span class="cx">
</span><span class="cx"> if (role)
</span><span class="cx"> this._element.setAttribute("role", role);
</span><span class="lines">@@ -73,11 +74,16 @@
</span><span class="cx">
</span><span class="cx"> get hidden()
</span><span class="cx"> {
</span><del>- return this._element.classList.contains(WebInspector.NavigationItem.HiddenStyleClassName);
</del><ins>+ return this._hidden;
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> set hidden(flag)
</span><span class="cx"> {
</span><ins>+ if (this._hidden === flag)
+ return;
+
+ this._hidden = flag;
+
</ins><span class="cx"> if (flag)
</span><span class="cx"> this._element.classList.add(WebInspector.NavigationItem.HiddenStyleClassName);
</span><span class="cx"> else
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNavigationSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (171644 => 171645)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2014-07-26 05:59:42 UTC (rev 171644)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2014-07-26 16:42:55 UTC (rev 171645)
</span><span class="lines">@@ -261,6 +261,9 @@
</span><span class="cx"> {
</span><span class="cx"> console.assert(message);
</span><span class="cx">
</span><ins>+ if (this._emptyContentPlaceholderMessageElement.parentNode && this._emptyContentPlaceholderMessageElement.textContent === message)
+ return;
+
</ins><span class="cx"> this._emptyContentPlaceholderMessageElement.textContent = message;
</span><span class="cx"> this.element.appendChild(this._emptyContentPlaceholderElement);
</span><span class="cx">
</span><span class="lines">@@ -271,9 +274,11 @@
</span><span class="cx">
</span><span class="cx"> hideEmptyContentPlaceholder: function()
</span><span class="cx"> {
</span><del>- if (this._emptyContentPlaceholderElement.parentNode)
- this._emptyContentPlaceholderElement.parentNode.removeChild(this._emptyContentPlaceholderElement);
</del><ins>+ if (!this._emptyContentPlaceholderElement.parentNode)
+ return;
</ins><span class="cx">
</span><ins>+ this._emptyContentPlaceholderElement.parentNode.removeChild(this._emptyContentPlaceholderElement);
+
</ins><span class="cx"> this._hideToolbarItemWhenEmpty = false;
</span><span class="cx"> this._updateToolbarItemVisibility();
</span><span class="cx"> this._updateContentOverflowShadowVisibility();
</span><span class="lines">@@ -423,9 +428,19 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> // Private
</span><ins>+
+ _updateContentOverflowShadowVisibilitySoon: function()
+ {
+ if (this._updateContentOverflowShadowVisibilityIdentifier)
+ return;
</ins><span class="cx">
</span><ins>+ this._updateContentOverflowShadowVisibilityIdentifier = setTimeout(this._updateContentOverflowShadowVisibility.bind(this), 0);
+ },
+
</ins><span class="cx"> _updateContentOverflowShadowVisibility: function()
</span><span class="cx"> {
</span><ins>+ delete this._updateContentOverflowShadowVisibilityIdentifier;
+
</ins><span class="cx"> this.updateCustomContentOverflow();
</span><span class="cx">
</span><span class="cx"> var scrollHeight = this._contentElement.scrollHeight;
</span><span class="lines">@@ -520,7 +535,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this._checkForEmptyFilterResults();
</span><del>- this._updateContentOverflowShadowVisibility();
</del><ins>+ this._updateContentOverflowShadowVisibilitySoon();
</ins><span class="cx"> this._checkElementsForPendingViewStateCookie(treeElement);
</span><span class="cx"> },
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineOverviewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (171644 => 171645)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2014-07-26 05:59:42 UTC (rev 171644)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2014-07-26 16:42:55 UTC (rev 171645)
</span><span class="lines">@@ -234,8 +234,10 @@
</span><span class="cx"> delete this._revealCurrentTime;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ const visibleDuration = this.visibleDuration;
+
</ins><span class="cx"> // Clamp the scroll start time to match what the scroll bar would allow.
</span><del>- var scrollStartTime = Math.min(this._scrollStartTime, this._endTime - this.visibleDuration);
</del><ins>+ var scrollStartTime = Math.min(this._scrollStartTime, this._endTime - visibleDuration);
</ins><span class="cx"> scrollStartTime = Math.max(this._startTime, scrollStartTime);
</span><span class="cx">
</span><span class="cx"> this._timelineRuler.zeroTime = this._startTime;
</span><span class="lines">@@ -253,7 +255,7 @@
</span><span class="cx"> timelineOverviewGraph.zeroTime = this._startTime;
</span><span class="cx"> timelineOverviewGraph.startTime = scrollStartTime;
</span><span class="cx"> timelineOverviewGraph.currentTime = this._currentTime;
</span><del>- timelineOverviewGraph.endTime = scrollStartTime + this.visibleDuration;
</del><ins>+ timelineOverviewGraph.endTime = scrollStartTime + visibleDuration;
</ins><span class="cx"> timelineOverviewGraph.updateLayout();
</span><span class="cx"> }
</span><span class="cx"> },
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js (171644 => 171645)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js 2014-07-26 05:59:42 UTC (rev 171644)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js 2014-07-26 16:42:55 UTC (rev 171645)
</span><span class="lines">@@ -197,6 +197,9 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ if (candidateRepresentedObject instanceof WebInspector.ProfileNode)
+ return false;
+
</ins><span class="cx"> console.error("Unknown TreeElement");
</span><span class="cx"> return false;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTreeOutlinejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (171644 => 171645)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2014-07-26 05:59:42 UTC (rev 171644)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2014-07-26 16:42:55 UTC (rev 171645)
</span><span class="lines">@@ -909,10 +909,15 @@
</span><span class="cx">
</span><span class="cx"> TreeElement.prototype.revealed = function()
</span><span class="cx"> {
</span><ins>+ if (this.hidden)
+ return false;
+
</ins><span class="cx"> var currentAncestor = this.parent;
</span><span class="cx"> while (currentAncestor && !currentAncestor.root) {
</span><span class="cx"> if (!currentAncestor.expanded)
</span><span class="cx"> return false;
</span><ins>+ if (!currentAncestor.hidden)
+ return false;
</ins><span class="cx"> currentAncestor = currentAncestor.parent;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>