<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171580] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171580">171580</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-24 21:51:13 -0700 (Thu, 24 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/164401">r164401</a>): Placing a caret doesn't bring up autocorrection panel
https://bugs.webkit.org/show_bug.cgi?id=135278
Reviewed by Tim Horton.
The bug was caused by editorUIUpdateTimerFired calling respondToChangedSelection only if the selection was
triggered by dictation instead of only if it was NOT triggered by dictation.
Prior to <a href="http://trac.webkit.org/projects/webkit/changeset/164401">r164401</a>, AlternativeTextController::respondToMarkerAtEndOfWord exited early when SetSelectionOptions
had DictationTriggered set. <a href="http://trac.webkit.org/projects/webkit/changeset/164401">r164401</a> intended to move this check to editorUIUpdateTimerFired to avoid passing
options around but the boolean condition was erroneously flipped.
Fixed the bug by negating the condition in editorUIUpdateTimerFired.
No new tests for now since autocorrection panel cannot be tested automatically. (We should really automate this!)
* editing/Editor.cpp:
(WebCore::Editor::editorUIUpdateTimerFired):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreeditingEditorcpp">trunk/Source/WebCore/editing/Editor.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171579 => 171580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-25 04:27:57 UTC (rev 171579)
+++ trunk/Source/WebCore/ChangeLog 2014-07-25 04:51:13 UTC (rev 171580)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-07-24 Ryosuke Niwa <rniwa@webkit.org>
+
+ REGRESSION(r164401): Placing a caret doesn't bring up autocorrection panel
+ https://bugs.webkit.org/show_bug.cgi?id=135278
+
+ Reviewed by Tim Horton.
+
+ The bug was caused by editorUIUpdateTimerFired calling respondToChangedSelection only if the selection was
+ triggered by dictation instead of only if it was NOT triggered by dictation.
+
+ Prior to r164401, AlternativeTextController::respondToMarkerAtEndOfWord exited early when SetSelectionOptions
+ had DictationTriggered set. r164401 intended to move this check to editorUIUpdateTimerFired to avoid passing
+ options around but the boolean condition was erroneously flipped.
+
+ Fixed the bug by negating the condition in editorUIUpdateTimerFired.
+
+ No new tests for now since autocorrection panel cannot be tested automatically. (We should really automate this!)
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::editorUIUpdateTimerFired):
+
</ins><span class="cx"> 2014-07-24 Pratik Solanki <psolanki@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r171526): [GTK] Massive crashes.
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/Editor.cpp (171579 => 171580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/Editor.cpp 2014-07-25 04:27:57 UTC (rev 171579)
+++ trunk/Source/WebCore/editing/Editor.cpp 2014-07-25 04:51:13 UTC (rev 171580)
</span><span class="lines">@@ -3531,7 +3531,7 @@
</span><span class="cx"> #if ENABLE(DELETION_UI)
</span><span class="cx"> m_deleteButtonController->respondToChangedSelection(oldSelection);
</span><span class="cx"> #endif
</span><del>- if (m_editorUIUpdateTimerWasTriggeredByDictation)
</del><ins>+ if (!m_editorUIUpdateTimerWasTriggeredByDictation)
</ins><span class="cx"> m_alternativeTextController->respondToChangedSelection(oldSelection);
</span><span class="cx">
</span><span class="cx"> m_oldSelectionForEditorUIUpdate = m_frame.selection().selection();
</span></span></pre>
</div>
</div>
</body>
</html>