<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171361] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171361">171361</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-22 13:57:54 -0700 (Tue, 22 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Perf dashboard spends 2s processing JSON data during the page loads
https://bugs.webkit.org/show_bug.cgi?id=135152
Reviewed by Andreas Kling.
In the Apple internal dashboard, we were spending as much as 2 seconds
converting raw JSON data into proper JS objects while loading the dashboard.
This caused the apparent unresponsiveness of the dashboard despite of the fact
charts themselves updated almost instantaneously.
* public/index.html:
* public/js/helper-classes.js:
(TestBuild): Compute the return values of formattedTime and formattedBuildTime
lazily as creating new Date objects and running string replace is expensive.
(TestBuild.formattedTime):
(TestBuild.formattedBuildTime):
(PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
(PerfTestRuns.addResult): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicindexhtml">trunk/Websites/perf.webkit.org/public/index.html</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicjshelperclassesjs">trunk/Websites/perf.webkit.org/public/js/helper-classes.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (171360 => 171361)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2014-07-22 20:51:13 UTC (rev 171360)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-07-22 20:57:54 UTC (rev 171361)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2014-07-22 Ryosuke Niwa <rniwa@webkit.org>
+
+ Perf dashboard spends 2s processing JSON data during the page loads
+ https://bugs.webkit.org/show_bug.cgi?id=135152
+
+ Reviewed by Andreas Kling.
+
+ In the Apple internal dashboard, we were spending as much as 2 seconds
+ converting raw JSON data into proper JS objects while loading the dashboard.
+
+ This caused the apparent unresponsiveness of the dashboard despite of the fact
+ charts themselves updated almost instantaneously.
+
+ * public/index.html:
+ * public/js/helper-classes.js:
+ (TestBuild): Compute the return values of formattedTime and formattedBuildTime
+ lazily as creating new Date objects and running string replace is expensive.
+ (TestBuild.formattedTime):
+ (TestBuild.formattedBuildTime):
+ (PerfTestRuns.setResults): Added. Pushing each result was the biggest bottle neck.
+ (PerfTestRuns.addResult): Deleted.
+
</ins><span class="cx"> 2014-07-18 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Perf dashboard shouldn't show the full git hash
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicindexhtml"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/index.html (171360 => 171361)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/index.html 2014-07-22 20:51:13 UTC (rev 171360)
+++ trunk/Websites/perf.webkit.org/public/index.html 2014-07-22 20:57:54 UTC (rev 171361)
</span><span class="lines">@@ -835,8 +835,7 @@
</span><span class="cx"> // We should create PerfTestResult on demand.
</span><span class="cx"> return new PerfTestResult(runs, rawRun, new TestBuild(repositories, builders, platform, rawRun));
</span><span class="cx"> });
</span><del>- sortedResults = results.sort(function (a, b) { return a.build().time() - b.build().time(); });
- sortedResults.forEach(function (result) { runs.addResult(result); });
</del><ins>+ runs.setResults(results.sort(function (a, b) { return a.build().time() - b.build().time(); }));
</ins><span class="cx"> return runs;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicjshelperclassesjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/js/helper-classes.js (171360 => 171361)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2014-07-22 20:51:13 UTC (rev 171360)
+++ trunk/Websites/perf.webkit.org/public/js/helper-classes.js 2014-07-22 20:57:54 UTC (rev 171361)
</span><span class="lines">@@ -58,14 +58,22 @@
</span><span class="cx"> if (!maxTime)
</span><span class="cx"> maxTime = rawRun.buildTime;
</span><span class="cx"> maxTime = TestBuild.UTCtoPST(maxTime);
</span><del>- var maxTimeString = new Date(maxTime).toISOString().replace('T', ' ').replace(/\.\d+Z$/, '');
</del><ins>+ var maxTimeString;
</ins><span class="cx"> var buildTime = TestBuild.UTCtoPST(rawRun.buildTime);
</span><del>- var buildTimeString = new Date(buildTime).toISOString().replace('T', ' ').replace(/\.\d+Z$/, '');
</del><ins>+ var buildTimeString;
</ins><span class="cx">
</span><span class="cx"> this.time = function () { return maxTime; }
</span><del>- this.formattedTime = function () { return maxTimeString; }
</del><ins>+ this.formattedTime = function () {
+ if (!maxTimeString)
+ maxTimeString = new Date(maxTime).toISOString().replace('T', ' ').replace(/\.\d+Z$/, '');
+ return maxTimeString;
+ }
</ins><span class="cx"> this.buildTime = function () { return buildTime; }
</span><del>- this.formattedBuildTime = function () { return buildTimeString; }
</del><ins>+ this.formattedBuildTime = function () {
+ if (!buildTimeString)
+ new Date(buildTime).toISOString().replace('T', ' ').replace(/\.\d+Z$/, '');
+ return buildTimeString;
+ }
</ins><span class="cx"> this.builder = function () { return builders[rawRun.builder].name; }
</span><span class="cx"> this.buildNumber = function () { return rawRun.buildNumber; }
</span><span class="cx"> this.buildUrl = function () {
</span><span class="lines">@@ -178,10 +186,8 @@
</span><span class="cx">
</span><span class="cx"> this.metric = function () { return metric; }
</span><span class="cx"> this.platform = function () { return platform; }
</span><del>- this.addResult = function (newResult) {
- if (results.indexOf(newResult) >= 0)
- return;
- results.push(newResult);
</del><ins>+ this.setResults = function (newResults) {
+ results = newResults;
</ins><span class="cx"> cachedUnit = null;
</span><span class="cx"> cachedScalingFactor = null;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>