<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171347] trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171347">171347</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2014-07-22 10:50:31 -0700 (Tue, 22 Jul 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Source/WebCore: Clicking on links while accessibility is enabled sometimes crashes
https://bugs.webkit.org/show_bug.cgi?id=135074

Reviewed by Chris Fleizach.

When an accessibility request comes in from the system, we call updateBackingStore() on the
relevant AccessibilityObject, which triggers a relayout of the entire document. This relayout
might delete that accessibility node and its parent, which would cause the node to be deleted.
After the stack unwinds, we then call a member function on the node without checking for this
condition.

Test: accessibility/parent-delete.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateBackingStore): Retain the node for the duration of the
function.

LayoutTests: Clicking on links while accessibility is enabled does not render as expected
https://bugs.webkit.org/show_bug.cgi?id=135074

Reviewed by Chris Fleizach.

Delete a node and its parent, then call allAttributes() on the accessibility representation of
the deleted child and make sure there is no crash.

* accessibility/parent-delete-expected.txt: Added
* accessibility/parent-delete.html: Added</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsaccessibilityparentdeleteexpectedtxt">trunk/LayoutTests/accessibility/parent-delete-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilityparentdeletehtml">trunk/LayoutTests/accessibility/parent-delete.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (171346 => 171347)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-07-22 17:32:38 UTC (rev 171346)
+++ trunk/LayoutTests/ChangeLog        2014-07-22 17:50:31 UTC (rev 171347)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-07-21  Myles C. Maxfield  &lt;mmaxfield@apple.com&gt;
+
+        Clicking on links while accessibility is enabled does not render as expected
+        https://bugs.webkit.org/show_bug.cgi?id=135074
+
+        Reviewed by Chris Fleizach.
+
+        Delete a node and its parent, then call allAttributes() on the accessibility representation of
+        the deleted child and make sure there is no crash.
+
+        * accessibility/parent-delete-expected.txt: Added
+        * accessibility/parent-delete.html: Added
+
</ins><span class="cx"> 2014-07-22  Alexey Proskuryakov  &lt;ap@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         media/track/track-in-band-subtitles-too-large.html and
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityparentdeleteexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/parent-delete-expected.txt (0 => 171347)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/parent-delete-expected.txt                                (rev 0)
+++ trunk/LayoutTests/accessibility/parent-delete-expected.txt        2014-07-22 17:50:31 UTC (rev 171347)
</span><span class="lines">@@ -0,0 +1,31 @@
</span><ins>+This test passes if there is no crash.
+AXRole: AXWebArea
+AXRoleDescription: HTML content
+AXChildren: &lt;array of size 1&gt;
+AXHelp: 
+AXParent: &lt;AXWebArea&gt;
+AXSize: NSSize: {800, 600}
+AXTitle: 
+AXDescription: 
+AXValue: 
+AXFocused: 0
+AXEnabled: 1
+AXWindow: &lt;AXWebArea&gt;
+AXSelectedTextMarkerRange: (null)
+AXStartTextMarker: &lt;AXWebArea&gt;
+AXEndTextMarker: &lt;AXWebArea&gt;
+AXVisited: 0
+AXLinkedUIElements: (null)
+AXSelected: 0
+AXBlockQuoteLevel: 0
+AXTopLevelUIElement: &lt;AXWebArea&gt;
+AXLanguage: 
+AXDOMIdentifier: 
+AXDOMClassList: &lt;array of size 0&gt;
+AXLinkUIElements: &lt;array of size 0&gt;
+AXLoaded: 1
+AXLayoutCount: 2
+AXLoadingProgress: 1
+AXURL: LayoutTests/accessibility/parent-delete.html
+AXElementBusy: 0
+
</ins></span></pre></div>
<a id="trunkLayoutTestsaccessibilityparentdeletehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/accessibility/parent-delete.html (0 => 171347)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/parent-delete.html                                (rev 0)
+++ trunk/LayoutTests/accessibility/parent-delete.html        2014-07-22 17:50:31 UTC (rev 171347)
</span><span class="lines">@@ -0,0 +1,39 @@
</span><ins>+&lt;!DOCTYPE html&gt;
+&lt;html&gt;
+&lt;head&gt;
+&lt;script&gt;
+if (window.testRunner)
+    testRunner.dumpAsText();
+
+function runTest() {
+    var accessibilityElement;
+    {
+        var outer = document.getElementById(&quot;outer&quot;);
+        var inner = document.getElementById(&quot;inner&quot;);
+        var editable = document.getElementById(&quot;editable&quot;);
+        var result = document.getElementById(&quot;result&quot;);
+        editable.focus();
+        if (window.accessibilityController) {
+            var accessibilityElement = accessibilityController.focusedElement;
+        }
+        inner.removeChild(editable);
+        outer.removeChild(inner);
+    }
+    if (window.accessibilityController) {
+        result.innerText = accessibilityElement.allAttributes();
+    }
+}
+&lt;/script&gt;
+&lt;/head&gt;
+&lt;body onload=&quot;runTest()&quot;&gt;
+This test passes if there is no crash.
+&lt;div id=&quot;outer&quot; style=&quot;display: none;&quot;&gt;
+    &lt;div id=&quot;inner&quot; style=&quot;display: none;&quot;&gt;
+        &lt;div id=&quot;editable&quot; contenteditable=&quot;true&quot; style=&quot;display: none;&quot;&gt;
+            This is some throwaway text
+        &lt;/div&gt;
+    &lt;/div&gt;
+&lt;/div&gt;
+&lt;div id=&quot;result&quot;&gt;&lt;/div&gt;
+&lt;/body&gt;
+&lt;/html&gt;
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171346 => 171347)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-07-22 17:32:38 UTC (rev 171346)
+++ trunk/Source/WebCore/ChangeLog        2014-07-22 17:50:31 UTC (rev 171347)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-07-21  Myles C. Maxfield  &lt;mmaxfield@apple.com&gt;
+
+        Clicking on links while accessibility is enabled sometimes crashes
+        https://bugs.webkit.org/show_bug.cgi?id=135074
+
+        Reviewed by Chris Fleizach.
+
+        When an accessibility request comes in from the system, we call updateBackingStore() on the
+        relevant AccessibilityObject, which triggers a relayout of the entire document. This relayout
+        might delete that accessibility node and its parent, which would cause the node to be deleted.
+        After the stack unwinds, we then call a member function on the node without checking for this
+        condition.
+
+        Test: accessibility/parent-delete.html
+
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::AccessibilityObject::updateBackingStore): Retain the node for the duration of the
+        function.
+
</ins><span class="cx"> 2014-07-22  Jeremy Jones  &lt;jeremyj@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Don't create new UIWindow for video fullscreen.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (171346 => 171347)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp        2014-07-22 17:32:38 UTC (rev 171346)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp        2014-07-22 17:50:31 UTC (rev 171347)
</span><span class="lines">@@ -1429,6 +1429,8 @@
</span><span class="cx"> void AccessibilityObject::updateBackingStore()
</span><span class="cx"> {
</span><span class="cx">     // Updating the layout may delete this object.
</span><ins>+    RefPtr&lt;AccessibilityObject&gt; protector(this);
+
</ins><span class="cx">     if (Document* document = this-&gt;document()) {
</span><span class="cx">         if (!document-&gt;view()-&gt;isInLayout())
</span><span class="cx">             document-&gt;updateLayoutIgnorePendingStylesheets();
</span></span></pre>
</div>
</div>

</body>
</html>