<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171322] trunk/Source/WebKit2</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171322">171322</a></dd>
<dt>Author</dt> <dd>oliver@apple.com</dd>
<dt>Date</dt> <dd>2014-07-21 17:10:11 -0700 (Mon, 21 Jul 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Correct sandbox profiles to fix some excess privileges
https://bugs.webkit.org/show_bug.cgi?id=135134
&lt;rdar://problem/17741886&gt;
&lt;rdar://problem/17739080&gt;

Reviewed by Alexey Proskuryakov.

This cleans up our sandbox profiles to fix a few issues - the profiles
no longer allow us to issue file extension we have the ability to consume,
and tightens some of the other file access rules.

This means we have to addd some rules to allow us to access things
that we previously had access to due to lax file system restrictions.

Some of the features were fixable simply by using entitlements on the
process rather than custom rules.

* Configurations/WebContent-iOS.entitlements:
* Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2ConfigurationsWebContentiOSentitlements">trunk/Source/WebKit2/Configurations/WebContent-iOS.entitlements</a></li>
<li><a href="#trunkSourceWebKit2ResourcesSandboxProfilesioscomappleWebKitDatabasessb">trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb</a></li>
<li><a href="#trunkSourceWebKit2ResourcesSandboxProfilesioscomappleWebKitNetworkingsb">trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb</a></li>
<li><a href="#trunkSourceWebKit2ResourcesSandboxProfilesioscomappleWebKitWebContentsb">trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (171321 => 171322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog        2014-07-22 00:09:19 UTC (rev 171321)
+++ trunk/Source/WebKit2/ChangeLog        2014-07-22 00:10:11 UTC (rev 171322)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2014-07-21  Oliver Hunt  &lt;oliver@apple.com&gt;
+
+        Correct sandbox profiles to fix some excess privileges
+        https://bugs.webkit.org/show_bug.cgi?id=135134
+        &lt;rdar://problem/17741886&gt;
+        &lt;rdar://problem/17739080&gt;
+
+        Reviewed by Alexey Proskuryakov.
+
+        This cleans up our sandbox profiles to fix a few issues - the profiles
+        no longer allow us to issue file extension we have the ability to consume,
+        and tightens some of the other file access rules.
+
+        This means we have to addd some rules to allow us to access things
+        that we previously had access to due to lax file system restrictions.
+
+        Some of the features were fixable simply by using entitlements on the
+        process rather than custom rules.
+
+        * Configurations/WebContent-iOS.entitlements:
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
</ins><span class="cx"> 2014-07-21  Simon Fraser  &lt;simon.fraser@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         [iOS WK2] Turn off position:fixed behavior when the keyboard is up
</span></span></pre></div>
<a id="trunkSourceWebKit2ConfigurationsWebContentiOSentitlements"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Configurations/WebContent-iOS.entitlements (171321 => 171322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Configurations/WebContent-iOS.entitlements        2014-07-22 00:09:19 UTC (rev 171321)
+++ trunk/Source/WebKit2/Configurations/WebContent-iOS.entitlements        2014-07-22 00:10:11 UTC (rev 171322)
</span><span class="lines">@@ -10,6 +10,10 @@
</span><span class="cx">         &lt;true/&gt;
</span><span class="cx">         &lt;key&gt;com.apple.private.webinspector.proxy-application&lt;/key&gt;
</span><span class="cx">         &lt;true/&gt;
</span><ins>+        &lt;key&gt;com.apple.locationd.authorizeapplications&lt;/key&gt;
+        &lt;true/&gt;
+        &lt;key&gt;com.apple.locationd.effective_bundle&lt;/key&gt;
+        &lt;true/&gt;
</ins><span class="cx">         &lt;key&gt;seatbelt-profiles&lt;/key&gt;
</span><span class="cx">         &lt;array&gt;
</span><span class="cx">                 &lt;string&gt;com.apple.WebKit.WebContent&lt;/string&gt;
</span></span></pre></div>
<a id="trunkSourceWebKit2ResourcesSandboxProfilesioscomappleWebKitDatabasessb"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb (171321 => 171322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb        2014-07-22 00:09:19 UTC (rev 171321)
+++ trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb        2014-07-22 00:10:11 UTC (rev 171322)
</span><span class="lines">@@ -28,20 +28,4 @@
</span><span class="cx"> (import &quot;common.sb&quot;)
</span><span class="cx"> (import &quot;removed-dev-nodes.sb&quot;)
</span><span class="cx"> 
</span><del>-;; Sandbox extensions
-(define (apply-read-and-issue-extension op path-filter)
-    (op file-read* path-filter)
-    (op file-issue-extension (require-all (extension-class &quot;com.apple.app-sandbox.read&quot;) path-filter)))
-(define (apply-write-and-issue-extension op path-filter)
-    (op file-write* path-filter)
-    (op file-issue-extension (require-all (extension-class &quot;com.apple.app-sandbox.read-write&quot;) path-filter)))
-(define (read-only-and-issue-extensions path-filter)
-    (apply-read-and-issue-extension allow path-filter))
-(define (read-write-and-issue-extensions path-filter)
-    (apply-read-and-issue-extension allow path-filter)
-    (apply-write-and-issue-extension allow path-filter))
-(read-only-and-issue-extensions (extension &quot;com.apple.app-sandbox.read&quot;))
-(read-write-and-issue-extensions (extension &quot;com.apple.app-sandbox.read-write&quot;))
-
-(if (defined? 'vnode-type)
-    (deny file-write-create (vnode-type SYMLINK)))
</del><ins>+(allow file-read* file-write* (extension &quot;com.apple.app-sandbox.read-write&quot;))
</ins></span></pre></div>
<a id="trunkSourceWebKit2ResourcesSandboxProfilesioscomappleWebKitNetworkingsb"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (171321 => 171322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb        2014-07-22 00:09:19 UTC (rev 171321)
+++ trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb        2014-07-22 00:10:11 UTC (rev 171322)
</span><span class="lines">@@ -36,8 +36,10 @@
</span><span class="cx"> (allow file-read* (extension &quot;com.apple.webkit.read&quot;))
</span><span class="cx"> 
</span><span class="cx"> ;; Access to client's cache folder &amp; re-vending to CFNetwork.
</span><del>-(allow file-read* file-write* (extension &quot;com.apple.nsurlstorage.extension-cache&quot;))
-(allow file-issue-extension (extension-class &quot;com.apple.nsurlstorage.extension-cache&quot;))
</del><ins>+;; FIXME: Remove the webkti specific extension classes &lt;rdar://problem/17755931&gt;
+(allow file-issue-extension (require-all
+    (require-any (extension &quot;com.apple.webkit.read-write&quot;) (extension &quot;com.apple.app-sandbox.read-write&quot;))
+    (extension-class &quot;com.apple.nsurlstorage.extension-cache&quot;)))
</ins><span class="cx"> 
</span><span class="cx"> ;; App sandbox extensions
</span><span class="cx"> (allow file-read* file-write* (extension &quot;com.apple.app-sandbox.read-write&quot;))
</span></span></pre></div>
<a id="trunkSourceWebKit2ResourcesSandboxProfilesioscomappleWebKitWebContentsb"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (171321 => 171322)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb        2014-07-22 00:09:19 UTC (rev 171321)
+++ trunk/Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb        2014-07-22 00:10:11 UTC (rev 171322)
</span><span class="lines">@@ -36,12 +36,15 @@
</span><span class="cx"> ;; This is too generous -- &lt;rdar://problem/17496756&gt;
</span><span class="cx"> (apple-cookie-access 'with-read-write)
</span><span class="cx"> 
</span><ins>+;; Access to media controls
</ins><span class="cx"> (play-media)
</span><ins>+(media-remote)
</ins><span class="cx"> 
</span><span class="cx"> ;; Read-only preferences and data
</span><span class="cx"> (mobile-preferences-read
</span><span class="cx">     &quot;com.apple.LaunchServices&quot;
</span><del>-    &quot;com.apple.WebFoundation&quot;)
</del><ins>+    &quot;com.apple.WebFoundation&quot;
+    &quot;com.apple.mobileipod&quot;)
</ins><span class="cx"> 
</span><span class="cx"> ;; Sandbox extensions
</span><span class="cx"> (define (apply-read-and-issue-extension op path-filter)
</span><span class="lines">@@ -66,8 +69,11 @@
</span><span class="cx">             (extension &quot;com.apple.app-sandbox.read-write&quot;))))
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-(allow file-read* file-write* (extension &quot;com.apple.nsurlstorage.extension-cache&quot;))
-(allow file-issue-extension (extension-class &quot;com.apple.nsurlstorage.extension-cache&quot;))
</del><ins>+;; Access to client's cache folder &amp; re-vending to CFNetwork.
+;; FIXME: Remove the webkti specific extension classes &lt;rdar://problem/17755931&gt;
+(allow file-issue-extension (require-all
+    (require-any (extension &quot;com.apple.webkit.read-write&quot;) (extension &quot;com.apple.app-sandbox.read-write&quot;))
+    (extension-class &quot;com.apple.nsurlstorage.extension-cache&quot;)))
</ins><span class="cx"> 
</span><span class="cx"> ;; Access to own cache &amp; temp folders.
</span><span class="cx"> (allow file-read* (extension &quot;com.apple.webkit.read&quot;))
</span></span></pre>
</div>
</div>

</body>
</html>