<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171264] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171264">171264</a></dd>
<dt>Author</dt> <dd>mrowe@apple.com</dd>
<dt>Date</dt> <dd>2014-07-19 11:07:43 -0700 (Sat, 19 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre><https://webkit.org/b/135085> Ensure that make_names.pl generates the same result when run multiple times.
Perl 5.18 introduced hash randomization. This results in the iteration order of hashes being different
from one run to the next. To ensure identical output we can iterate over the hash keys in sorted order.
Reviewed by Alexey Proskuryakov.
* bindings/scripts/StaticString.pm:
(GenerateStrings):
(GenerateStringAsserts):
* dom/make_names.pl:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsStaticStringpm">trunk/Source/WebCore/bindings/scripts/StaticString.pm</a></li>
<li><a href="#trunkSourceWebCoredommake_namespl">trunk/Source/WebCore/dom/make_names.pl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171263 => 171264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-19 16:16:39 UTC (rev 171263)
+++ trunk/Source/WebCore/ChangeLog 2014-07-19 18:07:43 UTC (rev 171264)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-07-19 Mark Rowe <mrowe@apple.com>
+
+ <https://webkit.org/b/135085> Ensure that make_names.pl generates the same result when run multiple times.
+
+ Perl 5.18 introduced hash randomization. This results in the iteration order of hashes being different
+ from one run to the next. To ensure identical output we can iterate over the hash keys in sorted order.
+
+ Reviewed by Alexey Proskuryakov.
+
+ * bindings/scripts/StaticString.pm:
+ (GenerateStrings):
+ (GenerateStringAsserts):
+ * dom/make_names.pl:
+
</ins><span class="cx"> 2014-07-19 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> Document::unregisterNodeListforInvalidation() and Document::unregisterCollection() have incorrect assertions
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsStaticStringpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/StaticString.pm (171263 => 171264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/StaticString.pm 2014-07-19 16:16:39 UTC (rev 171263)
+++ trunk/Source/WebCore/bindings/scripts/StaticString.pm 2014-07-19 18:07:43 UTC (rev 171264)
</span><span class="lines">@@ -33,13 +33,14 @@
</span><span class="cx">
</span><span class="cx"> my @result = ();
</span><span class="cx">
</span><del>- while ( my ($name, $value) = each %strings ) {
- push(@result, "static const LChar ${name}String8[] = \"${value}\";\n");
</del><ins>+ for my $name (sort keys %strings) {
+ push(@result, "static const LChar ${name}String8[] = \"$strings{$name}\";\n");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> push(@result, "\n");
</span><span class="cx">
</span><del>- while ( my ($name, $value) = each %strings ) {
</del><ins>+ for my $name (sort keys %strings) {
+ my $value = $strings{$name};
</ins><span class="cx"> my $length = length($value);
</span><span class="cx"> my $hash = Hasher::GenerateHashValue($value);
</span><span class="cx"> push(@result, <<END);
</span><span class="lines">@@ -66,7 +67,7 @@
</span><span class="cx">
</span><span class="cx"> push(@result, "#ifndef NDEBUG\n");
</span><span class="cx">
</span><del>- while ( my ($name, $value) = each %strings ) {
</del><ins>+ for my $name (sort keys %strings) {
</ins><span class="cx"> push(@result, " reinterpret_cast<StringImpl*>(&${name}Data)->assertHashIsCorrect();\n");
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredommake_namespl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/make_names.pl (171263 => 171264)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/make_names.pl 2014-07-19 16:16:39 UTC (rev 171263)
+++ trunk/Source/WebCore/dom/make_names.pl 2014-07-19 18:07:43 UTC (rev 171264)
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx">
</span><span class="cx"> print F StaticString::GenerateStrings(\%parameters);
</span><span class="cx">
</span><del>- while ( my ($name, $identifier) = each %parameters ) {
</del><ins>+ for my $name (sort keys %parameters) {
</ins><span class="cx"> print F "DEFINE_GLOBAL(AtomicString, $name)\n";
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -128,7 +128,7 @@
</span><span class="cx"> print F "\n";
</span><span class="cx"> print F StaticString::GenerateStringAsserts(\%parameters);
</span><span class="cx">
</span><del>- while ( my ($name, $identifier) = each %parameters ) {
</del><ins>+ for my $name (sort keys %parameters) {
</ins><span class="cx"> # FIXME: Would like to use static_cast here, but there are differences in const
</span><span class="cx"> # depending on whether SKIP_STATIC_CONSTRUCTORS_ON_GCC is used, so stick with a
</span><span class="cx"> # C-style cast for now.
</span></span></pre>
</div>
</div>
</body>
</html>