<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171153] branches/ftlopt/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171153">171153</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2014-07-16 14:33:05 -0700 (Wed, 16 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[ftlopt] Constant fold GetGetter and GetSetter if the GetterSetter is a constant
https://bugs.webkit.org/show_bug.cgi?id=134962
Reviewed by Oliver Hunt.
This removes yet another steady-state-throughput implication of using getters and setters:
if your accessor call is monomorphic then you'll just get a structure check, nothing more.
No more loads to get to the GetterSetter object or the accessor function object.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* runtime/GetterSetter.h:
(JSC::GetterSetter::getterConcurrently):
(JSC::GetterSetter::setGetter):
(JSC::GetterSetter::setterConcurrently):
(JSC::GetterSetter::setSetter):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesftloptSourceJavaScriptCoreChangeLog">branches/ftlopt/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchesftloptSourceJavaScriptCoredfgDFGAbstractInterpreterInlinesh">branches/ftlopt/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h</a></li>
<li><a href="#branchesftloptSourceJavaScriptCoreruntimeGetterSetterh">branches/ftlopt/Source/JavaScriptCore/runtime/GetterSetter.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesftloptSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/Source/JavaScriptCore/ChangeLog (171152 => 171153)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/ChangeLog 2014-07-16 21:31:39 UTC (rev 171152)
+++ branches/ftlopt/Source/JavaScriptCore/ChangeLog 2014-07-16 21:33:05 UTC (rev 171153)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2014-07-15 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><ins>+ [ftlopt] Constant fold GetGetter and GetSetter if the GetterSetter is a constant
+ https://bugs.webkit.org/show_bug.cgi?id=134962
+
+ Reviewed by Oliver Hunt.
+
+ This removes yet another steady-state-throughput implication of using getters and setters:
+ if your accessor call is monomorphic then you'll just get a structure check, nothing more.
+ No more loads to get to the GetterSetter object or the accessor function object.
+
+ * dfg/DFGAbstractInterpreterInlines.h:
+ (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
+ * runtime/GetterSetter.h:
+ (JSC::GetterSetter::getterConcurrently):
+ (JSC::GetterSetter::setGetter):
+ (JSC::GetterSetter::setterConcurrently):
+ (JSC::GetterSetter::setSetter):
+
+2014-07-15 Filip Pizlo <fpizlo@apple.com>
+
</ins><span class="cx"> [ftlopt] Identity replacement in CSE shouldn't create a Phantom over the Identity's children
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=134893
</span><span class="cx">
</span></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoredfgDFGAbstractInterpreterInlinesh"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h (171152 => 171153)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h 2014-07-16 21:31:39 UTC (rev 171152)
+++ branches/ftlopt/Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h 2014-07-16 21:33:05 UTC (rev 171153)
</span><span class="lines">@@ -1337,11 +1337,35 @@
</span><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> case GetCallee:
</span><del>- case GetGetter:
- case GetSetter:
</del><span class="cx"> forNode(node).setType(SpecFunction);
</span><span class="cx"> break;
</span><span class="cx">
</span><ins>+ case GetGetter: {
+ JSValue base = forNode(node->child1()).m_value;
+ if (base) {
+ if (JSObject* getter = jsCast<GetterSetter*>(base)->getterConcurrently()) {
+ setConstant(node, *m_graph.freeze(getter));
+ break;
+ }
+ }
+
+ forNode(node).setType(SpecObject);
+ break;
+ }
+
+ case GetSetter: {
+ JSValue base = forNode(node->child1()).m_value;
+ if (base) {
+ if (JSObject* setter = jsCast<GetterSetter*>(base)->setterConcurrently()) {
+ setConstant(node, *m_graph.freeze(setter));
+ break;
+ }
+ }
+
+ forNode(node).setType(SpecObject);
+ break;
+ }
+
</ins><span class="cx"> case GetScope: // FIXME: We could get rid of these if we know that the JSFunction is a constant. https://bugs.webkit.org/show_bug.cgi?id=106202
</span><span class="cx"> case GetMyScope:
</span><span class="cx"> case SkipTopScope:
</span></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoreruntimeGetterSetterh"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/Source/JavaScriptCore/runtime/GetterSetter.h (171152 => 171153)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/runtime/GetterSetter.h 2014-07-16 21:31:39 UTC (rev 171152)
+++ branches/ftlopt/Source/JavaScriptCore/runtime/GetterSetter.h 2014-07-16 21:33:05 UTC (rev 171153)
</span><span class="lines">@@ -61,21 +61,37 @@
</span><span class="cx">
</span><span class="cx"> JSObject* getter() const { return m_getter.get(); }
</span><span class="cx">
</span><ins>+ JSObject* getterConcurrently() const
+ {
+ JSObject* result = getter();
+ WTF::loadLoadFence();
+ return result;
+ }
+
</ins><span class="cx"> // Set the getter. It's only valid to call this if you've never set the getter on this
</span><span class="cx"> // object.
</span><span class="cx"> void setGetter(VM& vm, JSObject* getter)
</span><span class="cx"> {
</span><span class="cx"> RELEASE_ASSERT(!m_getter);
</span><ins>+ WTF::storeStoreFence();
</ins><span class="cx"> m_getter.setMayBeNull(vm, this, getter);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> JSObject* setter() const { return m_setter.get(); }
</span><span class="cx">
</span><ins>+ JSObject* setterConcurrently() const
+ {
+ JSObject* result = setter();
+ WTF::loadLoadFence();
+ return result;
+ }
+
</ins><span class="cx"> // Set the setter. It's only valid to call this if you've never set the setter on this
</span><span class="cx"> // object.
</span><span class="cx"> void setSetter(VM& vm, JSObject* setter)
</span><span class="cx"> {
</span><span class="cx"> RELEASE_ASSERT(!m_setter);
</span><ins>+ WTF::storeStoreFence();
</ins><span class="cx"> m_setter.setMayBeNull(vm, this, setter);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>