<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171043] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171043">171043</a></dd>
<dt>Author</dt> <dd>benjamin@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-12 19:24:37 -0700 (Sat, 12 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Rename selectorListContainsUncommonAttributeSelector() to selectorListContainsAttributeSelector()
https://bugs.webkit.org/show_bug.cgi?id=134862
Reviewed by Sam Weinig.
Unlike containsUncommonAttributeSelector(), selectorListContainsUncommonAttributeSelector() does not
evaluate the attribute for "uncommon" types.
It would be possible to change the function instead to evaluate common attributes based
on the match type and the pseudo class type. Such change would be more risky
and we would get very little benefit from it, I leave that for later if that ever becomes useful.
* css/RuleSet.cpp:
(WebCore::selectorListContainsAttributeSelector):
(WebCore::containsUncommonAttributeSelector):
(WebCore::selectorListContainsUncommonAttributeSelector): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssRuleSetcpp">trunk/Source/WebCore/css/RuleSet.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171042 => 171043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-13 01:44:23 UTC (rev 171042)
+++ trunk/Source/WebCore/ChangeLog 2014-07-13 02:24:37 UTC (rev 171043)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-07-12 Benjamin Poulain <benjamin@webkit.org>
+
+ Rename selectorListContainsUncommonAttributeSelector() to selectorListContainsAttributeSelector()
+ https://bugs.webkit.org/show_bug.cgi?id=134862
+
+ Reviewed by Sam Weinig.
+
+ Unlike containsUncommonAttributeSelector(), selectorListContainsUncommonAttributeSelector() does not
+ evaluate the attribute for "uncommon" types.
+
+ It would be possible to change the function instead to evaluate common attributes based
+ on the match type and the pseudo class type. Such change would be more risky
+ and we would get very little benefit from it, I leave that for later if that ever becomes useful.
+
+ * css/RuleSet.cpp:
+ (WebCore::selectorListContainsAttributeSelector):
+ (WebCore::containsUncommonAttributeSelector):
+ (WebCore::selectorListContainsUncommonAttributeSelector): Deleted.
+
</ins><span class="cx"> 2014-07-12 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> Use braced-init-list to create one-item Vector object in insertPerformanceEntry
</span></span></pre></div>
<a id="trunkSourceWebCorecssRuleSetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/RuleSet.cpp (171042 => 171043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/RuleSet.cpp 2014-07-13 01:44:23 UTC (rev 171042)
+++ trunk/Source/WebCore/css/RuleSet.cpp 2014-07-13 02:24:37 UTC (rev 171043)
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx"> return selector.m_match == CSSSelector::Id || selector.m_match == CSSSelector::Class;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline bool selectorListContainsUncommonAttributeSelector(const CSSSelector* selector)
</del><ins>+static inline bool selectorListContainsAttributeSelector(const CSSSelector* selector)
</ins><span class="cx"> {
</span><span class="cx"> const CSSSelectorList* selectorList = selector->selectorList();
</span><span class="cx"> if (!selectorList)
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx"> // Allow certain common attributes (used in the default style) in the selectors that match the current element.
</span><span class="cx"> if (selector->isAttributeSelector() && !isCommonAttributeSelectorAttribute(selector->attribute()))
</span><span class="cx"> return true;
</span><del>- if (selectorListContainsUncommonAttributeSelector(selector))
</del><ins>+ if (selectorListContainsAttributeSelector(selector))
</ins><span class="cx"> return true;
</span><span class="cx"> if (selector->relation() != CSSSelector::SubSelector) {
</span><span class="cx"> selector = selector->tagHistory();
</span><span class="lines">@@ -105,7 +105,7 @@
</span><span class="cx"> for (; selector; selector = selector->tagHistory()) {
</span><span class="cx"> if (selector->isAttributeSelector())
</span><span class="cx"> return true;
</span><del>- if (selectorListContainsUncommonAttributeSelector(selector))
</del><ins>+ if (selectorListContainsAttributeSelector(selector))
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span></span></pre>
</div>
</div>
</body>
</html>