<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171045] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171045">171045</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2014-07-12 22:51:20 -0700 (Sat, 12 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Cocoa] Notify the client when a navigation snapshot is taken
https://bugs.webkit.org/show_bug.cgi?id=134865
Reviewed by Sam Weinig.
* UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new delegate method.
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate): Initialize new flag in
m_navigationDelegateMethods.
(WebKit::NavigationState::willRecordNavigationSnapshot): Added. Calls the new
WKNavigationDelegate method.
* UIProcess/PageClient.h: Declared new client function.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willRecordNavigationSnapshot): Added. Calls the new client function.
* UIProcess/WebPageProxy.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::willRecordNavigationSnapshot): Override that calls
NavigationState::willRecordNavigationSnapshot.
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::willRecordNavigationSnapshot): Ditto.
* UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::recordSnapshot): Added a call to
WebPageProxy::willRecordNavigationSnapshot.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKNavigationDelegatePrivateh">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCocoaNavigationStateh">trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCocoaNavigationStatemm">trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPageClienth">trunk/Source/WebKit2/UIProcess/PageClient.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxyh">trunk/Source/WebKit2/UIProcess/WebPageProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosPageClientImplIOSh">trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosPageClientImplIOSmm">trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacPageClientImplh">trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacPageClientImplmm">trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacViewSnapshotStoremm">trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2014-07-12 Dan Bernstein <mitz@apple.com>
+
+ [Cocoa] Notify the client when a navigation snapshot is taken
+ https://bugs.webkit.org/show_bug.cgi?id=134865
+
+ Reviewed by Sam Weinig.
+
+ * UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new delegate method.
+
+ * UIProcess/Cocoa/NavigationState.h:
+ * UIProcess/Cocoa/NavigationState.mm:
+ (WebKit::NavigationState::setNavigationDelegate): Initialize new flag in
+ m_navigationDelegateMethods.
+ (WebKit::NavigationState::willRecordNavigationSnapshot): Added. Calls the new
+ WKNavigationDelegate method.
+
+ * UIProcess/PageClient.h: Declared new client function.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::willRecordNavigationSnapshot): Added. Calls the new client function.
+ * UIProcess/WebPageProxy.h:
+
+ * UIProcess/ios/PageClientImplIOS.h:
+ * UIProcess/ios/PageClientImplIOS.mm:
+ (WebKit::PageClientImpl::willRecordNavigationSnapshot): Override that calls
+ NavigationState::willRecordNavigationSnapshot.
+
+ * UIProcess/mac/PageClientImpl.h:
+ * UIProcess/mac/PageClientImpl.mm:
+ (WebKit::PageClientImpl::willRecordNavigationSnapshot): Ditto.
+
+ * UIProcess/mac/ViewSnapshotStore.mm:
+ (WebKit::ViewSnapshotStore::recordSnapshot): Added a call to
+ WebPageProxy::willRecordNavigationSnapshot.
+
</ins><span class="cx"> 2014-07-12 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, fix EFL build break since r171034.
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKNavigationDelegatePrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -64,8 +64,8 @@
</span><span class="cx"> - (void)_webViewDidEndNavigationGesture:(WKWebView *)webView withNavigationToBackForwardListItem:(WKBackForwardListItem *)item;
</span><span class="cx"> // Only called if how the gesture will end (with or without navigation) is known before it ends.
</span><span class="cx"> - (void)_webViewWillEndNavigationGesture:(WKWebView *)webView withNavigationToBackForwardListItem:(WKBackForwardListItem *)item;
</span><ins>+- (void)_webView:(WKWebView *)webView willSnapshotBackForwardListItem:(WKBackForwardListItem *)item;
</ins><span class="cx">
</span><del>-
</del><span class="cx"> #if TARGET_OS_IPHONE
</span><span class="cx"> - (void)_webView:(WKWebView *)webView didStartLoadForQuickLookDocumentInMainFrameWithFileName:(NSString *)fileName uti:(NSString *)uti;
</span><span class="cx"> - (void)_webView:(WKWebView *)webView didFinishLoadForQuickLookDocumentInMainFrame:(NSData *)documentData;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaNavigationStateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.h 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -78,6 +78,7 @@
</span><span class="cx"> void navigationGestureDidBegin();
</span><span class="cx"> void navigationGestureWillEnd(bool willNavigate, WebBackForwardListItem&);
</span><span class="cx"> void navigationGestureDidEnd(bool willNavigate, WebBackForwardListItem&);
</span><ins>+ void willRecordNavigationSnapshot(WebBackForwardListItem&);
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> class PolicyClient : public API::PolicyClient {
</span><span class="lines">@@ -166,6 +167,7 @@
</span><span class="cx"> bool webViewDidBeginNavigationGesture : 1;
</span><span class="cx"> bool webViewWillEndNavigationGestureWithNavigationToBackForwardListItem : 1;
</span><span class="cx"> bool webViewDidEndNavigationGestureWithNavigationToBackForwardListItem : 1;
</span><ins>+ bool webViewWillSnapshotBackForwardListItem : 1;
</ins><span class="cx"> #if USE(QUICK_LOOK)
</span><span class="cx"> bool webViewDidStartLoadForQuickLookDocumentInMainFrame : 1;
</span><span class="cx"> bool webViewDidFinishLoadForQuickLookDocumentInMainFrame : 1;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaNavigationStatemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -140,6 +140,7 @@
</span><span class="cx"> m_navigationDelegateMethods.webViewDidBeginNavigationGesture = [delegate respondsToSelector:@selector(_webViewDidBeginNavigationGesture:)];
</span><span class="cx"> m_navigationDelegateMethods.webViewWillEndNavigationGestureWithNavigationToBackForwardListItem = [delegate respondsToSelector:@selector(_webViewWillEndNavigationGesture:withNavigationToBackForwardListItem:)];
</span><span class="cx"> m_navigationDelegateMethods.webViewDidEndNavigationGestureWithNavigationToBackForwardListItem = [delegate respondsToSelector:@selector(_webViewDidEndNavigationGesture:withNavigationToBackForwardListItem:)];
</span><ins>+ m_navigationDelegateMethods.webViewWillSnapshotBackForwardListItem = [delegate respondsToSelector:@selector(_webView:willSnapshotBackForwardListItem:)];
</ins><span class="cx"> #if USE(QUICK_LOOK)
</span><span class="cx"> m_navigationDelegateMethods.webViewDidStartLoadForQuickLookDocumentInMainFrame = [delegate respondsToSelector:@selector(_webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:)];
</span><span class="cx"> m_navigationDelegateMethods.webViewDidFinishLoadForQuickLookDocumentInMainFrame = [delegate respondsToSelector:@selector(_webView:didFinishLoadForQuickLookDocumentInMainFrame:)];
</span><span class="lines">@@ -290,6 +291,18 @@
</span><span class="cx"> [static_cast<id <WKNavigationDelegatePrivate>>(navigationDelegate) _webViewDidEndNavigationGesture:m_webView withNavigationToBackForwardListItem:willNavigate ? wrapper(item) : nil];
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void NavigationState::willRecordNavigationSnapshot(WebBackForwardListItem& item)
+{
+ if (!m_navigationDelegateMethods.webViewWillSnapshotBackForwardListItem)
+ return;
+
+ auto navigationDelegate = m_navigationDelegate.get();
+ if (!navigationDelegate)
+ return;
+
+ [static_cast<id <WKNavigationDelegatePrivate>>(navigationDelegate) _webView:m_webView willSnapshotBackForwardListItem:wrapper(item)];
+}
+
</ins><span class="cx"> NavigationState::PolicyClient::PolicyClient(NavigationState& navigationState)
</span><span class="cx"> : m_navigationState(navigationState)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPageClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/PageClient.h (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/PageClient.h 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/PageClient.h 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -298,6 +298,7 @@
</span><span class="cx"> virtual void navigationGestureDidBegin() = 0;
</span><span class="cx"> virtual void navigationGestureWillEnd(bool willNavigate, WebBackForwardListItem&) = 0;
</span><span class="cx"> virtual void navigationGestureDidEnd(bool willNavigate, WebBackForwardListItem&) = 0;
</span><ins>+ virtual void willRecordNavigationSnapshot(WebBackForwardListItem&) = 0;
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -5143,6 +5143,11 @@
</span><span class="cx"> m_pageClient.navigationGestureDidEnd(willNavigate, item);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WebPageProxy::willRecordNavigationSnapshot(WebBackForwardListItem& item)
+{
+ m_pageClient.willRecordNavigationSnapshot(item);
+}
+
</ins><span class="cx"> void WebPageProxy::navigationGestureSnapshotWasRemoved()
</span><span class="cx"> {
</span><span class="cx"> m_isShowingNavigationGestureSnapshot = false;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -901,6 +901,7 @@
</span><span class="cx"> void navigationGestureWillEnd(bool willNavigate, WebBackForwardListItem&);
</span><span class="cx"> void navigationGestureDidEnd(bool willNavigate, WebBackForwardListItem&);
</span><span class="cx"> void navigationGestureSnapshotWasRemoved();
</span><ins>+ void willRecordNavigationSnapshot(WebBackForwardListItem&);
</ins><span class="cx">
</span><span class="cx"> bool isShowingNavigationGestureSnapshot() const { return m_isShowingNavigationGestureSnapshot; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosPageClientImplIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -170,6 +170,7 @@
</span><span class="cx"> virtual void navigationGestureDidBegin() override;
</span><span class="cx"> virtual void navigationGestureWillEnd(bool willNavigate, WebBackForwardListItem&) override;
</span><span class="cx"> virtual void navigationGestureDidEnd(bool willNavigate, WebBackForwardListItem&) override;
</span><ins>+ virtual void willRecordNavigationSnapshot(WebBackForwardListItem&) override;
</ins><span class="cx">
</span><span class="cx"> WKContentView *m_contentView;
</span><span class="cx"> WKWebView *m_webView;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosPageClientImplIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -667,6 +667,11 @@
</span><span class="cx"> NavigationState::fromWebPage(*m_webView->_page).navigationGestureDidEnd(willNavigate, item);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void PageClientImpl::willRecordNavigationSnapshot(WebBackForwardListItem& item)
+{
+ NavigationState::fromWebPage(*m_webView->_page).willRecordNavigationSnapshot(item);
+}
+
</ins><span class="cx"> } // namespace WebKit
</span><span class="cx">
</span><span class="cx"> #endif // PLATFORM(IOS)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacPageClientImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -176,6 +176,7 @@
</span><span class="cx"> virtual void navigationGestureDidBegin() override;
</span><span class="cx"> virtual void navigationGestureWillEnd(bool willNavigate, WebBackForwardListItem&) override;
</span><span class="cx"> virtual void navigationGestureDidEnd(bool willNavigate, WebBackForwardListItem&) override;
</span><ins>+ virtual void willRecordNavigationSnapshot(WebBackForwardListItem&) override;
</ins><span class="cx">
</span><span class="cx"> NSView *activeView() const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacPageClientImplmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -714,6 +714,15 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void PageClientImpl::willRecordNavigationSnapshot(WebBackForwardListItem& item)
+{
+#if WK_API_ENABLED
+ NavigationState::fromWebPage(*m_webView->_page).willRecordNavigationSnapshot(item);
+#else
+ UNUSED_PARAM(item);
+#endif
+}
+
</ins><span class="cx"> } // namespace WebKit
</span><span class="cx">
</span><span class="cx"> #endif // PLATFORM(MAC)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacViewSnapshotStoremm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm (171044 => 171045)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm 2014-07-13 02:37:58 UTC (rev 171044)
+++ trunk/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm 2014-07-13 05:51:20 UTC (rev 171045)
</span><span class="lines">@@ -119,6 +119,8 @@
</span><span class="cx">
</span><span class="cx"> pruneSnapshots(webPageProxy);
</span><span class="cx">
</span><ins>+ webPageProxy.willRecordNavigationSnapshot(*item);
+
</ins><span class="cx"> RefPtr<ViewSnapshot> snapshot = webPageProxy.takeViewSnapshot();
</span><span class="cx"> if (!snapshot || !snapshot->hasImage())
</span><span class="cx"> return;
</span></span></pre>
</div>
</div>
</body>
</html>