<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[171014] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/171014">171014</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-07-11 15:36:14 -0700 (Fri, 11 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/168868">r168868</a>): eBay 'see all' links fail due to different JS bindings conversion behavior.
https://bugs.webkit.org/show_bug.cgi?id=134841
<rdar://problem/17577563>
Reviewed by Simon Fraser.
Revert back to type int for Element.scroll* APIs in order to preserve exception handling
behavior.
Source/WebCore:
Test: cssom/non-subpixel-scroll-top-left-values.html
* dom/Element.cpp:
(WebCore::Element::scrollLeft):
(WebCore::Element::scrollTop):
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
(WebCore::Element::scrollWidth):
(WebCore::Element::scrollHeight):
* dom/Element.h:
* dom/Element.idl:
* html/HTMLBodyElement.cpp:
(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::scrollLeft):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::scrollTop):
(WebCore::HTMLBodyElement::setScrollTop):
(WebCore::HTMLBodyElement::scrollHeight):
(WebCore::HTMLBodyElement::scrollWidth):
* html/HTMLBodyElement.h:
LayoutTests:
* cssom/non-subpixel-scroll-top-left-values-expected.txt: Added.
* cssom/non-subpixel-scroll-top-left-values.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt">trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs">trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
<li><a href="#trunkSourceWebCoredomElementidl">trunk/Source/WebCore/dom/Element.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLBodyElementcpp">trunk/Source/WebCore/html/HTMLBodyElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLBodyElementh">trunk/Source/WebCore/html/HTMLBodyElement.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscssomnonsubpixelscrolltopleftvaluesexpectedtxt">trunk/LayoutTests/cssom/non-subpixel-scroll-top-left-values-expected.txt</a></li>
<li><a href="#trunkLayoutTestscssomnonsubpixelscrolltopleftvalueshtml">trunk/LayoutTests/cssom/non-subpixel-scroll-top-left-values.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (171013 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-07-11 21:54:19 UTC (rev 171013)
+++ trunk/LayoutTests/ChangeLog 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-07-11 Zalan Bujtas <zalan@apple.com>
+
+ REGRESSION (r168868): eBay 'see all' links fail due to different JS bindings conversion behavior.
+ https://bugs.webkit.org/show_bug.cgi?id=134841
+ <rdar://problem/17577563>
+
+ Reviewed by Simon Fraser.
+
+ Revert back to type int for Element.scroll* APIs in order to preserve exception handling
+ behavior.
+
+ * cssom/non-subpixel-scroll-top-left-values-expected.txt: Added.
+ * cssom/non-subpixel-scroll-top-left-values.html: Added.
+
</ins><span class="cx"> 2014-07-11 Javier Fernandez <jfernandez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CSS Grid Layout] Implement justify-self css property
</span></span></pre></div>
<a id="trunkLayoutTestscssomnonsubpixelscrolltopleftvaluesexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/cssom/non-subpixel-scroll-top-left-values-expected.txt (0 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/cssom/non-subpixel-scroll-top-left-values-expected.txt (rev 0)
+++ trunk/LayoutTests/cssom/non-subpixel-scroll-top-left-values-expected.txt 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -0,0 +1,226 @@
</span><ins>+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:0.00scrollLeft:0.00
+scrollTop:1.00scrollLeft:1.00
+scrollTop:1.00scrollLeft:1.00
+scrollTop:1.00scrollLeft:1.00
+scrollTop:1.00scrollLeft:1.00
+scrollTop:1.00scrollLeft:1.00
+scrollTop:1.00scrollLeft:1.00
+scrollTop:1.00scrollLeft:1.00
+scrollTop:1.00scrollLeft:1.00
+scrollTop:1.00scrollLeft:1.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:2.00scrollLeft:2.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:3.00scrollLeft:3.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:4.00scrollLeft:4.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:5.00scrollLeft:5.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:6.00scrollLeft:6.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:7.00scrollLeft:7.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:8.00scrollLeft:8.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:9.00scrollLeft:9.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:10.00scrollLeft:10.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:11.00scrollLeft:11.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:12.00scrollLeft:12.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:13.00scrollLeft:13.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:14.00scrollLeft:14.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:15.00scrollLeft:15.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:16.00scrollLeft:16.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:17.00scrollLeft:17.00
+scrollTop:18.00scrollLeft:18.00
+scrollTop:18.00scrollLeft:18.00
+scrollTop:18.00scrollLeft:18.00
+scrollTop:18.00scrollLeft:18.00
+scrollTop:18.00scrollLeft:18.00
+scrollTop:18.00scrollLeft:18.00
+scrollTop:18.00scrollLeft:18.00
+scrollTop:18.00scrollLeft:18.00
+scrollTop:18.00scrollLeft:18.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:19.00scrollLeft:19.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:20.00scrollLeft:20.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:21.00scrollLeft:21.00
+scrollTop:22.00scrollLeft:22.00
+scrollTop:22.00scrollLeft:22.00
+scrollTop:22.00scrollLeft:22.00
+scrollTop:22.00scrollLeft:22.00
+scrollTop:22.00scrollLeft:22.00
+
</ins></span></pre></div>
<a id="trunkLayoutTestscssomnonsubpixelscrolltopleftvalueshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/cssom/non-subpixel-scroll-top-left-values.html (0 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/cssom/non-subpixel-scroll-top-left-values.html (rev 0)
+++ trunk/LayoutTests/cssom/non-subpixel-scroll-top-left-values.html 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -0,0 +1,44 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that Element.scroll* return integral values.</title>
+<style>
+div {
+ position: fixed;
+ width: 30px;
+ height: 30px;
+ border: 1px solid red;
+ overflow: scroll;
+}
+</style>
+</head>
+<body>
+<script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ var container = document.body;
+ for (i = 0; i < 15; ++i) {
+ for (j = 0; j < 15; ++j) {
+ var e = document.createElement("div");
+ e.style.top = (30 * i) + "px";
+ e.style.left = (30 * j) + "px";
+ e.innerHTML = "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. ";
+ container.appendChild(e);
+ }
+ }
+
+ var result = "";
+ var adjustment = 0;
+ var divs = document.getElementsByTagName("div");
+ for (i = 0; i < divs.length; ++i) {
+ var element = divs[i];
+ element.scrollTop = adjustment;
+ element.scrollLeft = adjustment;
+ result += "scrollTop:" + element.scrollTop.toFixed(2) + "scrollLeft:" + element.scrollLeft.toFixed(2) + "<br>";
+ adjustment += 0.1;
+ }
+ document.body.innerHTML = result;
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomnonnumericvaluesnumericparametersexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt (171013 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2014-07-11 21:54:19 UTC (rev 171013)
+++ trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -23,8 +23,8 @@
</span><span class="cx"> PASS nonNumericPolicy('document.elementFromPoint(0, x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.body.scrollByLines(x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.body.scrollByPages(x)') is 'any type allowed'
</span><del>-PASS nonNumericPolicy('document.body.scrollLeft = x') is 'mixed'
-PASS nonNumericPolicy('document.body.scrollTop = x') is 'mixed'
</del><ins>+PASS nonNumericPolicy('document.body.scrollLeft = x') is 'any type allowed'
+PASS nonNumericPolicy('document.body.scrollTop = x') is 'any type allowed'
</ins><span class="cx"> PASS nonNumericPolicy('document.images.item(x)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createElement("input").setSelectionRange(x, 0)') is 'any type allowed'
</span><span class="cx"> PASS nonNumericPolicy('document.createElement("input").setSelectionRange(0, x)') is 'any type allowed'
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomscripttestsnonnumericvaluesnumericparametersjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (171013 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2014-07-11 21:54:19 UTC (rev 171013)
+++ trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -226,8 +226,8 @@
</span><span class="cx">
</span><span class="cx"> shouldBe("nonNumericPolicy('document.body.scrollByLines(x)')", "'any type allowed'");
</span><span class="cx"> shouldBe("nonNumericPolicy('document.body.scrollByPages(x)')", "'any type allowed'");
</span><del>-shouldBe("nonNumericPolicy('document.body.scrollLeft = x')", "'mixed'");
-shouldBe("nonNumericPolicy('document.body.scrollTop = x')", "'mixed'");
</del><ins>+shouldBe("nonNumericPolicy('document.body.scrollLeft = x')", "'any type allowed'");
+shouldBe("nonNumericPolicy('document.body.scrollTop = x')", "'any type allowed'");
</ins><span class="cx">
</span><span class="cx"> // History
</span><span class="cx">
</span><span class="lines">@@ -392,8 +392,8 @@
</span><span class="cx"> ../../../../WebCore/html/HTMLAppletElement.idl: attribute [ConvertFromString] long vspace;
</span><span class="cx"> ../../../../WebCore/html/HTMLAreaElement.idl: attribute long tabIndex;
</span><span class="cx"> ../../../../WebCore/html/HTMLBaseFontElement.idl: attribute long size;
</span><del>-../../../../WebCore/html/HTMLBodyElement.idl: attribute float scrollLeft;
-../../../../WebCore/html/HTMLBodyElement.idl: attribute float scrollTop;
</del><ins>+../../../../WebCore/html/HTMLBodyElement.idl: attribute long scrollLeft;
+../../../../WebCore/html/HTMLBodyElement.idl: attribute long scrollTop;
</ins><span class="cx"> ../../../../WebCore/html/HTMLButtonElement.idl: attribute long tabIndex;
</span><span class="cx"> ../../../../WebCore/html/HTMLCanvasElement.idl: attribute long width;
</span><span class="cx"> ../../../../WebCore/html/HTMLCanvasElement.idl: attribute long height;
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (171013 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-11 21:54:19 UTC (rev 171013)
+++ trunk/Source/WebCore/ChangeLog 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2014-07-11 Zalan Bujtas <zalan@apple.com>
+
+ REGRESSION (r168868): eBay 'see all' links fail due to different JS bindings conversion behavior.
+ https://bugs.webkit.org/show_bug.cgi?id=134841
+ <rdar://problem/17577563>
+
+ Reviewed by Simon Fraser.
+
+ Revert back to type int for Element.scroll* APIs in order to preserve exception handling
+ behavior.
+
+ Test: cssom/non-subpixel-scroll-top-left-values.html
+
+ * dom/Element.cpp:
+ (WebCore::Element::scrollLeft):
+ (WebCore::Element::scrollTop):
+ (WebCore::Element::setScrollLeft):
+ (WebCore::Element::setScrollTop):
+ (WebCore::Element::scrollWidth):
+ (WebCore::Element::scrollHeight):
+ * dom/Element.h:
+ * dom/Element.idl:
+ * html/HTMLBodyElement.cpp:
+ (WebCore::adjustForZoom):
+ (WebCore::HTMLBodyElement::scrollLeft):
+ (WebCore::HTMLBodyElement::setScrollLeft):
+ (WebCore::HTMLBodyElement::scrollTop):
+ (WebCore::HTMLBodyElement::setScrollTop):
+ (WebCore::HTMLBodyElement::scrollHeight):
+ (WebCore::HTMLBodyElement::scrollWidth):
+ * html/HTMLBodyElement.h:
+
</ins><span class="cx"> 2014-07-11 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Debugger Pause button does not work
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (171013 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2014-07-11 21:54:19 UTC (rev 171013)
+++ trunk/Source/WebCore/dom/Element.cpp 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -823,7 +823,7 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-double Element::scrollLeft()
</del><ins>+int Element::scrollLeft()
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><span class="lines">@@ -832,7 +832,7 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-double Element::scrollTop()
</del><ins>+int Element::scrollTop()
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><span class="lines">@@ -841,29 +841,29 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Element::setScrollLeft(double newLeft)
</del><ins>+void Element::setScrollLeft(int newLeft)
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><span class="cx"> if (RenderBox* renderer = renderBox()) {
</span><del>- renderer->setScrollLeft(round(newLeft * renderer->style().effectiveZoom()));
</del><ins>+ renderer->setScrollLeft(static_cast<int>(newLeft * renderer->style().effectiveZoom()));
</ins><span class="cx"> if (auto* scrollableArea = renderer->layer())
</span><span class="cx"> scrollableArea->setScrolledProgrammatically(true);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Element::setScrollTop(double newTop)
</del><ins>+void Element::setScrollTop(int newTop)
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><span class="cx"> if (RenderBox* renderer = renderBox()) {
</span><del>- renderer->setScrollTop(round(newTop * renderer->style().effectiveZoom()));
</del><ins>+ renderer->setScrollTop(static_cast<int>(newTop * renderer->style().effectiveZoom()));
</ins><span class="cx"> if (auto* scrollableArea = renderer->layer())
</span><span class="cx"> scrollableArea->setScrolledProgrammatically(true);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-double Element::scrollWidth()
</del><ins>+int Element::scrollWidth()
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx"> if (RenderBox* rend = renderBox())
</span><span class="lines">@@ -871,7 +871,7 @@
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-double Element::scrollHeight()
</del><ins>+int Element::scrollHeight()
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx"> if (RenderBox* rend = renderBox())
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (171013 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2014-07-11 21:54:19 UTC (rev 171013)
+++ trunk/Source/WebCore/dom/Element.h 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -220,12 +220,12 @@
</span><span class="cx"> double clientTop();
</span><span class="cx"> double clientWidth();
</span><span class="cx"> double clientHeight();
</span><del>- virtual double scrollLeft();
- virtual double scrollTop();
- virtual void setScrollLeft(double);
- virtual void setScrollTop(double);
- virtual double scrollWidth();
- virtual double scrollHeight();
</del><ins>+ virtual int scrollLeft();
+ virtual int scrollTop();
+ virtual void setScrollLeft(int);
+ virtual void setScrollTop(int);
+ virtual int scrollWidth();
+ virtual int scrollHeight();
</ins><span class="cx">
</span><span class="cx"> IntRect boundsInRootViewSpace();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.idl (171013 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.idl 2014-07-11 21:54:19 UTC (rev 171013)
+++ trunk/Source/WebCore/dom/Element.idl 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -78,10 +78,6 @@
</span><span class="cx"> readonly attribute long clientTop;
</span><span class="cx"> readonly attribute long clientWidth;
</span><span class="cx"> readonly attribute long clientHeight;
</span><del>- attribute long scrollLeft;
- attribute long scrollTop;
- readonly attribute long scrollWidth;
- readonly attribute long scrollHeight;
</del><span class="cx"> #else
</span><span class="cx"> readonly attribute double offsetLeft;
</span><span class="cx"> readonly attribute double offsetTop;
</span><span class="lines">@@ -91,12 +87,13 @@
</span><span class="cx"> readonly attribute double clientTop;
</span><span class="cx"> readonly attribute double clientWidth;
</span><span class="cx"> readonly attribute double clientHeight;
</span><del>- attribute double scrollLeft;
- attribute double scrollTop;
- readonly attribute double scrollWidth;
- readonly attribute double scrollHeight;
</del><span class="cx"> #endif
</span><span class="cx">
</span><ins>+ attribute long scrollLeft;
+ attribute long scrollTop;
+ readonly attribute long scrollWidth;
+ readonly attribute long scrollHeight;
+
</ins><span class="cx"> [ImplementedAs=bindingsOffsetParent] readonly attribute Element offsetParent;
</span><span class="cx">
</span><span class="cx"> void focus();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLBodyElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLBodyElement.cpp (171013 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLBodyElement.cpp 2014-07-11 21:54:19 UTC (rev 171013)
+++ trunk/Source/WebCore/html/HTMLBodyElement.cpp 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -198,7 +198,7 @@
</span><span class="cx"> return hasEditableStyle() || HTMLElement::supportsFocus();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static double adjustForZoom(int value, const Frame& frame)
</del><ins>+static int adjustForZoom(int value, const Frame& frame)
</ins><span class="cx"> {
</span><span class="cx"> double zoomFactor = frame.pageZoomFactor() * frame.frameScaleFactor();
</span><span class="cx"> if (zoomFactor == 1)
</span><span class="lines">@@ -206,10 +206,10 @@
</span><span class="cx"> // Needed because of truncation (rather than rounding) when scaling up.
</span><span class="cx"> if (zoomFactor > 1)
</span><span class="cx"> value++;
</span><del>- return value / zoomFactor;
</del><ins>+ return static_cast<int>(value / zoomFactor);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-double HTMLBodyElement::scrollLeft()
</del><ins>+int HTMLBodyElement::scrollLeft()
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx"> Frame* frame = document().frame();
</span><span class="lines">@@ -218,10 +218,10 @@
</span><span class="cx"> FrameView* view = frame->view();
</span><span class="cx"> if (!view)
</span><span class="cx"> return 0;
</span><del>- return floor(adjustForZoom(view->contentsScrollPosition().x(), *frame));
</del><ins>+ return adjustForZoom(view->contentsScrollPosition().x(), *frame);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLBodyElement::setScrollLeft(double scrollLeft)
</del><ins>+void HTMLBodyElement::setScrollLeft(int scrollLeft)
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx"> Frame* frame = document().frame();
</span><span class="lines">@@ -233,7 +233,7 @@
</span><span class="cx"> view->setScrollPosition(IntPoint(static_cast<int>(scrollLeft * frame->pageZoomFactor() * frame->frameScaleFactor()), view->scrollY()));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-double HTMLBodyElement::scrollTop()
</del><ins>+int HTMLBodyElement::scrollTop()
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx"> Frame* frame = document().frame();
</span><span class="lines">@@ -242,10 +242,10 @@
</span><span class="cx"> FrameView* view = frame->view();
</span><span class="cx"> if (!view)
</span><span class="cx"> return 0;
</span><del>- return floor(adjustForZoom(view->contentsScrollPosition().y(), *frame));
</del><ins>+ return adjustForZoom(view->contentsScrollPosition().y(), *frame);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLBodyElement::setScrollTop(double scrollTop)
</del><ins>+void HTMLBodyElement::setScrollTop(int scrollTop)
</ins><span class="cx"> {
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx"> Frame* frame = document().frame();
</span><span class="lines">@@ -257,7 +257,7 @@
</span><span class="cx"> view->setScrollPosition(IntPoint(view->scrollX(), static_cast<int>(scrollTop * frame->pageZoomFactor() * frame->frameScaleFactor())));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-double HTMLBodyElement::scrollHeight()
</del><ins>+int HTMLBodyElement::scrollHeight()
</ins><span class="cx"> {
</span><span class="cx"> // Update the document's layout.
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="lines">@@ -267,10 +267,10 @@
</span><span class="cx"> FrameView* view = frame->view();
</span><span class="cx"> if (!view)
</span><span class="cx"> return 0;
</span><del>- return floor(adjustForZoom(view->contentsHeight(), *frame));
</del><ins>+ return adjustForZoom(view->contentsHeight(), *frame);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-double HTMLBodyElement::scrollWidth()
</del><ins>+int HTMLBodyElement::scrollWidth()
</ins><span class="cx"> {
</span><span class="cx"> // Update the document's layout.
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="lines">@@ -280,7 +280,7 @@
</span><span class="cx"> FrameView* view = frame->view();
</span><span class="cx"> if (!view)
</span><span class="cx"> return 0;
</span><del>- return floor(adjustForZoom(view->contentsWidth(), *frame));
</del><ins>+ return adjustForZoom(view->contentsWidth(), *frame);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLBodyElement::addSubresourceAttributeURLs(ListHashSet<URL>& urls) const
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLBodyElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLBodyElement.h (171013 => 171014)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLBodyElement.h 2014-07-11 21:54:19 UTC (rev 171013)
+++ trunk/Source/WebCore/html/HTMLBodyElement.h 2014-07-11 22:36:14 UTC (rev 171014)
</span><span class="lines">@@ -69,14 +69,14 @@
</span><span class="cx">
</span><span class="cx"> virtual bool supportsFocus() const override;
</span><span class="cx">
</span><del>- virtual double scrollLeft() override;
- virtual void setScrollLeft(double) override;
</del><ins>+ virtual int scrollLeft() override;
+ virtual void setScrollLeft(int) override;
</ins><span class="cx">
</span><del>- virtual double scrollTop() override;
- virtual void setScrollTop(double) override;
</del><ins>+ virtual int scrollTop() override;
+ virtual void setScrollTop(int) override;
</ins><span class="cx">
</span><del>- virtual double scrollHeight() override;
- virtual double scrollWidth() override;
</del><ins>+ virtual int scrollHeight() override;
+ virtual int scrollWidth() override;
</ins><span class="cx">
</span><span class="cx"> virtual void addSubresourceAttributeURLs(ListHashSet<URL>&) const override;
</span><span class="cx"> };
</span></span></pre>
</div>
</div>
</body>
</html>