<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170991] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170991">170991</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-10 22:06:55 -0700 (Thu, 10 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Debugger Continue button is incorrectly sized
https://bugs.webkit.org/show_bug.cgi?id=134786
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-07-10
Reviewed by Timothy Hatcher.
Before this patch everything in the DebuggerDashboardView was flexing.
Normally, if the contents were not too wide, this would just behave
as expected and be centered. If the content was too wide, then each
element would flex uniformly and overlap uniformly. That was not expected.
This patch changes makes everything but the link have a non-flexible
size. If the link (at the end) flexs it will have a nice ellipsis
text truncation, and the rest of the content will be left justified.
This also fixes a few other minor issues seen in the view.
* UserInterface/Views/DebuggerDashboardView.css:
(.dashboard.debugger .navigation-bar):
Reduce the complexity, give the nav bar (the resume button) some simple padding.
(.dashboard.debugger > div):
Make everything non-flex by default.
(.dashboard.debugger > .location):
The location will have an inner element flex, so make it flex.
(.dashboard.debugger > .location > *):
Make everything in .location non-flex by default.
(.dashboard.debugger > .location .go-to-link):
Make the link flex and truncate cleanly.
(.dashboard.debugger > .location .function-name):
Fix vertical alignment when the toolbar has small icons.
* UserInterface/Views/DebuggerDashboardView.js:
(WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
Fix class name spelling.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDebuggerDashboardViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDebuggerDashboardViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (170990 => 170991)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2014-07-11 04:26:31 UTC (rev 170990)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-07-11 05:06:55 UTC (rev 170991)
</span><span class="lines">@@ -1,3 +1,44 @@
</span><ins>+2014-07-10 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Debugger Continue button is incorrectly sized
+ https://bugs.webkit.org/show_bug.cgi?id=134786
+
+ Reviewed by Timothy Hatcher.
+
+ Before this patch everything in the DebuggerDashboardView was flexing.
+ Normally, if the contents were not too wide, this would just behave
+ as expected and be centered. If the content was too wide, then each
+ element would flex uniformly and overlap uniformly. That was not expected.
+
+ This patch changes makes everything but the link have a non-flexible
+ size. If the link (at the end) flexs it will have a nice ellipsis
+ text truncation, and the rest of the content will be left justified.
+
+ This also fixes a few other minor issues seen in the view.
+
+ * UserInterface/Views/DebuggerDashboardView.css:
+ (.dashboard.debugger .navigation-bar):
+ Reduce the complexity, give the nav bar (the resume button) some simple padding.
+
+ (.dashboard.debugger > div):
+ Make everything non-flex by default.
+
+ (.dashboard.debugger > .location):
+ The location will have an inner element flex, so make it flex.
+
+ (.dashboard.debugger > .location > *):
+ Make everything in .location non-flex by default.
+
+ (.dashboard.debugger > .location .go-to-link):
+ Make the link flex and truncate cleanly.
+
+ (.dashboard.debugger > .location .function-name):
+ Fix vertical alignment when the toolbar has small icons.
+
+ * UserInterface/Views/DebuggerDashboardView.js:
+ (WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
+ Fix class name spelling.
+
</ins><span class="cx"> 2014-07-09 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> [Win] Remove uses of 'bash' in build system
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDebuggerDashboardViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css (170990 => 170991)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css 2014-07-11 04:26:31 UTC (rev 170990)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css 2014-07-11 05:06:55 UTC (rev 170991)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx">
</span><span class="cx"> .dashboard.debugger .navigation-bar {
</span><span class="cx"> border: 0;
</span><del>- margin: 0 5px 0 -5px;
</del><ins>+ margin-right: 4px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .toolbar:not(.small-size) .dashboard.debugger .navigation-bar {
</span><span class="lines">@@ -85,8 +85,17 @@
</span><span class="cx"> .dashboard.debugger > div {
</span><span class="cx"> display: -webkit-flex;
</span><span class="cx"> -webkit-align-items: center;
</span><ins>+ -webkit-flex: none;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+.dashboard.debugger > .location {
+ -webkit-flex: initial;
+}
+
+.dashboard.debugger > .location > * {
+ -webkit-flex: none;
+}
+
</ins><span class="cx"> .dashboard.debugger > .location > :first-child {
</span><span class="cx"> -webkit-align-self: center;
</span><span class="cx"> width: 16px;
</span><span class="lines">@@ -105,6 +114,7 @@
</span><span class="cx">
</span><span class="cx"> .dashboard.debugger > .location .function-name {
</span><span class="cx"> color: rgb(30, 30, 30);
</span><ins>+ padding-bottom: 1px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .dashboard.debugger > .location .function-name::after {
</span><span class="lines">@@ -114,6 +124,10 @@
</span><span class="cx"> .dashboard.debugger > .location .go-to-link {
</span><span class="cx"> padding-bottom: 1px;
</span><span class="cx"> -webkit-text-decoration-color: #aaa;
</span><ins>+
+ -webkit-flex: initial;
+ text-overflow: ellipsis;
+ overflow: hidden;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .toolbar.collapsed .dashboard.debugger > :not(.message):not(.navigation-bar ) {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDebuggerDashboardViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js (170990 => 170991)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js 2014-07-11 04:26:31 UTC (rev 170990)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js 2014-07-11 05:06:55 UTC (rev 170991)
</span><span class="lines">@@ -61,7 +61,7 @@
</span><span class="cx"> WebInspector.DebuggerDashboardView.MessageStyleClassName = "message";
</span><span class="cx"> WebInspector.DebuggerDashboardView.DividerStyleClassName = "divider";
</span><span class="cx"> WebInspector.DebuggerDashboardView.LocationStyleClassName = "location";
</span><del>-WebInspector.DebuggerDashboardView.FunctionNameStyleClassname = "function-name";
</del><ins>+WebInspector.DebuggerDashboardView.FunctionNameStyleClassName = "function-name";
</ins><span class="cx">
</span><span class="cx"> WebInspector.DebuggerDashboardView.prototype = {
</span><span class="cx"> constructor: WebInspector.DebuggerDashboardView,
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx">
</span><span class="cx"> var nameElement = document.createElement("div");
</span><span class="cx"> nameElement.appendChild(document.createTextNode(functionName));
</span><del>- nameElement.classList.add(WebInspector.DebuggerDashboardView.FunctionNameStyleClassname);
</del><ins>+ nameElement.classList.add(WebInspector.DebuggerDashboardView.FunctionNameStyleClassName);
</ins><span class="cx"> this._locationElement.appendChild(nameElement);
</span><span class="cx">
</span><span class="cx"> var sourceCodeLocation = WebInspector.debuggerManager.activeCallFrame.sourceCodeLocation;
</span></span></pre>
</div>
</div>
</body>
</html>