<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170877] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170877">170877</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-07-07 21:26:24 -0700 (Mon, 07 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: icloud.com password arrow has clipped circle at some window sizes.
https://bugs.webkit.org/show_bug.cgi?id=134710
<rdar://problem/17545291>
Reviewed by Simon Fraser.
Transparent layer clipping needs device pixel snapping.
Source/WebCore:
Test: fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
LayoutTests:
* fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position-expected.html: Added.
* fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastlayerswrongclippingsemitransparentlayeronsubpixelpositionexpectedhtml">trunk/LayoutTests/fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastlayerswrongclippingsemitransparentlayeronsubpixelpositionhtml">trunk/LayoutTests/fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (170876 => 170877)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-07-08 04:23:30 UTC (rev 170876)
+++ trunk/LayoutTests/ChangeLog 2014-07-08 04:26:24 UTC (rev 170877)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2014-07-07 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><ins>+ Subpixel rendering: icloud.com password arrow has clipped circle at some window sizes.
+ https://bugs.webkit.org/show_bug.cgi?id=134710
+ <rdar://problem/17545291>
+
+ Reviewed by Simon Fraser.
+
+ Transparent layer clipping needs device pixel snapping.
+
+ * fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position-expected.html: Added.
+ * fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html: Added.
+
+2014-07-07 Zalan Bujtas <zalan@apple.com>
+
</ins><span class="cx"> Subpixel rendering: Inline box decoration rounds to integral.
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=134523
</span><span class="cx"> <rdar://problem/17530298>
</span></span></pre></div>
<a id="trunkLayoutTestsfastlayerswrongclippingsemitransparentlayeronsubpixelpositionexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position-expected.html (0 => 170877)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position-expected.html 2014-07-08 04:26:24 UTC (rev 170877)
</span><span class="lines">@@ -0,0 +1,34 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that semi-transparent layers on subpixel position get clipped properly. Non-retina test only.</title>
+<style>
+ img {
+ opacity: 0.9;
+ position: absolute;
+ border: 1px solid red;
+ width: 10px;
+ height: 10px;
+ }
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ var adjustment = 0;
+ for (i = 0; i < 20; ++i) {
+ for (j = 0; j < 20; ++j) {
+ if (j % 5 == 0 && j != 0)
+ adjustment += 0.5;
+ var e = document.createElement("img");
+ e.style.top = (20 * i) + adjustment + "px";
+ e.style.left = (20 * j) + adjustment + "px";
+ e.src = "broken.jpg";
+ container.appendChild(e);
+ }
+ adjustment += 0.5;
+ }
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastlayerswrongclippingsemitransparentlayeronsubpixelpositionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html (0 => 170877)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html 2014-07-08 04:26:24 UTC (rev 170877)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that semi-transparent layers on subpixel position get clipped properly. Non-retina test only.</title>
+<style>
+ img {
+ opacity: 0.9;
+ position: absolute;
+ border: 1px solid red;
+ width: 10px;
+ height: 10px;
+ }
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ var adjustment = 0;
+ for (i = 0; i < 20; ++i) {
+ for (j = 0; j < 20; ++j) {
+ var e = document.createElement("img");
+ e.style.top = (20 * i) + adjustment + "px";
+ e.style.left = (20 * j) + adjustment + "px";
+ e.src = "broken.jpg";
+ container.appendChild(e);
+ adjustment += 0.1;
+ }
+ }
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170876 => 170877)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-08 04:23:30 UTC (rev 170876)
+++ trunk/Source/WebCore/ChangeLog 2014-07-08 04:26:24 UTC (rev 170877)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-07-07 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: icloud.com password arrow has clipped circle at some window sizes.
+ https://bugs.webkit.org/show_bug.cgi?id=134710
+ <rdar://problem/17545291>
+
+ Reviewed by Simon Fraser.
+
+ Transparent layer clipping needs device pixel snapping.
+
+ Test: fast/layers/wrong-clipping-semi-transparent-layer-on-subpixel-position.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::beginTransparencyLayers):
+
</ins><span class="cx"> 2014-07-07 Benjamin Poulain <benjamin@webkit.org>
</span><span class="cx">
</span><span class="cx"> LinkBuffer should not keep a reference to the MacroAssembler
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (170876 => 170877)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-07-08 04:23:30 UTC (rev 170876)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-07-08 04:26:24 UTC (rev 170877)
</span><span class="lines">@@ -1661,8 +1661,8 @@
</span><span class="cx"> if (paintsWithTransparency(paintBehavior)) {
</span><span class="cx"> m_usedTransparency = true;
</span><span class="cx"> context->save();
</span><del>- LayoutRect clipRect = paintingExtent(*this, rootLayer, paintDirtyRect, paintBehavior);
- context->clip(clipRect);
</del><ins>+ FloatRect pixelSnappedClipRect = pixelSnappedForPainting(paintingExtent(*this, rootLayer, paintDirtyRect, paintBehavior), renderer().document().deviceScaleFactor());
+ context->clip(pixelSnappedClipRect);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_COMPOSITING)
</span><span class="cx"> if (hasBlendMode())
</span><span class="lines">@@ -1678,7 +1678,7 @@
</span><span class="cx">
</span><span class="cx"> #ifdef REVEAL_TRANSPARENCY_LAYERS
</span><span class="cx"> context->setFillColor(Color(0.0f, 0.0f, 0.5f, 0.2f), ColorSpaceDeviceRGB);
</span><del>- context->fillRect(clipRect);
</del><ins>+ context->fillRect(pixelSnappedClipRect);
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>