<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170847] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170847">170847</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-07 10:52:29 -0700 (Mon, 07 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add test to ensure that SVGDocumentExtensions::rebuildElements() doesn't rebuild invalid elements
https://bugs.webkit.org/show_bug.cgi?id=134417
<rdar://problem/17479854>
Reviewed by David Kilzer.
Add a test that implicitly checks that the list of SVG elements to be rebuilt doesn't contain
removed elements. Run this test in DRT with Guard Malloc/MallocScribble (or the platform-
specific equivalent) enabled.
* svg/custom/overwrite-page-that-has-use-elements-expected.txt: Added.
* svg/custom/overwrite-page-that-has-use-elements.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgcustomoverwritepagethathasuseelementsexpectedtxt">trunk/LayoutTests/svg/custom/overwrite-page-that-has-use-elements-expected.txt</a></li>
<li><a href="#trunkLayoutTestssvgcustomoverwritepagethathasuseelementshtml">trunk/LayoutTests/svg/custom/overwrite-page-that-has-use-elements.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (170846 => 170847)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-07-07 17:20:19 UTC (rev 170846)
+++ trunk/LayoutTests/ChangeLog 2014-07-07 17:52:29 UTC (rev 170847)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-07-07 Daniel Bates <dabates@apple.com>
+
+ Add test to ensure that SVGDocumentExtensions::rebuildElements() doesn't rebuild invalid elements
+ https://bugs.webkit.org/show_bug.cgi?id=134417
+ <rdar://problem/17479854>
+
+ Reviewed by David Kilzer.
+
+ Add a test that implicitly checks that the list of SVG elements to be rebuilt doesn't contain
+ removed elements. Run this test in DRT with Guard Malloc/MallocScribble (or the platform-
+ specific equivalent) enabled.
+
+ * svg/custom/overwrite-page-that-has-use-elements-expected.txt: Added.
+ * svg/custom/overwrite-page-that-has-use-elements.html: Added.
+
</ins><span class="cx"> 2014-07-07 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed Mac gardening after r170817.
</span></span></pre></div>
<a id="trunkLayoutTestssvgcustomoverwritepagethathasuseelementsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/custom/overwrite-page-that-has-use-elements-expected.txt (0 => 170847)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/overwrite-page-that-has-use-elements-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/overwrite-page-that-has-use-elements-expected.txt 2014-07-07 17:52:29 UTC (rev 170847)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+PASS, did not crash
</ins></span></pre></div>
<a id="trunkLayoutTestssvgcustomoverwritepagethathasuseelementshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/custom/overwrite-page-that-has-use-elements.html (0 => 170847)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/overwrite-page-that-has-use-elements.html (rev 0)
+++ trunk/LayoutTests/svg/custom/overwrite-page-that-has-use-elements.html 2014-07-07 17:52:29 UTC (rev 170847)
</span><span class="lines">@@ -0,0 +1,52 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script>
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
+</script>
+</head>
+<body>
+ <!-- This tests that we don't crash when overwriting the contents of page that has an SVG tree containing <use> elements
+ with references (i.e. xlink:href). You must run this test in DRT with Guard Malloc/MallocScribble (or the platform-
+ specific equivalent) enabled. -->
+<svg>
+ <defs>
+ <g id="bg1">
+ <use xlink:href="#fill-rgn"/>
+ </g>
+ </defs>
+ <use id="A" xlink:href="#bg1"/>
+ <text id="B" x="0" y="20">FAIL</text>
+</svg>
+<script>
+// Synchronous write; mark <use id="A"> as needing to be rebuilt because <g id="bg1"> is removed from the document.
+document.write("FAIL");
+window.setTimeout(crash, 0);
+
+function crash() {
+ document.designMode = "on";
+ document.execCommand("SelectAll");
+ document.execCommand("FontName", true, "H5"); // Rebuilds targets for SVG nodes.
+
+ // Remove the contents between <use id="A"> and <text id="B"> (inclusively). Notice that these nodes have already been
+ // removed by the synchronous document.write() call above.
+ var range = document.createRange();
+ range.setStartBefore(document.getElementById("A"));
+ range.setEndAfter(document.getElementById("B"));
+ range.deleteContents(); // Rebuilds targets for SVG nodes.
+
+ if (window.GCController)
+ GCController.collect();
+
+ // Crash; rebuilds targets for SVG nodes, including the "element" at the memory location formerly occupied by <use id="A">.
+ document.body.innerHTML = "PASS, did not crash";
+
+ if (window.testRunner)
+ testRunner.notifyDone();
+}
+</script>
+</body>
+</html>
</ins></span></pre>
</div>
</div>
</body>
</html>