<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170858] trunk/Source/WebKit2</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170858">170858</a></dd>
<dt>Author</dt> <dd>enrica@apple.com</dd>
<dt>Date</dt> <dd>2014-07-07 14:42:53 -0700 (Mon, 07 Jul 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION(iOS WK2): arrow keys movements don't work.
https://bugs.webkit.org/show_bug.cgi?id=134561
&lt;rdar://problem/16827629&gt;

Reviewed by Benjamin Poulain.

This change add the implementations for cursor movement selectors.
It also provides a mechanism to ensure that every selection
change in WebKit is reflected in UIKit so that it can update the 
autocorrection data. This way we ensure that the autocorraction state
is consistent even when selection changes are originated by JavaScript.
WebPageProxy::editorStateChanged now notifies the page client when the
selection is about to change as well as when it actually changed.
        
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::editorStateChanged):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::selectionWillChange):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cut:]): Removed incorrect calls to textWillChange and
textDidChange.
(-[WKContentView paste:]):
(-[WKContentView _moveUp:withHistory:]):
(-[WKContentView _moveDown:withHistory:]):
(-[WKContentView _moveLeft:withHistory:]):
(-[WKContentView _moveRight:withHistory:]):
(-[WKContentView _moveToStartOfWord:withHistory:]):
(-[WKContentView _moveToStartOfParagraph:withHistory:]):
(-[WKContentView _moveToStartOfLine:withHistory:]):
(-[WKContentView _moveToStartOfDocument:withHistory:]):
(-[WKContentView _moveToEndOfWord:withHistory:]):
(-[WKContentView _moveToEndOfParagraph:withHistory:]):
(-[WKContentView _moveToEndOfLine:withHistory:]):
(-[WKContentView _moveToEndOfDocument:withHistory:]):
(-[WKContentView _selectionWillChange]):
(-[WKContentView _selectionChanged]):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::notifySelectionWillChange):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPageClienth">trunk/Source/WebKit2/UIProcess/PageClient.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxyh">trunk/Source/WebKit2/UIProcess/WebPageProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosPageClientImplIOSh">trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosPageClientImplIOSmm">trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWKContentViewInteractionh">trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWKContentViewInteractionmm">trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosWebPageProxyIOSmm">trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (170857 => 170858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog        2014-07-07 21:06:15 UTC (rev 170857)
+++ trunk/Source/WebKit2/ChangeLog        2014-07-07 21:42:53 UTC (rev 170858)
</span><span class="lines">@@ -1,3 +1,48 @@
</span><ins>+2014-07-07  Enrica Casucci  &lt;enrica@apple.com&gt;
+
+        REGRESSION(iOS WK2): arrow keys movements don't work.
+        https://bugs.webkit.org/show_bug.cgi?id=134561
+        &lt;rdar://problem/16827629&gt;
+
+        Reviewed by Benjamin Poulain.
+
+        This change add the implementations for cursor movement selectors.
+        It also provides a mechanism to ensure that every selection
+        change in WebKit is reflected in UIKit so that it can update the 
+        autocorrection data. This way we ensure that the autocorraction state
+        is consistent even when selection changes are originated by JavaScript.
+        WebPageProxy::editorStateChanged now notifies the page client when the
+        selection is about to change as well as when it actually changed.
+        
+        * UIProcess/PageClient.h:
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::editorStateChanged):
+        * UIProcess/WebPageProxy.h:
+        * UIProcess/ios/PageClientImplIOS.h:
+        * UIProcess/ios/PageClientImplIOS.mm:
+        (WebKit::PageClientImpl::selectionWillChange):
+        * UIProcess/ios/WKContentViewInteraction.h:
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView cut:]): Removed incorrect calls to textWillChange and
+        textDidChange.
+        (-[WKContentView paste:]):
+        (-[WKContentView _moveUp:withHistory:]):
+        (-[WKContentView _moveDown:withHistory:]):
+        (-[WKContentView _moveLeft:withHistory:]):
+        (-[WKContentView _moveRight:withHistory:]):
+        (-[WKContentView _moveToStartOfWord:withHistory:]):
+        (-[WKContentView _moveToStartOfParagraph:withHistory:]):
+        (-[WKContentView _moveToStartOfLine:withHistory:]):
+        (-[WKContentView _moveToStartOfDocument:withHistory:]):
+        (-[WKContentView _moveToEndOfWord:withHistory:]):
+        (-[WKContentView _moveToEndOfParagraph:withHistory:]):
+        (-[WKContentView _moveToEndOfLine:withHistory:]):
+        (-[WKContentView _moveToEndOfDocument:withHistory:]):
+        (-[WKContentView _selectionWillChange]):
+        (-[WKContentView _selectionChanged]):
+        * UIProcess/ios/WebPageProxyIOS.mm:
+        (WebKit::WebPageProxy::notifySelectionWillChange):
+
</ins><span class="cx"> 2014-07-07  Anders Carlsson  &lt;andersca@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Add SPI for saving and restoring a WKWebView's _WKSessionState
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPageClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/PageClient.h (170857 => 170858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/PageClient.h        2014-07-07 21:06:15 UTC (rev 170857)
+++ trunk/Source/WebKit2/UIProcess/PageClient.h        2014-07-07 21:42:53 UTC (rev 170858)
</span><span class="lines">@@ -259,6 +259,7 @@
</span><span class="cx"> 
</span><span class="cx">     virtual void startAssistingNode(const AssistedNodeInformation&amp;, bool userIsInteracting, bool blurPreviousNode, API::Object* userData) = 0;
</span><span class="cx">     virtual void stopAssistingNode() = 0;
</span><ins>+    virtual void selectionWillChange() = 0;
</ins><span class="cx">     virtual void selectionDidChange() = 0;
</span><span class="cx">     virtual bool interpretKeyEvent(const NativeWebKeyboardEvent&amp;, bool isCharEvent) = 0;
</span><span class="cx">     virtual void positionInformationDidChange(const InteractionInformationAtPosition&amp;) = 0;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (170857 => 170858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp        2014-07-07 21:06:15 UTC (rev 170857)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp        2014-07-07 21:42:53 UTC (rev 170858)
</span><span class="lines">@@ -3410,6 +3410,9 @@
</span><span class="cx">     m_temporarilyClosedComposition = editorState.shouldIgnoreCompositionSelectionChange &amp;&amp; (m_temporarilyClosedComposition || m_editorState.hasComposition) &amp;&amp; !editorState.hasComposition;
</span><span class="cx"> #endif
</span><span class="cx"> 
</span><ins>+#if PLATFORM(IOS)
+    notifySelectionWillChange();
+#endif
</ins><span class="cx">     m_editorState = editorState;
</span><span class="cx"> 
</span><span class="cx"> #if PLATFORM(COCOA)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (170857 => 170858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h        2014-07-07 21:06:15 UTC (rev 170857)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h        2014-07-07 21:42:53 UTC (rev 170858)
</span><span class="lines">@@ -1222,7 +1222,7 @@
</span><span class="cx">     void enableInspectorNodeSearch();
</span><span class="cx">     void disableInspectorNodeSearch();
</span><span class="cx"> #endif
</span><del>-
</del><ins>+    void notifySelectionWillChange();
</ins><span class="cx">     void notifyRevealedSelection();
</span><span class="cx"> #endif // PLATFORM(IOS)
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosPageClientImplIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h (170857 => 170858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h        2014-07-07 21:06:15 UTC (rev 170857)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h        2014-07-07 21:42:53 UTC (rev 170858)
</span><span class="lines">@@ -119,6 +119,7 @@
</span><span class="cx"> 
</span><span class="cx">     virtual void startAssistingNode(const AssistedNodeInformation&amp;, bool userIsInteracting, bool blurPreviousNode, API::Object* userData) override;
</span><span class="cx">     virtual void stopAssistingNode() override;
</span><ins>+    virtual void selectionWillChange() override;
</ins><span class="cx">     virtual void selectionDidChange() override;
</span><span class="cx">     virtual bool interpretKeyEvent(const NativeWebKeyboardEvent&amp;, bool isCharEvent) override;
</span><span class="cx">     virtual void positionInformationDidChange(const InteractionInformationAtPosition&amp;) override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosPageClientImplIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm (170857 => 170858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm        2014-07-07 21:06:15 UTC (rev 170857)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm        2014-07-07 21:42:53 UTC (rev 170858)
</span><span class="lines">@@ -350,6 +350,11 @@
</span><span class="cx">     notImplemented();
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void PageClientImpl::selectionWillChange()
+{
+    [m_contentView _selectionWillChange];
+}
+
</ins><span class="cx"> void PageClientImpl::selectionDidChange()
</span><span class="cx"> {
</span><span class="cx">     [m_contentView _selectionChanged];
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWKContentViewInteractionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (170857 => 170858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h        2014-07-07 21:06:15 UTC (rev 170857)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h        2014-07-07 21:42:53 UTC (rev 170858)
</span><span class="lines">@@ -164,6 +164,7 @@
</span><span class="cx"> 
</span><span class="cx"> - (void)_startAssistingNode:(const WebKit::AssistedNodeInformation&amp;)information userIsInteracting:(BOOL)userIsInteracting blurPreviousNode:(BOOL)blurPreviousNode userObject:(NSObject &lt;NSSecureCoding&gt; *)userObject;
</span><span class="cx"> - (void)_stopAssistingNode;
</span><ins>+- (void)_selectionWillChange;
</ins><span class="cx"> - (void)_selectionChanged;
</span><span class="cx"> - (void)_updateChangedSelection;
</span><span class="cx"> - (BOOL)_interpretKeyEvent:(WebIOSEvent *)theEvent isCharEvent:(BOOL)isCharEvent;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWKContentViewInteractionmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (170857 => 170858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm        2014-07-07 21:06:15 UTC (rev 170857)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm        2014-07-07 21:42:53 UTC (rev 170858)
</span><span class="lines">@@ -1289,20 +1289,12 @@
</span><span class="cx"> 
</span><span class="cx"> - (void)cut:(id)sender
</span><span class="cx"> {
</span><del>-    [self.inputDelegate textWillChange:self];
-
</del><span class="cx">     _page-&gt;executeEditCommand(ASCIILiteral(&quot;cut&quot;));
</span><del>-
-    [self.inputDelegate textDidChange:self];
</del><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> - (void)paste:(id)sender
</span><span class="cx"> {
</span><del>-    [self.inputDelegate textWillChange:self];
-    
</del><span class="cx">     _page-&gt;executeEditCommand(ASCIILiteral(&quot;paste&quot;));
</span><del>-    
-    [self.inputDelegate textDidChange:self];
</del><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> - (void)select:(id)sender
</span><span class="lines">@@ -2218,6 +2210,78 @@
</span><span class="cx">     return NO;
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+- (UITextInputArrowKeyHistory *)_moveUp:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveUp&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveDown:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveDown&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveLeft:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveLeft&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveRight:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveRight&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveToStartOfWord:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveWordBackward&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveToStartOfParagraph:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveToStartOfParagraph&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveToStartOfLine:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveToStartOfLine&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveToStartOfDocument:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveToBeginningOfDocument&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveToEndOfWord:(BOOL)extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveWordForward&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveToEndOfParagraph:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveToEndOfParagraph&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveToEndOfLine:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveToEndOfLine&quot;));
+    return nil;
+}
+
+- (UITextInputArrowKeyHistory *)_moveToEndOfDocument:(BOOL) extending withHistory:(UITextInputArrowKeyHistory *)history
+{
+    _page-&gt;executeEditCommand(ASCIILiteral(&quot;moveToEndOfDocument&quot;));
+    return nil;
+}
+
</ins><span class="cx"> // Sets a buffer to make room for autocorrection views
</span><span class="cx"> - (void)setBottomBufferHeight:(CGFloat)bottomBuffer
</span><span class="cx"> {
</span><span class="lines">@@ -2425,6 +2489,13 @@
</span><span class="cx">     [_webSelectionAssistant resignedFirstResponder];
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+- (void)_selectionWillChange
+{
+    if (_usingGestureForSelection)
+        return;
+    [self beginSelectionChange];
+}
+
</ins><span class="cx"> - (void)_selectionChanged
</span><span class="cx"> {
</span><span class="cx">     _selectionNeedsUpdate = YES;
</span><span class="lines">@@ -2432,6 +2503,8 @@
</span><span class="cx">     // to wait to paint the selection.
</span><span class="cx">     if (_usingGestureForSelection)
</span><span class="cx">         [self _updateChangedSelection];
</span><ins>+    else
+        [self endSelectionChange];
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> - (void)selectWordForReplacement
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosWebPageProxyIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm (170857 => 170858)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm        2014-07-07 21:06:15 UTC (rev 170857)
+++ trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm        2014-07-07 21:42:53 UTC (rev 170858)
</span><span class="lines">@@ -466,6 +466,11 @@
</span><span class="cx">     m_process-&gt;send(Messages::WebPage::ApplicationDidBecomeActive(), m_pageID);
</span><span class="cx"> }
</span><span class="cx"> 
</span><ins>+void WebPageProxy::notifySelectionWillChange()
+{
+    m_pageClient.selectionWillChange();
+}
+
</ins><span class="cx"> void WebPageProxy::notifyRevealedSelection()
</span><span class="cx"> {
</span><span class="cx">     m_pageClient.selectionDidChange();
</span></span></pre>
</div>
</div>

</body>
</html>