<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170826] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170826">170826</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-05 10:56:58 -0700 (Sat, 05 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/170825">r170825</a>.
https://bugs.webkit.org/show_bug.cgi?id=134653
broke debug builds (Requested by kling on #webkit).
Reverted changeset:
"Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS
macro and generateTypeHelpers"
https://bugs.webkit.org/show_bug.cgi?id=134647
http://trac.webkit.org/changeset/170825</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoremathmlMathMLElementh">trunk/Source/WebCore/mathml/MathMLElement.h</a></li>
<li><a href="#trunkSourceWebCoremathmlMathMLMencloseElementh">trunk/Source/WebCore/mathml/MathMLMencloseElement.h</a></li>
<li><a href="#trunkSourceWebCoremathmlmathtagsin">trunk/Source/WebCore/mathml/mathtags.in</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170825 => 170826)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-05 17:36:03 UTC (rev 170825)
+++ trunk/Source/WebCore/ChangeLog 2014-07-05 17:56:58 UTC (rev 170826)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-07-05 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r170825.
+ https://bugs.webkit.org/show_bug.cgi?id=134653
+
+ broke debug builds (Requested by kling on #webkit).
+
+ Reverted changeset:
+
+ "Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS
+ macro and generateTypeHelpers"
+ https://bugs.webkit.org/show_bug.cgi?id=134647
+ http://trac.webkit.org/changeset/170825
+
</ins><span class="cx"> 2014-07-05 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeHelpers
</span></span></pre></div>
<a id="trunkSourceWebCoremathmlMathMLElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/mathml/MathMLElement.h (170825 => 170826)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/MathMLElement.h 2014-07-05 17:36:03 UTC (rev 170825)
+++ trunk/Source/WebCore/mathml/MathMLElement.h 2014-07-05 17:56:58 UTC (rev 170826)
</span><span class="lines">@@ -73,6 +73,8 @@
</span><span class="cx"> virtual void updateSelectedChild() { }
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+void isMathMLElement(const MathMLElement&); // Catch unnecessary runtime check of type known at compile time.
+inline bool isMathMLElement(const Node& node) { return node.isMathMLElement(); }
</ins><span class="cx"> NODE_TYPE_CASTS(MathMLElement)
</span><span class="cx">
</span><span class="cx"> inline bool Node::hasTagName(const MathMLQualifiedName& name) const
</span><span class="lines">@@ -80,10 +82,8 @@
</span><span class="cx"> return isMathMLElement() && toMathMLElement(*this).hasTagName(name);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-} // namespace WebCore
</del><ins>+}
</ins><span class="cx">
</span><del>-#include "MathMLElementTypeHelpers.h"
-
</del><span class="cx"> #endif // ENABLE(MATHML)
</span><span class="cx">
</span><span class="cx"> #endif // MathMLElement_h
</span></span></pre></div>
<a id="trunkSourceWebCoremathmlMathMLMencloseElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/mathml/MathMLMencloseElement.h (170825 => 170826)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/MathMLMencloseElement.h 2014-07-05 17:36:03 UTC (rev 170825)
+++ trunk/Source/WebCore/mathml/MathMLMencloseElement.h 2014-07-05 17:56:58 UTC (rev 170826)
</span><span class="lines">@@ -50,7 +50,11 @@
</span><span class="cx"> bool m_isRadicalValue;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-NODE_TYPE_CASTS(MathMLMencloseElement)
</del><ins>+inline MathMLMencloseElement* toMathMLMencloseElement(Node* node)
+{
+ ASSERT_WITH_SECURITY_IMPLICATION(!node || (node->isElementNode() && toElement(node)->hasTagName(MathMLNames::mencloseTag)));
+ return static_cast<MathMLMencloseElement*>(node);
+}
</ins><span class="cx">
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoremathmlmathtagsin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/mathml/mathtags.in (170825 => 170826)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/mathml/mathtags.in 2014-07-05 17:36:03 UTC (rev 170825)
+++ trunk/Source/WebCore/mathml/mathtags.in 2014-07-05 17:56:58 UTC (rev 170826)
</span><span class="lines">@@ -31,7 +31,7 @@
</span><span class="cx"> mtd interfaceName=MathMLElement
</span><span class="cx"> mmultiscripts interfaceName=MathMLInlineContainerElement
</span><span class="cx"> mprescripts interfaceName=MathMLInlineContainerElement
</span><del>-menclose interfaceName=MathMLMencloseElement, generateTypeHelpers
</del><ins>+menclose interfaceName=MathMLMencloseElement
</ins><span class="cx"> none interfaceName=MathMLInlineContainerElement
</span><span class="cx"> semantics interfaceName=MathMLSelectElement
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>