<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170817] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170817">170817</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-07-04 20:03:01 -0700 (Fri, 04 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: ebay.com rotating billboard on the main page has cut off buttons.
https://bugs.webkit.org/show_bug.cgi?id=134636
<rdar://problem/17529112>
Reviewed by Darin Adler.
Missing pixel snapping when clipping the transparency layer for BackgroundBleedUseTransparencyLayer.
Clipping needs to take the same snapping strategy as the rest of the painting code.
Source/WebCore:
Test: fast/borders/border-radius-on-subpixel-position-non-hidpi.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
LayoutTests:
* fast/borders/border-radius-on-subpixel-position-non-hidpi-expected.html: Added.
* fast/borders/border-radius-on-subpixel-position-non-hidpi.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastbordersborderradiusonsubpixelpositionnonhidpiexpectedhtml">trunk/LayoutTests/fast/borders/border-radius-on-subpixel-position-non-hidpi-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastbordersborderradiusonsubpixelpositionnonhidpihtml">trunk/LayoutTests/fast/borders/border-radius-on-subpixel-position-non-hidpi.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (170816 => 170817)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-07-05 01:29:55 UTC (rev 170816)
+++ trunk/LayoutTests/ChangeLog 2014-07-05 03:03:01 UTC (rev 170817)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-07-04 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: ebay.com rotating billboard on the main page has cut off buttons.
+ https://bugs.webkit.org/show_bug.cgi?id=134636
+ <rdar://problem/17529112>
+
+ Reviewed by Darin Adler.
+
+ Missing pixel snapping when clipping the transparency layer for BackgroundBleedUseTransparencyLayer.
+ Clipping needs to take the same snapping strategy as the rest of the painting code.
+
+ * fast/borders/border-radius-on-subpixel-position-non-hidpi-expected.html: Added.
+ * fast/borders/border-radius-on-subpixel-position-non-hidpi.html: Added.
+
</ins><span class="cx"> 2014-07-04 Julien Quint <pom@graougraou.com>
</span><span class="cx">
</span><span class="cx"> input type=range element should only fire change events after committing a value
</span></span></pre></div>
<a id="trunkLayoutTestsfastbordersborderradiusonsubpixelpositionnonhidpiexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/borders/border-radius-on-subpixel-position-non-hidpi-expected.html (0 => 170817)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/borders/border-radius-on-subpixel-position-non-hidpi-expected.html (rev 0)
+++ trunk/LayoutTests/fast/borders/border-radius-on-subpixel-position-non-hidpi-expected.html 2014-07-05 03:03:01 UTC (rev 170817)
</span><span class="lines">@@ -0,0 +1,38 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that border with radius is painted properly when the element is on a subpixel position.</title>
+<style>
+ div {
+ position: absolute;
+ width: 10px;
+ height: 10px;
+
+ border: 1px solid rgba(0, 0, 0, 0.1);
+ background-color: white;
+ border-radius: 10px;
+ }
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ topAdjustment = 0;
+ leftAdjustment = 0;
+ for (i = 0; i < 30; ++i) {
+ for (j = 0; j < 30; ++j) {
+ if ((j % 5 == 0) && (j % 10) != 0) {
+ topAdjustment += 1;
+ leftAdjustment += 1;
+ }
+ var e = document.createElement("div");
+ e.style.top = (15 * i) + topAdjustment + "px";
+ e.style.left = (15 * j) + leftAdjustment + "px";
+
+ container.appendChild(e);
+ }
+ }
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastbordersborderradiusonsubpixelpositionnonhidpihtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/borders/border-radius-on-subpixel-position-non-hidpi.html (0 => 170817)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/borders/border-radius-on-subpixel-position-non-hidpi.html (rev 0)
+++ trunk/LayoutTests/fast/borders/border-radius-on-subpixel-position-non-hidpi.html 2014-07-05 03:03:01 UTC (rev 170817)
</span><span class="lines">@@ -0,0 +1,36 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that border with radius is painted properly when the element is on a subpixel position.</title>
+<style>
+ div {
+ position: absolute;
+ width: 10px;
+ height: 10px;
+
+ border: 1px solid rgba(0, 0, 0, 0.1);
+ background-color: white;
+ border-radius: 10px;
+ }
+</style>
+</head>
+<body>
+<p id="container"></p>
+<script>
+ var container = document.getElementById("container");
+ topAdjustment = 0;
+ leftAdjustment = 0;
+ for (i = 0; i < 30; ++i) {
+ for (j = 0; j < 30; ++j) {
+ var e = document.createElement("div");
+ e.style.top = (15 * i) + topAdjustment + "px";
+ e.style.left = (15 * j) + leftAdjustment + "px";
+
+ container.appendChild(e);
+ topAdjustment += 0.1;
+ leftAdjustment += 0.1;
+ }
+ }
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170816 => 170817)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-05 01:29:55 UTC (rev 170816)
+++ trunk/Source/WebCore/ChangeLog 2014-07-05 03:03:01 UTC (rev 170817)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-07-04 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: ebay.com rotating billboard on the main page has cut off buttons.
+ https://bugs.webkit.org/show_bug.cgi?id=134636
+ <rdar://problem/17529112>
+
+ Reviewed by Darin Adler.
+
+ Missing pixel snapping when clipping the transparency layer for BackgroundBleedUseTransparencyLayer.
+ Clipping needs to take the same snapping strategy as the rest of the painting code.
+
+ Test: fast/borders/border-radius-on-subpixel-position-non-hidpi.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::paintBoxDecorations):
+
</ins><span class="cx"> 2014-05-10 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> QualifiedName should use RefPtr<QualifiedNameImpl> internally.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (170816 => 170817)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-07-05 01:29:55 UTC (rev 170816)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-07-05 03:03:01 UTC (rev 170817)
</span><span class="lines">@@ -1256,9 +1256,8 @@
</span><span class="cx"> // To avoid the background color bleeding out behind the border, we'll render background and border
</span><span class="cx"> // into a transparency layer, and then clip that in one go (which requires setting up the clip before
</span><span class="cx"> // beginning the layer).
</span><del>- RoundedRect border = style().getRoundedBorderFor(paintRect);
</del><span class="cx"> stateSaver.save();
</span><del>- paintInfo.context->clipRoundedRect(FloatRoundedRect(border));
</del><ins>+ paintInfo.context->clipRoundedRect(style().getRoundedBorderFor(paintRect).pixelSnappedRoundedRectForPainting(document().deviceScaleFactor()));
</ins><span class="cx"> paintInfo.context->beginTransparencyLayer(1);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>