<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170820] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170820">170820</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-04 21:28:02 -0700 (Fri, 04 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
https://bugs.webkit.org/show_bug.cgi?id=134485
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-07-04
Reviewed by Gyuyoung Kim.
Use script_execute_callback to get selected/highlighted text and show in search bar.
* MiniBrowser/efl/main.c:
(script_execute_callback):
(on_key_down):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsMiniBrowsereflmainc">trunk/Tools/MiniBrowser/efl/main.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (170819 => 170820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-07-05 04:13:12 UTC (rev 170819)
+++ trunk/Tools/ChangeLog 2014-07-05 04:28:02 UTC (rev 170820)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-07-04 Shivakumar JM <shiva.jm@samsung.com>
+
+ [EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
+ https://bugs.webkit.org/show_bug.cgi?id=134485
+
+ Reviewed by Gyuyoung Kim.
+
+ Use script_execute_callback to get selected/highlighted text and show in search bar.
+
+ * MiniBrowser/efl/main.c:
+ (script_execute_callback):
+ (on_key_down):
+
</ins><span class="cx"> 2014-07-04 Dan Bernstein <mitz@apple.com>
</span><span class="cx">
</span><span class="cx"> Build fix after r170811.
</span></span></pre></div>
<a id="trunkToolsMiniBrowsereflmainc"></a>
<div class="modfile"><h4>Modified: trunk/Tools/MiniBrowser/efl/main.c (170819 => 170820)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/MiniBrowser/efl/main.c 2014-07-05 04:13:12 UTC (rev 170819)
+++ trunk/Tools/MiniBrowser/efl/main.c 2014-07-05 04:28:02 UTC (rev 170820)
</span><span class="lines">@@ -426,6 +426,22 @@
</span><span class="cx"> eina_stringshare_del(fileName);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static void
+script_execute_callback(Evas_Object *ewk_view, const char *return_value, void *user_data)
+{
+ Browser_Window *window = (Browser_Window *)user_data;
+
+ Eina_Strbuf *text_buffer = eina_strbuf_new();
+
+ if (return_value) {
+ eina_strbuf_append(text_buffer, return_value);
+ info("selected text is: %s", eina_strbuf_string_get(text_buffer));
+ elm_entry_entry_set(window->search.search_field, eina_strbuf_string_get(text_buffer));
+ }
+ eina_strbuf_free(text_buffer);
+ search_box_show(window);
+}
+
</ins><span class="cx"> static void
</span><span class="cx"> on_key_down(void *user_data, Evas *e, Evas_Object *ewk_view, void *event_info)
</span><span class="cx"> {
</span><span class="lines">@@ -484,7 +500,8 @@
</span><span class="cx"> ewk_view_inspector_show(ewk_view);
</span><span class="cx"> } else if (!strcmp(ev->key, "f") && ctrlPressed) {
</span><span class="cx"> info("Show Search Box (Ctrl+f) was pressed.");
</span><del>- search_box_show(window);
</del><ins>+ const char get_data_script[] = "window.getSelection().toString();";
+ ewk_view_script_execute(ewk_view, get_data_script, script_execute_callback, (void*)(window));
</ins><span class="cx"> } else if (!strcmp(ev->key, "Escape")) {
</span><span class="cx"> if (evas_object_visible_get(window->search.search_bar))
</span><span class="cx"> search_box_hide(window);
</span></span></pre>
</div>
</div>
</body>
</html>