<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170635] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170635">170635</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2014-07-01 04:32:36 -0700 (Tue, 01 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[WK2] IPC messages' arguments() method returns const std::tuple<> copies
https://bugs.webkit.org/show_bug.cgi?id=131975
Reviewed by Darin Adler.
The arguments() method of the different IPC message objects should return a const reference
to the std::tuple<> containing the arguments, instead of a const value. This avoids copying
the std::tuple<> every time the arguments are encoded, and works best with the
ArgumentEncoder::encode<std::tuple<...>>(const std::tuple<...>&) template instantiation.
The unit test baselines are updated accordingly.
* Scripts/webkit2/LegacyMessages-expected.h:
(Messages::WebPage::LoadURL::arguments):
(Messages::WebPage::LoadSomething::arguments):
(Messages::WebPage::TouchEvent::arguments):
(Messages::WebPage::AddEvent::arguments):
(Messages::WebPage::LoadSomethingElse::arguments):
(Messages::WebPage::DidReceivePolicyDecision::arguments):
(Messages::WebPage::Close::arguments):
(Messages::WebPage::PreferencesDidChange::arguments):
(Messages::WebPage::SendDoubleAndFloat::arguments):
(Messages::WebPage::SendInts::arguments):
(Messages::WebPage::CreatePlugin::arguments):
(Messages::WebPage::RunJavaScriptAlert::arguments):
(Messages::WebPage::GetPlugins::arguments):
(Messages::WebPage::GetPluginProcessConnection::arguments):
(Messages::WebPage::TestMultipleAttributes::arguments):
(Messages::WebPage::TestParameterAttributes::arguments):
(Messages::WebPage::TemplateTest::arguments):
(Messages::WebPage::SetVideoLayerID::arguments):
(Messages::WebPage::DidCreateWebProcessConnection::arguments):
(Messages::WebPage::InterpretKeyEvent::arguments):
(Messages::WebPage::DeprecatedOperation::arguments):
(Messages::WebPage::ExperimentalOperation::arguments):
* Scripts/webkit2/Messages-expected.h:
(Messages::WebPage::LoadURL::arguments):
(Messages::WebPage::LoadSomething::arguments):
(Messages::WebPage::TouchEvent::arguments):
(Messages::WebPage::AddEvent::arguments):
(Messages::WebPage::LoadSomethingElse::arguments):
(Messages::WebPage::DidReceivePolicyDecision::arguments):
(Messages::WebPage::Close::arguments):
(Messages::WebPage::PreferencesDidChange::arguments):
(Messages::WebPage::SendDoubleAndFloat::arguments):
(Messages::WebPage::SendInts::arguments):
(Messages::WebPage::CreatePlugin::arguments):
(Messages::WebPage::RunJavaScriptAlert::arguments):
(Messages::WebPage::GetPlugins::arguments):
(Messages::WebPage::GetPluginProcessConnection::arguments):
(Messages::WebPage::TestMultipleAttributes::arguments):
(Messages::WebPage::TestParameterAttributes::arguments):
(Messages::WebPage::TemplateTest::arguments):
(Messages::WebPage::SetVideoLayerID::arguments):
(Messages::WebPage::DidCreateWebProcessConnection::arguments):
(Messages::WebPage::InterpretKeyEvent::arguments):
(Messages::WebPage::DeprecatedOperation::arguments):
(Messages::WebPage::ExperimentalOperation::arguments):
* Scripts/webkit2/MessagesSuperclass-expected.h:
(Messages::WebPage::LoadURL::arguments):
* Scripts/webkit2/messages.py:
(message_to_struct_declaration):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2Scriptswebkit2LegacyMessagesexpectedh">trunk/Source/WebKit2/Scripts/webkit2/LegacyMessages-expected.h</a></li>
<li><a href="#trunkSourceWebKit2Scriptswebkit2Messagesexpectedh">trunk/Source/WebKit2/Scripts/webkit2/Messages-expected.h</a></li>
<li><a href="#trunkSourceWebKit2Scriptswebkit2MessagesSuperclassexpectedh">trunk/Source/WebKit2/Scripts/webkit2/MessagesSuperclass-expected.h</a></li>
<li><a href="#trunkSourceWebKit2Scriptswebkit2messagespy">trunk/Source/WebKit2/Scripts/webkit2/messages.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (170634 => 170635)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-07-01 11:29:24 UTC (rev 170634)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-01 11:32:36 UTC (rev 170635)
</span><span class="lines">@@ -1,3 +1,68 @@
</span><ins>+2014-07-01 Zan Dobersek <zdobersek@igalia.com>
+
+ [WK2] IPC messages' arguments() method returns const std::tuple<> copies
+ https://bugs.webkit.org/show_bug.cgi?id=131975
+
+ Reviewed by Darin Adler.
+
+ The arguments() method of the different IPC message objects should return a const reference
+ to the std::tuple<> containing the arguments, instead of a const value. This avoids copying
+ the std::tuple<> every time the arguments are encoded, and works best with the
+ ArgumentEncoder::encode<std::tuple<...>>(const std::tuple<...>&) template instantiation.
+
+ The unit test baselines are updated accordingly.
+
+ * Scripts/webkit2/LegacyMessages-expected.h:
+ (Messages::WebPage::LoadURL::arguments):
+ (Messages::WebPage::LoadSomething::arguments):
+ (Messages::WebPage::TouchEvent::arguments):
+ (Messages::WebPage::AddEvent::arguments):
+ (Messages::WebPage::LoadSomethingElse::arguments):
+ (Messages::WebPage::DidReceivePolicyDecision::arguments):
+ (Messages::WebPage::Close::arguments):
+ (Messages::WebPage::PreferencesDidChange::arguments):
+ (Messages::WebPage::SendDoubleAndFloat::arguments):
+ (Messages::WebPage::SendInts::arguments):
+ (Messages::WebPage::CreatePlugin::arguments):
+ (Messages::WebPage::RunJavaScriptAlert::arguments):
+ (Messages::WebPage::GetPlugins::arguments):
+ (Messages::WebPage::GetPluginProcessConnection::arguments):
+ (Messages::WebPage::TestMultipleAttributes::arguments):
+ (Messages::WebPage::TestParameterAttributes::arguments):
+ (Messages::WebPage::TemplateTest::arguments):
+ (Messages::WebPage::SetVideoLayerID::arguments):
+ (Messages::WebPage::DidCreateWebProcessConnection::arguments):
+ (Messages::WebPage::InterpretKeyEvent::arguments):
+ (Messages::WebPage::DeprecatedOperation::arguments):
+ (Messages::WebPage::ExperimentalOperation::arguments):
+ * Scripts/webkit2/Messages-expected.h:
+ (Messages::WebPage::LoadURL::arguments):
+ (Messages::WebPage::LoadSomething::arguments):
+ (Messages::WebPage::TouchEvent::arguments):
+ (Messages::WebPage::AddEvent::arguments):
+ (Messages::WebPage::LoadSomethingElse::arguments):
+ (Messages::WebPage::DidReceivePolicyDecision::arguments):
+ (Messages::WebPage::Close::arguments):
+ (Messages::WebPage::PreferencesDidChange::arguments):
+ (Messages::WebPage::SendDoubleAndFloat::arguments):
+ (Messages::WebPage::SendInts::arguments):
+ (Messages::WebPage::CreatePlugin::arguments):
+ (Messages::WebPage::RunJavaScriptAlert::arguments):
+ (Messages::WebPage::GetPlugins::arguments):
+ (Messages::WebPage::GetPluginProcessConnection::arguments):
+ (Messages::WebPage::TestMultipleAttributes::arguments):
+ (Messages::WebPage::TestParameterAttributes::arguments):
+ (Messages::WebPage::TemplateTest::arguments):
+ (Messages::WebPage::SetVideoLayerID::arguments):
+ (Messages::WebPage::DidCreateWebProcessConnection::arguments):
+ (Messages::WebPage::InterpretKeyEvent::arguments):
+ (Messages::WebPage::DeprecatedOperation::arguments):
+ (Messages::WebPage::ExperimentalOperation::arguments):
+ * Scripts/webkit2/MessagesSuperclass-expected.h:
+ (Messages::WebPage::LoadURL::arguments):
+ * Scripts/webkit2/messages.py:
+ (message_to_struct_declaration):
+
</ins><span class="cx"> 2014-07-01 Evan Nemerson <evan@nemerson.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Annotations for WebResource.get_data produce wrong signature in Vala binding
</span></span></pre></div>
<a id="trunkSourceWebKit2Scriptswebkit2LegacyMessagesexpectedh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Scripts/webkit2/LegacyMessages-expected.h (170634 => 170635)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Scripts/webkit2/LegacyMessages-expected.h 2014-07-01 11:29:24 UTC (rev 170634)
+++ trunk/Source/WebKit2/Scripts/webkit2/LegacyMessages-expected.h 2014-07-01 11:32:36 UTC (rev 170635)
</span><span class="lines">@@ -77,7 +77,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const String&> arguments() const
</del><ins>+ const std::tuple<const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -100,7 +100,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const String&> arguments() const
</del><ins>+ const std::tuple<const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const WebKit::WebTouchEvent&> arguments() const
</del><ins>+ const std::tuple<const WebKit::WebTouchEvent&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -148,7 +148,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const WebKit::WebTouchEvent&> arguments() const
</del><ins>+ const std::tuple<const WebKit::WebTouchEvent&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -172,7 +172,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const String&> arguments() const
</del><ins>+ const std::tuple<const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -195,7 +195,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint64_t, uint64_t, uint32_t> arguments() const
</del><ins>+ const std::tuple<uint64_t, uint64_t, uint32_t>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -212,7 +212,7 @@
</span><span class="cx"> static IPC::StringReference name() { return IPC::StringReference("Close"); }
</span><span class="cx"> static const bool isSync = false;
</span><span class="cx">
</span><del>- const std::tuple<> arguments() const
</del><ins>+ const std::tuple<>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -234,7 +234,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const WebKit::WebPreferencesStore&> arguments() const
</del><ins>+ const std::tuple<const WebKit::WebPreferencesStore&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -256,7 +256,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<double, float> arguments() const
</del><ins>+ const std::tuple<double, float>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -278,7 +278,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const Vector<uint64_t>&, const Vector<Vector<uint64_t>>&> arguments() const
</del><ins>+ const std::tuple<const Vector<uint64_t>&, const Vector<Vector<uint64_t>>&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -301,7 +301,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint64_t, const WebKit::Plugin::Parameters&> arguments() const
</del><ins>+ const std::tuple<uint64_t, const WebKit::Plugin::Parameters&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -324,7 +324,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint64_t, const String&> arguments() const
</del><ins>+ const std::tuple<uint64_t, const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -347,7 +347,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<bool> arguments() const
</del><ins>+ const std::tuple<bool>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -381,7 +381,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const String&> arguments() const
</del><ins>+ const std::tuple<const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -410,7 +410,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> typedef IPC::Arguments<> Reply;
</span><del>- const std::tuple<> arguments() const
</del><ins>+ const std::tuple<>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -432,7 +432,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint64_t, double, double> arguments() const
</del><ins>+ const std::tuple<uint64_t, double, double>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -454,7 +454,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const HashMap<String, std::pair<String, uint64_t>>&> arguments() const
</del><ins>+ const std::tuple<const HashMap<String, std::pair<String, uint64_t>>&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -476,7 +476,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const WebCore::GraphicsLayer::PlatformLayerID&> arguments() const
</del><ins>+ const std::tuple<const WebCore::GraphicsLayer::PlatformLayerID&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -499,7 +499,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const IPC::MachPort&> arguments() const
</del><ins>+ const std::tuple<const IPC::MachPort&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -524,7 +524,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint32_t> arguments() const
</del><ins>+ const std::tuple<uint32_t>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -548,7 +548,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const IPC::DummyType&> arguments() const
</del><ins>+ const std::tuple<const IPC::DummyType&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -572,7 +572,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const IPC::DummyType&> arguments() const
</del><ins>+ const std::tuple<const IPC::DummyType&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2Scriptswebkit2Messagesexpectedh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Scripts/webkit2/Messages-expected.h (170634 => 170635)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Scripts/webkit2/Messages-expected.h 2014-07-01 11:29:24 UTC (rev 170634)
+++ trunk/Source/WebKit2/Scripts/webkit2/Messages-expected.h 2014-07-01 11:32:36 UTC (rev 170635)
</span><span class="lines">@@ -77,7 +77,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const String&> arguments() const
</del><ins>+ const std::tuple<const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -100,7 +100,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const String&> arguments() const
</del><ins>+ const std::tuple<const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const WebKit::WebTouchEvent&> arguments() const
</del><ins>+ const std::tuple<const WebKit::WebTouchEvent&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -148,7 +148,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const WebKit::WebTouchEvent&> arguments() const
</del><ins>+ const std::tuple<const WebKit::WebTouchEvent&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -172,7 +172,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const String&> arguments() const
</del><ins>+ const std::tuple<const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -195,7 +195,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint64_t, uint64_t, uint32_t> arguments() const
</del><ins>+ const std::tuple<uint64_t, uint64_t, uint32_t>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -212,7 +212,7 @@
</span><span class="cx"> static IPC::StringReference name() { return IPC::StringReference("Close"); }
</span><span class="cx"> static const bool isSync = false;
</span><span class="cx">
</span><del>- const std::tuple<> arguments() const
</del><ins>+ const std::tuple<>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -234,7 +234,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const WebKit::WebPreferencesStore&> arguments() const
</del><ins>+ const std::tuple<const WebKit::WebPreferencesStore&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -256,7 +256,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<double, float> arguments() const
</del><ins>+ const std::tuple<double, float>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -278,7 +278,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const Vector<uint64_t>&, const Vector<Vector<uint64_t>>&> arguments() const
</del><ins>+ const std::tuple<const Vector<uint64_t>&, const Vector<Vector<uint64_t>>&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -301,7 +301,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint64_t, const WebKit::Plugin::Parameters&> arguments() const
</del><ins>+ const std::tuple<uint64_t, const WebKit::Plugin::Parameters&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -324,7 +324,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint64_t, const String&> arguments() const
</del><ins>+ const std::tuple<uint64_t, const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -347,7 +347,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<bool> arguments() const
</del><ins>+ const std::tuple<bool>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -381,7 +381,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const String&> arguments() const
</del><ins>+ const std::tuple<const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -410,7 +410,7 @@
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> typedef IPC::Arguments<> Reply;
</span><del>- const std::tuple<> arguments() const
</del><ins>+ const std::tuple<>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -432,7 +432,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint64_t, double, double> arguments() const
</del><ins>+ const std::tuple<uint64_t, double, double>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -454,7 +454,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const HashMap<String, std::pair<String, uint64_t>>&> arguments() const
</del><ins>+ const std::tuple<const HashMap<String, std::pair<String, uint64_t>>&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -476,7 +476,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const WebCore::GraphicsLayer::PlatformLayerID&> arguments() const
</del><ins>+ const std::tuple<const WebCore::GraphicsLayer::PlatformLayerID&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -499,7 +499,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const IPC::MachPort&> arguments() const
</del><ins>+ const std::tuple<const IPC::MachPort&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -524,7 +524,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<uint32_t> arguments() const
</del><ins>+ const std::tuple<uint32_t>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -548,7 +548,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const IPC::DummyType&> arguments() const
</del><ins>+ const std::tuple<const IPC::DummyType&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span><span class="lines">@@ -572,7 +572,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const IPC::DummyType&> arguments() const
</del><ins>+ const std::tuple<const IPC::DummyType&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2Scriptswebkit2MessagesSuperclassexpectedh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Scripts/webkit2/MessagesSuperclass-expected.h (170634 => 170635)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Scripts/webkit2/MessagesSuperclass-expected.h 2014-07-01 11:29:24 UTC (rev 170634)
+++ trunk/Source/WebKit2/Scripts/webkit2/MessagesSuperclass-expected.h 2014-07-01 11:32:36 UTC (rev 170635)
</span><span class="lines">@@ -54,7 +54,7 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>- const std::tuple<const String&> arguments() const
</del><ins>+ const std::tuple<const String&>& arguments() const
</ins><span class="cx"> {
</span><span class="cx"> return m_arguments;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2Scriptswebkit2messagespy"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Scripts/webkit2/messages.py (170634 => 170635)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Scripts/webkit2/messages.py 2014-07-01 11:29:24 UTC (rev 170634)
+++ trunk/Source/WebKit2/Scripts/webkit2/messages.py 2014-07-01 11:32:36 UTC (rev 170635)
</span><span class="lines">@@ -142,7 +142,7 @@
</span><span class="cx"> result.append('\n : m_arguments(%s)\n' % ', '.join([x[1] for x in function_parameters]))
</span><span class="cx"> result.append(' {\n')
</span><span class="cx"> result.append(' }\n\n')
</span><del>- result.append(' const %s arguments() const\n' % arguments_type(message))
</del><ins>+ result.append(' const %s& arguments() const\n' % arguments_type(message))
</ins><span class="cx"> result.append(' {\n')
</span><span class="cx"> result.append(' return m_arguments;\n')
</span><span class="cx"> result.append(' }\n')
</span></span></pre>
</div>
</div>
</body>
</html>