<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170650] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170650">170650</a></dd>
<dt>Author</dt> <dd>dbates@webkit.org</dd>
<dt>Date</dt> <dd>2014-07-01 10:49:47 -0700 (Tue, 01 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove unnecessary calls to std::move()
https://bugs.webkit.org/show_bug.cgi?id=134493
Reviewed by Anders Carlsson.
Source/WebCore:
* Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::CDM):
* css/CSSGrammar.y.in:
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::formatNumberValue):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::dashesForIntersectionsWithRect):
Source/WebKit2:
* Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::tryWrapInCFData):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::certificateInfo): Return a WebCore::CertificateInfo instead
of const WebCore::CertificateInfo& to avoid returning a dangling reference to
a local variable. Also, remove the unnecessary calls to std::move() as the compiler
will invoke the move constructor for WebCore::CertificateInfo on return from the
function.
* WebProcess/WebPage/WebFrame.h:
Tools:
* TestWebKitAPI/Tests/WTF/HashSet.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
(TestWebKitAPI::TEST):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesencryptedmediaCDMcpp">trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSGrammaryin">trunk/Source/WebCore/css/CSSGrammar.y.in</a></li>
<li><a href="#trunkSourceWebCorecssCSSPrimitiveValuecpp">trunk/Source/WebCore/css/CSSPrimitiveValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssMediaQuerycpp">trunk/Source/WebCore/css/MediaQuery.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsmacFontMacmm">trunk/Source/WebCore/platform/graphics/mac/FontMac.mm</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedShareableResourcecpp">trunk/Source/WebKit2/Shared/ShareableResource.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebFramecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebFrameh">trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFHashSetcpp">trunk/Tools/TestWebKitAPI/Tests/WTF/HashSet.cpp</a></li>
<li><a href="#trunkToolsTestWebKitAPITestsWTFnsRetainPtrmm">trunk/Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebCore/ChangeLog 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-07-01 Daniel Bates <dabates@apple.com>
+
+ Remove unnecessary calls to std::move()
+ https://bugs.webkit.org/show_bug.cgi?id=134493
+
+ Reviewed by Anders Carlsson.
+
+ * Modules/encryptedmedia/CDM.cpp:
+ (WebCore::CDM::CDM):
+ * css/CSSGrammar.y.in:
+ * css/CSSPrimitiveValue.cpp:
+ (WebCore::CSSPrimitiveValue::formatNumberValue):
+ * css/MediaQuery.cpp:
+ (WebCore::MediaQuery::MediaQuery):
+ * platform/graphics/mac/FontMac.mm:
+ (WebCore::Font::dashesForIntersectionsWithRect):
+
</ins><span class="cx"> 2014-07-01 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Subpixel rendering: Pixel crack in breadcrumbs at devforums.apple.com.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesencryptedmediaCDMcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -106,7 +106,7 @@
</span><span class="cx"> : m_keySystem(keySystem)
</span><span class="cx"> , m_client(0)
</span><span class="cx"> {
</span><del>- m_private = std::move(CDMFactoryForKeySystem(keySystem)->constructor(this));
</del><ins>+ m_private = CDMFactoryForKeySystem(keySystem)->constructor(this);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CDM::~CDM()
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSGrammaryin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSGrammar.y.in 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -377,7 +377,7 @@
</span><span class="cx"> }
</span><span class="cx"> ;
</span><span class="cx">
</span><del>-webkit_mediaquery: WEBKIT_MEDIAQUERY_SYM WHITESPACE maybe_space media_query '}' { parser->m_mediaQuery = std::move(std::unique_ptr<MediaQuery>($4)); } ;
</del><ins>+webkit_mediaquery: WEBKIT_MEDIAQUERY_SYM WHITESPACE maybe_space media_query '}' { parser->m_mediaQuery = std::unique_ptr<MediaQuery>($4); } ;
</ins><span class="cx">
</span><span class="cx"> webkit_selector:
</span><span class="cx"> WEBKIT_SELECTOR_SYM '{' maybe_space selector_list '}' {
</span><span class="lines">@@ -558,7 +558,7 @@
</span><span class="cx"> ;
</span><span class="cx">
</span><span class="cx"> webkit_source_size_list:
</span><del>- WEBKIT_SIZESATTR_SYM WHITESPACE source_size_list '}' { parser->m_sourceSizeList = std::move(std::unique_ptr<SourceSizeList>($3)); };
</del><ins>+ WEBKIT_SIZESATTR_SYM WHITESPACE source_size_list '}' { parser->m_sourceSizeList = std::unique_ptr<SourceSizeList>($3); };
</ins><span class="cx">
</span><span class="cx"> source_size_list:
</span><span class="cx"> maybe_space source_size maybe_space {
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPrimitiveValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSPrimitiveValue.cpp (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebCore/css/CSSPrimitiveValue.cpp 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -940,7 +940,7 @@
</span><span class="cx"> template <unsigned characterCount>
</span><span class="cx"> ALWAYS_INLINE PassRef<StringImpl> CSSPrimitiveValue::formatNumberValue(const char (&characters)[characterCount]) const
</span><span class="cx"> {
</span><del>- return std::move(formatNumberValue(characters, characterCount - 1));
</del><ins>+ return formatNumberValue(characters, characterCount - 1);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ALWAYS_INLINE String CSSPrimitiveValue::formatNumberForcustomCSSText() const
</span></span></pre></div>
<a id="trunkSourceWebCorecssMediaQuerycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/MediaQuery.cpp (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/MediaQuery.cpp 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebCore/css/MediaQuery.cpp 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> , m_serializationCache(o.m_serializationCache)
</span><span class="cx"> {
</span><span class="cx"> for (unsigned i = 0; i < m_expressions->size(); ++i)
</span><del>- (*m_expressions)[i] = std::move(o.m_expressions->at(i)->copy());
</del><ins>+ (*m_expressions)[i] = o.m_expressions->at(i)->copy();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> MediaQuery::~MediaQuery()
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsmacFontMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/mac/FontMac.mm (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebCore/platform/graphics/mac/FontMac.mm 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -534,9 +534,9 @@
</span><span class="cx"> bool isSVG = false;
</span><span class="cx"> FloatPoint origin = FloatPoint(textOrigin.x() + deltaX, textOrigin.y());
</span><span class="cx"> if (!fontData->isSVGFont())
</span><del>- translator = std::move(std::make_unique<MacGlyphToPathTranslator>(run, glyphBuffer, origin));
</del><ins>+ translator = std::make_unique<MacGlyphToPathTranslator>(run, glyphBuffer, origin);
</ins><span class="cx"> else {
</span><del>- translator = std::move(run.renderingContext()->createGlyphToPathTranslator(*fontData, &run, glyphBuffer, 0, glyphBuffer.size(), origin));
</del><ins>+ translator = run.renderingContext()->createGlyphToPathTranslator(*fontData, &run, glyphBuffer, 0, glyphBuffer.size(), origin);
</ins><span class="cx"> isSVG = true;
</span><span class="cx"> }
</span><span class="cx"> DashArray result;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2014-07-01 Daniel Bates <dabates@apple.com>
+
+ Remove unnecessary calls to std::move()
+ https://bugs.webkit.org/show_bug.cgi?id=134493
+
+ Reviewed by Anders Carlsson.
+
+ * Shared/ShareableResource.cpp:
+ (WebKit::ShareableResource::Handle::tryWrapInCFData):
+ * WebProcess/WebPage/WebFrame.cpp:
+ (WebKit::WebFrame::certificateInfo): Return a WebCore::CertificateInfo instead
+ of const WebCore::CertificateInfo& to avoid returning a dangling reference to
+ a local variable. Also, remove the unnecessary calls to std::move() as the compiler
+ will invoke the move constructor for WebCore::CertificateInfo on return from the
+ function.
+ * WebProcess/WebPage/WebFrame.h:
+
</ins><span class="cx"> 2014-07-01 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Add a BackForwardListItemState struct and put the snapshot UUID there
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedShareableResourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/ShareableResource.cpp (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/ShareableResource.cpp 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebKit2/Shared/ShareableResource.cpp 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RetainPtr<CFAllocatorRef> deallocator = adoptCF(createShareableResourceDeallocator(resource.get()));
</span><del>- return std::move(adoptCF(CFDataCreateWithBytesNoCopy(kCFAllocatorDefault, reinterpret_cast<const UInt8*>(resource->data()), static_cast<CFIndex>(resource->size()), deallocator.get())));
</del><ins>+ return adoptCF(CFDataCreateWithBytesNoCopy(kCFAllocatorDefault, reinterpret_cast<const UInt8*>(resource->data()), static_cast<CFIndex>(resource->size()), deallocator.get()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<SharedBuffer> ShareableResource::Handle::tryWrapInSharedBuffer() const
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebFramecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -402,16 +402,16 @@
</span><span class="cx"> return documentLoader->url().string();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const WebCore::CertificateInfo& WebFrame::certificateInfo() const
</del><ins>+WebCore::CertificateInfo WebFrame::certificateInfo() const
</ins><span class="cx"> {
</span><span class="cx"> if (!m_coreFrame)
</span><del>- return std::move(CertificateInfo());
</del><ins>+ return CertificateInfo();
</ins><span class="cx">
</span><span class="cx"> DocumentLoader* documentLoader = m_coreFrame->loader().documentLoader();
</span><span class="cx"> if (!documentLoader)
</span><del>- return std::move(CertificateInfo());
</del><ins>+ return CertificateInfo();
</ins><span class="cx">
</span><del>- return std::move(CertificateInfo(documentLoader->response()));
</del><ins>+ return CertificateInfo(documentLoader->response());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String WebFrame::innerText() const
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebFrameh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx"> bool isMainFrame() const;
</span><span class="cx"> String name() const;
</span><span class="cx"> String url() const;
</span><del>- const WebCore::CertificateInfo& certificateInfo() const;
</del><ins>+ WebCore::CertificateInfo certificateInfo() const;
</ins><span class="cx"> String innerText() const;
</span><span class="cx"> bool isFrameSet() const;
</span><span class="cx"> WebFrame* parentFrame() const;
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Tools/ChangeLog 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-07-01 Daniel Bates <dabates@apple.com>
+
+ Remove unnecessary calls to std::move()
+ https://bugs.webkit.org/show_bug.cgi?id=134493
+
+ Reviewed by Anders Carlsson.
+
+ * TestWebKitAPI/Tests/WTF/HashSet.cpp:
+ (TestWebKitAPI::TEST):
+ * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
+ (TestWebKitAPI::TEST):
+
</ins><span class="cx"> 2014-07-01 Pratik Solanki <psolanki@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed. Adding myself to the reviewers list to make commit bot happy.
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFHashSetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/HashSet.cpp (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/HashSet.cpp 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/HashSet.cpp 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx"> EXPECT_TRUE(hashSet.isEmpty());
</span><span class="cx">
</span><span class="cx"> for (size_t i = 0; i < 100; ++i)
</span><del>- hashSet.add(std::move(MoveOnly(i + 1)));
</del><ins>+ hashSet.add(MoveOnly(i + 1));
</ins><span class="cx">
</span><span class="cx"> for (size_t i = 0; i < 100; ++i)
</span><span class="cx"> EXPECT_TRUE(hashSet.take(MoveOnly(i + 1)) == MoveOnly(i + 1));
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx"> EXPECT_TRUE(hashSet.isEmpty());
</span><span class="cx">
</span><span class="cx"> for (size_t i = 0; i < 100; ++i)
</span><del>- hashSet.add(std::move(MoveOnly(i + 1)));
</del><ins>+ hashSet.add(MoveOnly(i + 1));
</ins><span class="cx">
</span><span class="cx"> HashSet<MoveOnly> secondSet;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkToolsTestWebKitAPITestsWTFnsRetainPtrmm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm (170649 => 170650)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm 2014-07-01 17:46:29 UTC (rev 170649)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm 2014-07-01 17:49:47 UTC (rev 170650)
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> NSString *string = @"foo";
</span><span class="cx">
</span><span class="cx"> // This should invoke RetainPtr's move constructor.
</span><del>- RetainPtr<NSString> ptr = std::move(RetainPtr<NSString>(string));
</del><ins>+ RetainPtr<NSString> ptr = RetainPtr<NSString>(string);
</ins><span class="cx">
</span><span class="cx"> EXPECT_EQ(string, ptr);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>