<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170678] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170678">170678</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2014-07-01 16:57:07 -0700 (Tue, 01 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: iOS does not expose ARIA toggle buttons at all (not even as a regular button)
https://bugs.webkit.org/show_bug.cgi?id=133875
Reviewed by Enrica Casucci.
Source/WebCore:
Support the toggle button type in iOS.
Test: platform/ios-sim/accessibility/toggle-button.html
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
LayoutTests:
* platform/ios-sim/accessibility/toggle-button-expected.txt: Added.
* platform/ios-sim/accessibility/toggle-button.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformiossimaccessibilitytogglebuttonexpectedtxt">trunk/LayoutTests/platform/ios-sim/accessibility/toggle-button-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimaccessibilitytogglebuttonhtml">trunk/LayoutTests/platform/ios-sim/accessibility/toggle-button.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (170677 => 170678)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-07-01 23:40:32 UTC (rev 170677)
+++ trunk/LayoutTests/ChangeLog 2014-07-01 23:57:07 UTC (rev 170678)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-07-01 Chris Fleizach <cfleizach@apple.com>
+
+ AX: iOS does not expose ARIA toggle buttons at all (not even as a regular button)
+ https://bugs.webkit.org/show_bug.cgi?id=133875
+
+ Reviewed by Enrica Casucci.
+
+ * platform/ios-sim/accessibility/toggle-button-expected.txt: Added.
+ * platform/ios-sim/accessibility/toggle-button.html: Added.
+
</ins><span class="cx"> 2014-07-01 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Subsampled JPEG images do not draw correctly via the canvas APIs
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimaccessibilitytogglebuttonexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-sim/accessibility/toggle-button-expected.txt (0 => 170678)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-sim/accessibility/toggle-button-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-sim/accessibility/toggle-button-expected.txt 2014-07-01 23:57:07 UTC (rev 170678)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+Bold Italic
+This makes sure that toggle buttons are exposed properly on iOS
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Button1 : AXLabel: Bold
+Button1 : AXValue:
+Button2 : AXLabel: Italic
+Button2 : AXValue:
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiossimaccessibilitytogglebuttonhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-sim/accessibility/toggle-button.html (0 => 170678)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-sim/accessibility/toggle-button.html (rev 0)
+++ trunk/LayoutTests/platform/ios-sim/accessibility/toggle-button.html 2014-07-01 23:57:07 UTC (rev 170678)
</span><span class="lines">@@ -0,0 +1,38 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../../../resources/js-test-pre.js"></script>
+<script>
+var successfullyParsed = false;
+</script>
+</head>
+<body id="body">
+
+<a id="button1" href="#" onclick="return toggle(event);" onkeypress="return handleKeyPress(event);" role="button" aria-pressed="false" tabindex="0">Bold</a>
+<button id="button2" onclick="return toggle(event);" aria-pressed="true">Italic</button>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This makes sure that toggle buttons are exposed properly on iOS");
+
+ if (window.accessibilityController) {
+
+ var button1 = accessibilityController.accessibleElementById("button1");
+ debug("Button1 : " + button1.iphoneLabel);
+ debug("Button1 : " + button1.iphoneValue);
+
+ var button2 = accessibilityController.accessibleElementById("button2");
+ debug("Button2 : " + button2.iphoneLabel);
+ debug("Button2 : " + button2.iphoneValue);
+ }
+
+ successfullyParsed = true;
+</script>
+
+<script src="../../../resources/js-test-post.js"></script>
+</body>
+</html>
+
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170677 => 170678)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-07-01 23:40:32 UTC (rev 170677)
+++ trunk/Source/WebCore/ChangeLog 2014-07-01 23:57:07 UTC (rev 170678)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-07-01 Chris Fleizach <cfleizach@apple.com>
+
+ AX: iOS does not expose ARIA toggle buttons at all (not even as a regular button)
+ https://bugs.webkit.org/show_bug.cgi?id=133875
+
+ Reviewed by Enrica Casucci.
+
+ Support the toggle button type in iOS.
+
+ Test: platform/ios-sim/accessibility/toggle-button.html
+
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
+ (-[WebAccessibilityObjectWrapper accessibilityTraits]):
+ (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
+
</ins><span class="cx"> 2014-07-01 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Subsampled JPEG images do not draw correctly via the canvas APIs
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (170677 => 170678)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-07-01 23:40:32 UTC (rev 170677)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-07-01 23:57:07 UTC (rev 170678)
</span><span class="lines">@@ -301,6 +301,7 @@
</span><span class="cx"> case StaticTextRole:
</span><span class="cx"> case TabRole:
</span><span class="cx"> case TextFieldRole:
</span><ins>+ case ToggleButtonRole:
</ins><span class="cx"> return !m_object->accessibilityIsIgnored();
</span><span class="cx"> default:
</span><span class="cx"> return false;
</span><span class="lines">@@ -562,6 +563,7 @@
</span><span class="cx"> case RadioButtonRole:
</span><span class="cx"> traits |= [self _axRadioButtonTrait] | [self _axToggleTrait];
</span><span class="cx"> break;
</span><ins>+ case ToggleButtonRole:
</ins><span class="cx"> case CheckBoxRole:
</span><span class="cx"> traits |= ([self _axButtonTrait] | [self _axToggleTrait]);
</span><span class="cx"> break;
</span><span class="lines">@@ -623,6 +625,7 @@
</span><span class="cx"> case TextFieldRole:
</span><span class="cx"> case TextAreaRole:
</span><span class="cx"> case ButtonRole:
</span><ins>+ case ToggleButtonRole:
</ins><span class="cx"> case PopUpButtonRole:
</span><span class="cx"> case CheckBoxRole:
</span><span class="cx"> case RadioButtonRole:
</span></span></pre>
</div>
</div>
</body>
</html>