<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170619] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170619">170619</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2014-06-30 17:17:09 -0700 (Mon, 30 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>All Indic text is rendered as boxes on iOS
https://bugs.webkit.org/show_bug.cgi?id=134464
Reviewed by Simon Fraser.
Source/WebCore:
I made a typo in <a href="http://trac.webkit.org/projects/webkit/changeset/170207">r170207</a>.
Test: fast/text/indic.html
* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
LayoutTests:
Simply draw some indic text and test that against currently good metric values.
* fast/text/indic.html: Added
* platform/ios-sim/fast/text/indic-expected.txt: Added.
* platform/mac/fast/text/indic-expected.txt: Added.
* platform/mac/fast/text/indic-expected.png: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsiosFontCacheIOSmm">trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfasttextindichtml">trunk/LayoutTests/fast/text/indic.html</a></li>
<li><a href="#trunkLayoutTestsplatformiossimfasttextindicexpectedtxt">trunk/LayoutTests/platform/ios-sim/fast/text/indic-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacfasttextindicexpectedpng">trunk/LayoutTests/platform/mac/fast/text/indic-expected.png</a></li>
<li><a href="#trunkLayoutTestsplatformmacfasttextindicexpectedtxt">trunk/LayoutTests/platform/mac/fast/text/indic-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (170618 => 170619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-07-01 00:14:38 UTC (rev 170618)
+++ trunk/LayoutTests/ChangeLog        2014-07-01 00:17:09 UTC (rev 170619)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2014-06-30 Myles C. Maxfield <mmaxfield@apple.com>
+
+ All Indic text is rendered as boxes on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=134464
+
+ Reviewed by Simon Fraser.
+
+ Simply draw some indic text and test that against currently good metric values.
+
+ * fast/text/indic.html: Added
+ * platform/ios-sim/fast/text/indic-expected.txt: Added.
+ * platform/mac/fast/text/indic-expected.txt: Added.
+ * platform/mac/fast/text/indic-expected.png: Added.
+
</ins><span class="cx"> 2014-06-30 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> js/script-tests/function-apply-many-args.js fails on ARM
</span></span></pre></div>
<a id="trunkLayoutTestsfasttextindichtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/text/indic.html (0 => 170619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/text/indic.html         (rev 0)
+++ trunk/LayoutTests/fast/text/indic.html        2014-07-01 00:17:09 UTC (rev 170619)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+<meta charset="utf-8"> This page renders some indic text and makes sure that the text metrics match the expected metrics.
+<br>
+ઠળના ઇરાકી પ્રદેશોને ઇસ્લામિક રાષ્ટ્ર જાહેર કર્યું છે અને પોતાનો વ્યાપ વધારવા તેમના વડા પ્રત્યે વફાદારીનું વિશ્વભરના મુસ્લિમોને આહ્વાન કર્યું છે. ઇસ્લામિક સ્ટેટ ઓફ ઇરાક એન્ડ સિરિયા
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiossimfasttextindicexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-sim/fast/text/indic-expected.txt (0 => 170619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-sim/fast/text/indic-expected.txt         (rev 0)
+++ trunk/LayoutTests/platform/ios-sim/fast/text/indic-expected.txt        2014-07-01 00:17:09 UTC (rev 170619)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+ RenderBody {BODY} at (8,8) size 784x584
+ RenderText {#text} at (0,0) size 636x19
+ text run at (0,0) width 636: "This page renders some indic text and makes sure that the text metrics match the expected metrics. "
+ RenderBR {BR} at (635,15) size 1x0
+ RenderText {#text} at (0,20) size 780x41
+ text run at (0,20) width 780: "\x{AA0}\x{AB3}\x{AA8}\x{ABE} \x{A87}\x{AB0}\x{ABE}\x{A95}\x{AC0} \x{AAA}\x{ACD}\x{AB0}\x{AA6}\x{AC7}\x{AB6}\x{ACB}\x{AA8}\x{AC7} \x{A87}\x{AB8}\x{ACD}\x{AB2}\x{ABE}\x{AAE}\x{ABF}\x{A95} \x{AB0}\x{ABE}\x{AB7}\x{ACD}\x{A9F}\x{ACD}\x{AB0} \x{A9C}\x{ABE}\x{AB9}\x{AC7}\x{AB0} \x{A95}\x{AB0}\x{ACD}\x{AAF}\x{AC1}\x{A82} \x{A9B}\x{AC7} \x{A85}\x{AA8}\x{AC7} \x{AAA}\x{ACB}\x{AA4}\x{ABE}\x{AA8}\x{ACB} \x{AB5}\x{ACD}\x{AAF}\x{ABE}\x{AAA} \x{AB5}\x{AA7}\x{ABE}\x{AB0}\x{AB5}\x{ABE} \x{AA4}\x{AC7}\x{AAE}\x{AA8}\x{ABE} \x{AB5}\x{AA1}\x{ABE} \x{AAA}\x{ACD}\x{AB0}\x{AA4}\x{ACD}\x{AAF}\x{AC7} \x{AB5}\x{AAB}\x{ABE}\x{AA6}\x{ABE}\x{AB0}\x{AC0}\x{AA8}\x{AC1}\x{A82} \x{AB5}\x{ABF}\x{AB6}\x{ACD}\x{AB5}\x{AAD}\x{AB0}\x{AA8}\x{ABE} \x{AAE}\x{AC1}\x{AB8}\x{ACD}\x{AB2}\x{ABF}\x{AAE}\x{ACB}\x{AA8}\x{AC7} \x{A86}\x{AB9}\x{ACD}\x{AB5}\x{ABE}\x{AA8} \x{A95}\x{AB0}\x{ACD}\x{AAF}\x{AC1}\x{A82} \x{A9B}\x{AC7}. \x{A87}\x{AB8}\x{ACD}\x{AB2}\x{ABE}\x{AAE}\x{ABF}\x{A95} \x{AB8}\x{ACD}\x{A9F}\x{AC7}\x{A9F}"
+ text run at (0,42) width 117: "\x{A93}\x{AAB} \x{A87}\x{AB0}\x{ABE}\x{A95} \x{A8F}\x{AA8}\x{ACD}\x{AA1} \x{AB8}\x{ABF}\x{AB0}\x{ABF}\x{AAF}\x{ABE}"
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacfasttextindicexpectedpng"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/mac/fast/text/indic-expected.png (0 => 170619)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/fast/text/indic-expected.png         (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/text/indic-expected.png        2014-07-01 00:17:09 UTC (rev 170619)
</span><span class="lines">@@ -0,0 +1,123 @@
</span><ins>+\x89PNG
+
+
+IHDR