<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170601] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170601">170601</a></dd>
<dt>Author</dt> <dd>msaboff@apple.com</dd>
<dt>Date</dt> <dd>2014-06-30 15:12:17 -0700 (Mon, 30 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add option to run-jsc-stress-testes to filter out tests that use large heaps
https://bugs.webkit.org/show_bug.cgi?id=134458
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Added test to skip js1_5/Regress/regress-159334.js when testing on a memory limited device.
* tests/mozilla/mozilla-tests.yaml:
Tools:
Added new --memory-limited to filter out tests that have large heap usage.
Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
* Scripts/run-jsc-stress-tests:
LayoutTests:
* js/regress/script-tests/lots-of-fields.js: Added //@largeHeap tag to skip when
running on a memoryLimited device.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjsregressscripttestslotsoffieldsjs">trunk/LayoutTests/js/regress/script-tests/lots-of-fields.js</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsmozillamozillatestsyaml">trunk/Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsrunjscstresstests">trunk/Tools/Scripts/run-jsc-stress-tests</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (170600 => 170601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-06-30 22:10:56 UTC (rev 170600)
+++ trunk/LayoutTests/ChangeLog 2014-06-30 22:12:17 UTC (rev 170601)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2014-06-30 Michael Saboff <msaboff@apple.com>
+
+ Add option to run-jsc-stress-testes to filter out tests that use large heaps
+ https://bugs.webkit.org/show_bug.cgi?id=134458
+
+ Reviewed by Filip Pizlo.
+
+ * js/regress/script-tests/lots-of-fields.js: Added //@largeHeap tag to skip when
+ running on a memoryLimited device.
+
</ins><span class="cx"> 2014-06-30 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> Tiles on bottom of screen are not always allocated when necessary
</span></span></pre></div>
<a id="trunkLayoutTestsjsregressscripttestslotsoffieldsjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/regress/script-tests/lots-of-fields.js (170600 => 170601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/regress/script-tests/lots-of-fields.js 2014-06-30 22:10:56 UTC (rev 170600)
+++ trunk/LayoutTests/js/regress/script-tests/lots-of-fields.js 2014-06-30 22:12:17 UTC (rev 170601)
</span><span class="lines">@@ -1,3 +1,6 @@
</span><ins>+// This test uses all available memory on some small memory devices.
+//@largeHeap
+
</ins><span class="cx"> function foo() {
</span><span class="cx"> var result = 0;
</span><span class="cx"> for (var i = 0; i < 5000; ++i) {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (170600 => 170601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-06-30 22:10:56 UTC (rev 170600)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-06-30 22:12:17 UTC (rev 170601)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2014-06-30 Michael Saboff <msaboff@apple.com>
+
+ Add option to run-jsc-stress-testes to filter out tests that use large heaps
+ https://bugs.webkit.org/show_bug.cgi?id=134458
+
+ Reviewed by Filip Pizlo.
+
+ Added test to skip js1_5/Regress/regress-159334.js when testing on a memory limited device.
+
+ * tests/mozilla/mozilla-tests.yaml:
+
</ins><span class="cx"> 2014-06-30 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> Avoid copying closed variables vector; actually use move semantics
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsmozillamozillatestsyaml"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml (170600 => 170601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml 2014-06-30 22:10:56 UTC (rev 170600)
+++ trunk/Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml 2014-06-30 22:12:17 UTC (rev 170601)
</span><span class="lines">@@ -2113,7 +2113,7 @@
</span><span class="cx"> cmd: defaultRunMozillaTest :normal, "../shell.js"
</span><span class="cx"> - path: js1_5/Regress/regress-159334.js
</span><span class="cx"> cmd: |
</span><del>- if $architecture !~ /x86/i and $hostOS == "darwin"
</del><ins>+ if ($architecture !~ /x86/i and $hostOS == "darwin") or $memoryLimited
</ins><span class="cx"> skip
</span><span class="cx"> else
</span><span class="cx"> defaultRunMozillaTest :normal, "../shell.js"
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (170600 => 170601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2014-06-30 22:10:56 UTC (rev 170600)
+++ trunk/Tools/ChangeLog 2014-06-30 22:12:17 UTC (rev 170601)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2014-06-30 Michael Saboff <msaboff@apple.com>
+
+ Add option to run-jsc-stress-testes to filter out tests that use large heaps
+ https://bugs.webkit.org/show_bug.cgi?id=134458
+
+ Reviewed by Filip Pizlo.
+
+ Added new --memory-limited to filter out tests that have large heap usage.
+ Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
+
+ * Scripts/run-jsc-stress-tests:
+
</ins><span class="cx"> 2014-06-30 Myles C. Maxfield <mmaxfield@apple.com>
</span><span class="cx">
</span><span class="cx"> DRT in iOS sim crashes while loading fonts
</span></span></pre></div>
<a id="trunkToolsScriptsrunjscstresstests"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-jsc-stress-tests (170600 => 170601)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/run-jsc-stress-tests 2014-06-30 22:10:56 UTC (rev 170600)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2014-06-30 22:12:17 UTC (rev 170601)
</span><span class="lines">@@ -94,6 +94,7 @@
</span><span class="cx"> $jscPath = nil
</span><span class="cx"> $copy = true
</span><span class="cx"> $enableFTL = false
</span><ins>+$memoryLimited = false
</ins><span class="cx"> $outputDir = Pathname.new("results")
</span><span class="cx"> $verbosity = 0
</span><span class="cx"> $bundle = nil
</span><span class="lines">@@ -112,6 +113,8 @@
</span><span class="cx"> puts "--no-copy Do not copy the JavaScriptCore build product before testing."
</span><span class="cx"> puts " --jsc specifies an already present JavaScriptCore to test."
</span><span class="cx"> puts "--ftl-jit Indicate that we have the FTL JIT."
</span><ins>+ puts "--memory-limited Indicate that we are targeting the test for a memory limited device."
+ puts " Skip tests tagged with //@large-heap"
</ins><span class="cx"> puts "--output-dir (-o) Path where to put results. Default is #{$outputDir}."
</span><span class="cx"> puts "--verbose (-v) Print more things while running."
</span><span class="cx"> puts "--run-bundle Runs a bundle previously created by run-jsc-stress-tests."
</span><span class="lines">@@ -130,6 +133,7 @@
</span><span class="cx"> ['--jsc', '-j', GetoptLong::REQUIRED_ARGUMENT],
</span><span class="cx"> ['--no-copy', GetoptLong::NO_ARGUMENT],
</span><span class="cx"> ['--ftl-jit', GetoptLong::NO_ARGUMENT],
</span><ins>+ ['--memory-limited', GetoptLong::NO_ARGUMENT],
</ins><span class="cx"> ['--output-dir', '-o', GetoptLong::REQUIRED_ARGUMENT],
</span><span class="cx"> ['--run-bundle', GetoptLong::REQUIRED_ARGUMENT],
</span><span class="cx"> ['--tarball', GetoptLong::NO_ARGUMENT],
</span><span class="lines">@@ -150,6 +154,8 @@
</span><span class="cx"> $outputDir = Pathname.new(arg)
</span><span class="cx"> when '--ftl-jit'
</span><span class="cx"> $enableFTL = true
</span><ins>+ when '--memory-limited'
+ $memoryLimited = true
</ins><span class="cx"> when '--verbose'
</span><span class="cx"> $verbosity += 1
</span><span class="cx"> when '--run-bundle'
</span><span class="lines">@@ -875,6 +881,13 @@
</span><span class="cx"> puts "Skipping #{$collectionName}/#{$benchmark}"
</span><span class="cx"> end
</span><span class="cx">
</span><ins>+def largeHeap
+ if $memoryLimited
+ $didAddRunCommand = true
+ puts "Skipping #{$collectionName}/#{$benchmark}"
+ end
+end
+
</ins><span class="cx"> def allJSFiles(path)
</span><span class="cx"> if path.file?
</span><span class="cx"> [path]
</span></span></pre>
</div>
</div>
</body>
</html>