<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170539] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170539">170539</a></dd>
<dt>Author</dt> <dd>betravis@adobe.com</dd>
<dt>Date</dt> <dd>2014-06-27 11:13:55 -0700 (Fri, 27 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[Feature Queries] Fix feature queries build on Mac
https://bugs.webkit.org/show_bug.cgi?id=134359
Reviewed by Antti Koivisto.
Update the XCode project and Feature Queries code to build on Mac.
There are existing tests for supports in the LayoutTests/css3 directory.
* WebCore.xcodeproj/project.pbxproj: Add the Feature Queries files
to the XCode project.
* css/CSSGrammar.y.in: Update CSSParserExpression to CSSParserValueList.
* css/DOMWindowCSS.idl: Add ImplementationLacksVTable metadata.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreWebCorexcodeprojprojectpbxproj">trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj</a></li>
<li><a href="#trunkSourceWebCorecssCSSGrammaryin">trunk/Source/WebCore/css/CSSGrammar.y.in</a></li>
<li><a href="#trunkSourceWebCorecssDOMWindowCSSidl">trunk/Source/WebCore/css/DOMWindowCSS.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170538 => 170539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-27 18:09:54 UTC (rev 170538)
+++ trunk/Source/WebCore/ChangeLog 2014-06-27 18:13:55 UTC (rev 170539)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2014-06-27 Bear Travis <betravis@adobe.com>
+
+ [Feature Queries] Fix feature queries build on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=134359
+
+ Reviewed by Antti Koivisto.
+
+ Update the XCode project and Feature Queries code to build on Mac.
+
+ There are existing tests for supports in the LayoutTests/css3 directory.
+
+ * WebCore.xcodeproj/project.pbxproj: Add the Feature Queries files
+ to the XCode project.
+ * css/CSSGrammar.y.in: Update CSSParserExpression to CSSParserValueList.
+ * css/DOMWindowCSS.idl: Add ImplementationLacksVTable metadata.
+
</ins><span class="cx"> 2014-06-27 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> [MSE] media/media-source/media-source-tracks.html is crashy
</span></span></pre></div>
<a id="trunkSourceWebCoreWebCorexcodeprojprojectpbxproj"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (170538 => 170539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-06-27 18:09:54 UTC (rev 170538)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2014-06-27 18:13:55 UTC (rev 170539)
</span><span class="lines">@@ -6511,6 +6511,10 @@
</span><span class="cx"> FD62F52E145898D80094B0ED /* AudioSourceProviderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = FD62F52D145898D80094B0ED /* AudioSourceProviderClient.h */; };
</span><span class="cx"> FD671A77159BB07000197559 /* MediaStreamAudioSourceNode.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FD671A74159BB07000197559 /* MediaStreamAudioSourceNode.cpp */; };
</span><span class="cx"> FD671A78159BB07000197559 /* MediaStreamAudioSourceNode.h in Headers */ = {isa = PBXBuildFile; fileRef = FD671A75159BB07000197559 /* MediaStreamAudioSourceNode.h */; };
</span><ins>+ FD677738195CAF3D0072E0D3 /* DOMWindowCSS.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FD677735195CAB200072E0D3 /* DOMWindowCSS.cpp */; };
+ FD677739195CAFBA0072E0D3 /* CSSSupportsRule.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FD677734195CAB200072E0D3 /* CSSSupportsRule.cpp */; };
+ FD67773A195CB14A0072E0D3 /* JSCSSSupportsRule.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FD677736195CAB7D0072E0D3 /* JSCSSSupportsRule.cpp */; };
+ FD67773B195CB1E60072E0D3 /* JSDOMWindowCSS.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FD677737195CAB7D0072E0D3 /* JSDOMWindowCSS.cpp */; };
</ins><span class="cx"> FD6ED2C3136B8E42003CF072 /* DynamicsCompressorNode.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FD6ED2C1136B8E42003CF072 /* DynamicsCompressorNode.cpp */; };
</span><span class="cx"> FD6ED2C4136B8E42003CF072 /* DynamicsCompressorNode.h in Headers */ = {isa = PBXBuildFile; fileRef = FD6ED2C2136B8E42003CF072 /* DynamicsCompressorNode.h */; };
</span><span class="cx"> FD6ED2C7136B8E66003CF072 /* DynamicsCompressor.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FD6ED2C5136B8E66003CF072 /* DynamicsCompressor.cpp */; };
</span><span class="lines">@@ -14068,6 +14072,10 @@
</span><span class="cx"> FD671A74159BB07000197559 /* MediaStreamAudioSourceNode.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MediaStreamAudioSourceNode.cpp; sourceTree = "<group>"; };
</span><span class="cx"> FD671A75159BB07000197559 /* MediaStreamAudioSourceNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MediaStreamAudioSourceNode.h; sourceTree = "<group>"; };
</span><span class="cx"> FD671A76159BB07000197559 /* MediaStreamAudioSourceNode.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = MediaStreamAudioSourceNode.idl; sourceTree = "<group>"; };
</span><ins>+ FD677734195CAB200072E0D3 /* CSSSupportsRule.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CSSSupportsRule.cpp; sourceTree = "<group>"; };
+ FD677735195CAB200072E0D3 /* DOMWindowCSS.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DOMWindowCSS.cpp; sourceTree = "<group>"; };
+ FD677736195CAB7D0072E0D3 /* JSCSSSupportsRule.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSCSSSupportsRule.cpp; path = DerivedSources/WebCore/JSCSSSupportsRule.cpp; sourceTree = BUILT_PRODUCTS_DIR; };
+ FD677737195CAB7D0072E0D3 /* JSDOMWindowCSS.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSDOMWindowCSS.cpp; path = DerivedSources/WebCore/JSDOMWindowCSS.cpp; sourceTree = BUILT_PRODUCTS_DIR; };
</ins><span class="cx"> FD6ED2C1136B8E42003CF072 /* DynamicsCompressorNode.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DynamicsCompressorNode.cpp; sourceTree = "<group>"; };
</span><span class="cx"> FD6ED2C2136B8E42003CF072 /* DynamicsCompressorNode.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DynamicsCompressorNode.h; sourceTree = "<group>"; };
</span><span class="cx"> FD6ED2C5136B8E66003CF072 /* DynamicsCompressor.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DynamicsCompressor.cpp; sourceTree = "<group>"; };
</span><span class="lines">@@ -19198,11 +19206,13 @@
</span><span class="cx"> BC46C2050C0DDCA10020CFC3 /* JSCSSStyleRule.h */,
</span><span class="cx"> BCC5BDFE0C0E93110011C2DB /* JSCSSStyleSheet.cpp */,
</span><span class="cx"> BCC5BDFF0C0E93110011C2DB /* JSCSSStyleSheet.h */,
</span><ins>+ FD677736195CAB7D0072E0D3 /* JSCSSSupportsRule.cpp */,
</ins><span class="cx"> FC84802E167AB444008CD100 /* JSCSSSupportsRule.h */,
</span><span class="cx"> 14CF78A309F58CBF00EB3665 /* JSCSSValue.cpp */,
</span><span class="cx"> 14CF78A509F58CD800EB3665 /* JSCSSValue.h */,
</span><span class="cx"> A8D05FA90A23B30F005E7203 /* JSCSSValueList.cpp */,
</span><span class="cx"> A8D05FAA0A23B30F005E7203 /* JSCSSValueList.h */,
</span><ins>+ FD677737195CAB7D0072E0D3 /* JSDOMWindowCSS.cpp */,
</ins><span class="cx"> FC9E0E4B16419C1E00392BE3 /* JSDOMWindowCSS.h */,
</span><span class="cx"> BC3C39B40C0D3D8D005F4D7A /* JSMediaList.cpp */,
</span><span class="cx"> BC3C39B50C0D3D8D005F4D7A /* JSMediaList.h */,
</span><span class="lines">@@ -22021,6 +22031,7 @@
</span><span class="cx"> A8EA80000A19516E00A8EF5F /* CSSStyleSheet.cpp */,
</span><span class="cx"> A8EA7FFF0A19516E00A8EF5F /* CSSStyleSheet.h */,
</span><span class="cx"> 858C39100AA8FF0000B187A4 /* CSSStyleSheet.idl */,
</span><ins>+ FD677734195CAB200072E0D3 /* CSSSupportsRule.cpp */,
</ins><span class="cx"> FC63BDB1167AABAC00F9380F /* CSSSupportsRule.h */,
</span><span class="cx"> FC63BDB2167AABAC00F9380F /* CSSSupportsRule.idl */,
</span><span class="cx"> BC80C9850CD294EE00A0B7B3 /* CSSTimingFunctionValue.cpp */,
</span><span class="lines">@@ -22047,6 +22058,7 @@
</span><span class="cx"> E100EE741546EAC100BA11D1 /* DeprecatedStyleBuilder.h */,
</span><span class="cx"> 4A4F48A716B0DFC000EDBB29 /* DocumentRuleSets.cpp */,
</span><span class="cx"> 4A4F48A816B0DFC000EDBB29 /* DocumentRuleSets.h */,
</span><ins>+ FD677735195CAB200072E0D3 /* DOMWindowCSS.cpp */,
</ins><span class="cx"> FC9A0F72164094CF003D6B8D /* DOMWindowCSS.h */,
</span><span class="cx"> FC9A0F73164094CF003D6B8D /* DOMWindowCSS.idl */,
</span><span class="cx"> FBDB619A16D6032A00BB3394 /* ElementRuleCollector.cpp */,
</span><span class="lines">@@ -27307,6 +27319,7 @@
</span><span class="cx"> A80E6CF40A1989CA007FB8C5 /* CSSShadowValue.cpp in Sources */,
</span><span class="cx"> A80E6CEF0A1989CA007FB8C5 /* CSSStyleRule.cpp in Sources */,
</span><span class="cx"> A8EA80080A19516E00A8EF5F /* CSSStyleSheet.cpp in Sources */,
</span><ins>+ FD677739195CAFBA0072E0D3 /* CSSSupportsRule.cpp in Sources */,
</ins><span class="cx"> BC80C9870CD294EE00A0B7B3 /* CSSTimingFunctionValue.cpp in Sources */,
</span><span class="cx"> A882DA201593846A000115ED /* CSSToStyleMap.cpp in Sources */,
</span><span class="cx"> 371F53EA0D2704F900ECE0D5 /* CSSUnicodeRangeValue.cpp in Sources */,
</span><span class="lines">@@ -27580,6 +27593,7 @@
</span><span class="cx"> 31C0FF4D0E4CEFDD007D6FE5 /* DOMWebKitTransitionEvent.mm in Sources */,
</span><span class="cx"> 85C7F5E80AAFBAFB004014DD /* DOMWheelEvent.mm in Sources */,
</span><span class="cx"> 1403B99809EB13AF00797C7F /* DOMWindow.cpp in Sources */,
</span><ins>+ FD677738195CAF3D0072E0D3 /* DOMWindowCSS.cpp in Sources */,
</ins><span class="cx"> 517FBA1E151AB17C00B57959 /* DOMWindowExtension.cpp in Sources */,
</span><span class="cx"> 51D719B6181106E00016DC51 /* DOMWindowIndexedDatabase.cpp in Sources */,
</span><span class="cx"> 97B38E28151C4273004622E9 /* DOMWindowNotifications.cpp in Sources */,
</span><span class="lines">@@ -28112,6 +28126,7 @@
</span><span class="cx"> BC5825F30C0B89380053F1B5 /* JSCSSStyleDeclarationCustom.cpp in Sources */,
</span><span class="cx"> BC46C2060C0DDCA10020CFC3 /* JSCSSStyleRule.cpp in Sources */,
</span><span class="cx"> BCC5BE000C0E93110011C2DB /* JSCSSStyleSheet.cpp in Sources */,
</span><ins>+ FD67773A195CB14A0072E0D3 /* JSCSSSupportsRule.cpp in Sources */,
</ins><span class="cx"> 14CF78A409F58CBF00EB3665 /* JSCSSValue.cpp in Sources */,
</span><span class="cx"> BC20FB7F0C0E8E6C00D1447F /* JSCSSValueCustom.cpp in Sources */,
</span><span class="cx"> A8D05FAB0A23B30F005E7203 /* JSCSSValueList.cpp in Sources */,
</span><span class="lines">@@ -28166,6 +28181,7 @@
</span><span class="cx"> 2E37E00512DBC5A400A6B233 /* JSDOMURL.cpp in Sources */,
</span><span class="cx"> 1403BA0C09EB18C700797C7F /* JSDOMWindow.cpp in Sources */,
</span><span class="cx"> BC6932730D7E293900AE44D1 /* JSDOMWindowBase.cpp in Sources */,
</span><ins>+ FD67773B195CB1E60072E0D3 /* JSDOMWindowCSS.cpp in Sources */,
</ins><span class="cx"> BCD9C2620C17AA67005C90A2 /* JSDOMWindowCustom.cpp in Sources */,
</span><span class="cx"> BCBFB53C0DCD29CF0019B3E5 /* JSDOMWindowShell.cpp in Sources */,
</span><span class="cx"> FD7868B9136B999200D403DF /* JSDynamicsCompressorNode.cpp in Sources */,
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSGrammaryin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (170538 => 170539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSGrammar.y.in 2014-06-27 18:09:54 UTC (rev 170538)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in 2014-06-27 18:13:55 UTC (rev 170539)
</span><span class="lines">@@ -682,7 +682,7 @@
</span><span class="cx"> '(' maybe_space property ':' maybe_space expr priority ')' maybe_space {
</span><span class="cx"> $$ = false;
</span><span class="cx"> CSSParser* p = static_cast<CSSParser*>(parser);
</span><del>- std::unique_ptr<CSSParserExpression> propertyValue($6);
</del><ins>+ std::unique_ptr<CSSParserValueList> propertyValue($6);
</ins><span class="cx"> if ($3 && propertyValue) {
</span><span class="cx"> p->m_valueList = std::move(propertyValue);
</span><span class="cx"> int oldParsedProperties = p->m_parsedProperties.size();
</span></span></pre></div>
<a id="trunkSourceWebCorecssDOMWindowCSSidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/DOMWindowCSS.idl (170538 => 170539)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/DOMWindowCSS.idl 2014-06-27 18:09:54 UTC (rev 170538)
+++ trunk/Source/WebCore/css/DOMWindowCSS.idl 2014-06-27 18:13:55 UTC (rev 170539)
</span><span class="lines">@@ -30,6 +30,7 @@
</span><span class="cx"> [
</span><span class="cx"> NoInterfaceObject,
</span><span class="cx"> InterfaceName=CSS,
</span><ins>+ ImplementationLacksVTable,
</ins><span class="cx"> Conditional=CSS3_CONDITIONAL_RULES,
</span><span class="cx"> ] interface DOMWindowCSS {
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>