<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170464] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170464">170464</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2014-06-25 21:44:24 -0700 (Wed, 25 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>WebProgressTracker updates progress too frequently
https://bugs.webkit.org/show_bug.cgi?id=134185
Reviewed by Tim Horton.
The old code throttled the progress update to when either 100ms has passed or the delta is at least 2%
but this was still not enough in pages that loaded in sub-seconds. The new code always throttles it at 200ms.
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::incrementProgress):
* loader/ProgressTracker.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreloaderProgressTrackercpp">trunk/Source/WebCore/loader/ProgressTracker.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderProgressTrackerh">trunk/Source/WebCore/loader/ProgressTracker.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170463 => 170464)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-26 04:15:52 UTC (rev 170463)
+++ trunk/Source/WebCore/ChangeLog 2014-06-26 04:44:24 UTC (rev 170464)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-06-25 Ryosuke Niwa <rniwa@webkit.org>
+
+ WebProgressTracker updates progress too frequently
+ https://bugs.webkit.org/show_bug.cgi?id=134185
+
+ Reviewed by Tim Horton.
+
+ The old code throttled the progress update to when either 100ms has passed or the delta is at least 2%
+ but this was still not enough in pages that loaded in sub-seconds. The new code always throttles it at 200ms.
+
+ * loader/ProgressTracker.cpp:
+ (WebCore::ProgressTracker::ProgressTracker):
+ (WebCore::ProgressTracker::incrementProgress):
+ * loader/ProgressTracker.h:
+
</ins><span class="cx"> 2014-06-25 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS WK2] Fixed position elements jump around when zooming
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderProgressTrackercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ProgressTracker.cpp (170463 => 170464)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ProgressTracker.cpp 2014-06-26 04:15:52 UTC (rev 170463)
+++ trunk/Source/WebCore/loader/ProgressTracker.cpp 2014-06-26 04:44:24 UTC (rev 170464)
</span><span class="lines">@@ -60,6 +60,8 @@
</span><span class="cx"> // How many bytes are required between heartbeats to consider it progress.
</span><span class="cx"> static const unsigned minumumBytesPerHeartbeatForProgress = 1024;
</span><span class="cx">
</span><ins>+static const std::chrono::milliseconds progressNotificationTimeInterval = std::chrono::milliseconds(200);
+
</ins><span class="cx"> struct ProgressItem {
</span><span class="cx"> WTF_MAKE_NONCOPYABLE(ProgressItem); WTF_MAKE_FAST_ALLOCATED;
</span><span class="cx"> public:
</span><span class="lines">@@ -80,8 +82,6 @@
</span><span class="cx"> , m_totalPageAndResourceBytesToLoad(0)
</span><span class="cx"> , m_totalBytesReceived(0)
</span><span class="cx"> , m_lastNotifiedProgressValue(0)
</span><del>- , m_progressNotificationInterval(0.02)
- , m_progressNotificationTimeInterval(std::chrono::milliseconds(100))
</del><span class="cx"> , m_finalProgressChangedSent(false)
</span><span class="cx"> , m_progressValue(0)
</span><span class="cx"> , m_numProgressTrackedFrames(0)
</span><span class="lines">@@ -257,10 +257,7 @@
</span><span class="cx"> auto notifiedProgressTimeDelta = now - m_lastNotifiedProgressTime;
</span><span class="cx">
</span><span class="cx"> LOG(Progress, "Progress incremented (%p) - value %f, tracked frames %d", this, m_progressValue, m_numProgressTrackedFrames);
</span><del>- double notificationProgressDelta = m_progressValue - m_lastNotifiedProgressValue;
- if ((notificationProgressDelta >= m_progressNotificationInterval ||
- notifiedProgressTimeDelta >= m_progressNotificationTimeInterval) &&
- m_numProgressTrackedFrames > 0) {
</del><ins>+ if ((notifiedProgressTimeDelta >= progressNotificationTimeInterval || m_progressValue == 1) && m_numProgressTrackedFrames > 0) {
</ins><span class="cx"> if (!m_finalProgressChangedSent) {
</span><span class="cx"> if (m_progressValue == 1)
</span><span class="cx"> m_finalProgressChangedSent = true;
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderProgressTrackerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ProgressTracker.h (170463 => 170464)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ProgressTracker.h 2014-06-26 04:15:52 UTC (rev 170463)
+++ trunk/Source/WebCore/loader/ProgressTracker.h 2014-06-26 04:44:24 UTC (rev 170464)
</span><span class="lines">@@ -75,8 +75,6 @@
</span><span class="cx"> long long m_totalBytesReceived;
</span><span class="cx"> double m_lastNotifiedProgressValue;
</span><span class="cx"> std::chrono::steady_clock::time_point m_lastNotifiedProgressTime;
</span><del>- double m_progressNotificationInterval;
- std::chrono::milliseconds m_progressNotificationTimeInterval;
</del><span class="cx"> bool m_finalProgressChangedSent;
</span><span class="cx"> double m_progressValue;
</span><span class="cx"> RefPtr<Frame> m_originatingProgressFrame;
</span></span></pre>
</div>
</div>
</body>
</html>