<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170307] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170307">170307</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2014-06-23 12:00:34 -0700 (Mon, 23 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>CSS clip property should make layers non-opaque
https://bugs.webkit.org/show_bug.cgi?id=134147
Source/WebCore:
<rdar://problem/17324579>
Reviewed by Tim Horton.
https://www.fairphone.com has position:fixed elements with clip: rect(...)
but we were making those layers opaque, resulting in garbage pixels
in areas outside the clip rect.
Fix by checking for the clip property in RenderBox::backgroundIsKnownToBeOpaqueInRect().
Test: compositing/contents-opaque/opaque-with-clip.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
Reviewed by Tim Horton.
* compositing/contents-opaque/opaque-with-clip-expected.html: Added.
* compositing/contents-opaque/opaque-with-clip.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestscompositinggeometryclipinsideexpectedtxt">trunk/LayoutTests/compositing/geometry/clip-inside-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxcpp">trunk/Source/WebCore/rendering/RenderBox.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscompositingcontentsopaqueopaquewithclipexpectedhtml">trunk/LayoutTests/compositing/contents-opaque/opaque-with-clip-expected.html</a></li>
<li><a href="#trunkLayoutTestscompositingcontentsopaqueopaquewithcliphtml">trunk/LayoutTests/compositing/contents-opaque/opaque-with-clip.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (170306 => 170307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-06-23 19:00:32 UTC (rev 170306)
+++ trunk/LayoutTests/ChangeLog 2014-06-23 19:00:34 UTC (rev 170307)
</span><span class="lines">@@ -1,5 +1,15 @@
</span><span class="cx"> 2014-06-23 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ CSS clip property should make layers non-opaque
+ https://bugs.webkit.org/show_bug.cgi?id=134147
+
+ Reviewed by Tim Horton.
+
+ * compositing/contents-opaque/opaque-with-clip-expected.html: Added.
+ * compositing/contents-opaque/opaque-with-clip.html: Added.
+
+2014-06-23 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> Adding a mask on a simple color compositing layer removes the content
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=134127
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestscompositingcontentsopaqueopaquewithclipexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/contents-opaque/opaque-with-clip-expected.html (0 => 170307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/contents-opaque/opaque-with-clip-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/contents-opaque/opaque-with-clip-expected.html 2014-06-23 19:00:34 UTC (rev 170307)
</span><span class="lines">@@ -0,0 +1,33 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <style>
+ .box {
+ position: fixed;
+ top: 0;
+ left: 0;
+ width: 300px;
+ height: 300px;
+ background-color: blue;
+ clip: rect(100px, 300px, 200px, 100px);
+ }
+
+ .indicator {
+ position: fixed;
+ top: 50px;
+ left: 50px;
+ width: 50px;
+ height: 50px;
+ top: ;
+ background-color: green;
+ }
+ </style>
+</head>
+<body>
+<div class="indicator"></div>
+<div class="box">
+ &nbsp;
+</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestscompositingcontentsopaqueopaquewithcliphtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/contents-opaque/opaque-with-clip.html (0 => 170307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/contents-opaque/opaque-with-clip.html (rev 0)
+++ trunk/LayoutTests/compositing/contents-opaque/opaque-with-clip.html 2014-06-23 19:00:34 UTC (rev 170307)
</span><span class="lines">@@ -0,0 +1,33 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <style>
+ .box {
+ position: fixed;
+ top: 0;
+ left: 0;
+ width: 300px;
+ height: 300px;
+ background-color: blue;
+ clip: rect(100px, 400px, 200px, 100px);
+ }
+
+ .indicator {
+ position: fixed;
+ top: 50px;
+ left: 50px;
+ width: 50px;
+ height: 50px;
+ top: ;
+ background-color: green;
+ }
+ </style>
+</head>
+<body>
+<div class="indicator"></div>
+<div class="box">
+ &nbsp;
+</div>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestscompositinggeometryclipinsideexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/compositing/geometry/clip-inside-expected.txt (170306 => 170307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/geometry/clip-inside-expected.txt 2014-06-23 19:00:32 UTC (rev 170306)
+++ trunk/LayoutTests/compositing/geometry/clip-inside-expected.txt 2014-06-23 19:00:34 UTC (rev 170307)
</span><span class="lines">@@ -12,7 +12,6 @@
</span><span class="cx"> (position 25.00 35.00)
</span><span class="cx"> (anchor 0.50 0.44)
</span><span class="cx"> (bounds 90.00 80.00)
</span><del>- (contentsOpaque 1)
</del><span class="cx"> (drawsContent 1)
</span><span class="cx"> (transform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 1.00 1.00])
</span><span class="cx"> )
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170306 => 170307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-23 19:00:32 UTC (rev 170306)
+++ trunk/Source/WebCore/ChangeLog 2014-06-23 19:00:34 UTC (rev 170307)
</span><span class="lines">@@ -1,5 +1,24 @@
</span><span class="cx"> 2014-06-23 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><ins>+ CSS clip property should make layers non-opaque
+ https://bugs.webkit.org/show_bug.cgi?id=134147
+ <rdar://problem/17324579>
+
+ Reviewed by Tim Horton.
+
+ https://www.fairphone.com has position:fixed elements with clip: rect(...)
+ but we were making those layers opaque, resulting in garbage pixels
+ in areas outside the clip rect.
+
+ Fix by checking for the clip property in RenderBox::backgroundIsKnownToBeOpaqueInRect().
+
+ Test: compositing/contents-opaque/opaque-with-clip.html
+
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
+
+2014-06-23 Simon Fraser <simon.fraser@apple.com>
+
</ins><span class="cx"> Adding a mask on a simple color compositing layer removes the content
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=134127
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (170306 => 170307)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBox.cpp 2014-06-23 19:00:32 UTC (rev 170306)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2014-06-23 19:00:34 UTC (rev 170307)
</span><span class="lines">@@ -1350,7 +1350,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> // FIXME: Check the opaqueness of background images.
</span><span class="cx">
</span><del>- if (hasClipPath())
</del><ins>+ if (hasClip() || hasClipPath())
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> // FIXME: Use rounded rect if border radius is present.
</span></span></pre>
</div>
</div>
</body>
</html>