<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170248] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170248">170248</a></dd>
<dt>Author</dt> <dd>andersca@apple.com</dd>
<dt>Date</dt> <dd>2014-06-21 11:52:38 -0700 (Sat, 21 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Implement more of HistoryEntryDataDecoder
https://bugs.webkit.org/show_bug.cgi?id=134146
Reviewed by Sam Weinig.
* UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::HistoryEntryDataDecoder::operator>>):
(WebKit::HistoryEntryDataDecoder::decode):
(WebKit::HistoryEntryDataDecoder::decodeFixedLengthData):
(WebKit::HistoryEntryDataDecoder::alignBufferPosition):
(WebKit::HistoryEntryDataDecoder::alignedBuffer):
(WebKit::HistoryEntryDataDecoder::alignedBufferIsLargeEnoughToContain):
(WebKit::HistoryEntryDataDecoder::markInvalid):
(WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacLegacySessionStateCodingcpp">trunk/Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (170247 => 170248)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-06-21 18:27:21 UTC (rev 170247)
+++ trunk/Source/WebKit2/ChangeLog 2014-06-21 18:52:38 UTC (rev 170248)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-06-20 Anders Carlsson <andersca@apple.com>
+
+ Implement more of HistoryEntryDataDecoder
+ https://bugs.webkit.org/show_bug.cgi?id=134146
+
+ Reviewed by Sam Weinig.
+
+ * UIProcess/mac/LegacySessionStateCoding.cpp:
+ (WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
+ (WebKit::HistoryEntryDataDecoder::operator>>):
+ (WebKit::HistoryEntryDataDecoder::decode):
+ (WebKit::HistoryEntryDataDecoder::decodeFixedLengthData):
+ (WebKit::HistoryEntryDataDecoder::alignBufferPosition):
+ (WebKit::HistoryEntryDataDecoder::alignedBuffer):
+ (WebKit::HistoryEntryDataDecoder::alignedBufferIsLargeEnoughToContain):
+ (WebKit::HistoryEntryDataDecoder::markInvalid):
+ (WebKit::LegacySessionStateDecoder::decodeSessionHistoryEntryData):
+
</ins><span class="cx"> 2014-06-21 Commit Queue <commit-queue@webkit.org>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r170244.
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacLegacySessionStateCodingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp (170247 => 170248)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp 2014-06-21 18:27:21 UTC (rev 170247)
+++ trunk/Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp 2014-06-21 18:52:38 UTC (rev 170248)
</span><span class="lines">@@ -50,6 +50,9 @@
</span><span class="cx"> static CFStringRef sessionHistoryEntrySnapshotUUIDKey = CFSTR("SessionHistoryEntrySnapshotUUID");
</span><span class="cx"> static CFStringRef sessionHistoryEntryDataKey = CFSTR("SessionHistoryEntryData");
</span><span class="cx">
</span><ins>+// Session history entry data.
+const uint32_t sessionHistoryEntryDataVersion = 2;
+
</ins><span class="cx"> LegacySessionStateDecoder::LegacySessionStateDecoder(API::Data* data)
</span><span class="cx"> : m_data(data)
</span><span class="cx"> {
</span><span class="lines">@@ -201,11 +204,70 @@
</span><span class="cx"> : m_buffer(buffer)
</span><span class="cx"> , m_bufferEnd(buffer + bufferSize)
</span><span class="cx"> {
</span><ins>+ // Keep format compatibility by decoding an unused uint64_t here.
+ uint64_t value;
+ *this >> value;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+ HistoryEntryDataDecoder& operator>>(uint64_t& value)
+ {
+ value = 0;
+ return decode(value);
+ }
+
+ HistoryEntryDataDecoder& operator>>(uint32_t& value)
+ {
+ value = 0;
+ return decode(value);
+ }
+
</ins><span class="cx"> bool finishDecoding() { return m_buffer == m_bufferEnd; }
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ template<typename Type>
+ HistoryEntryDataDecoder& decode(Type& value)
+ {
+ decodeFixedLengthData(reinterpret_cast<uint8_t*>(&value), sizeof(value), sizeof(value));
+ return *this;
+ }
+
+ void decodeFixedLengthData(uint8_t* data, size_t size, unsigned alignment)
+ {
+ if (!alignBufferPosition(alignment, size))
+ return;
+
+ memcpy(data, m_buffer, size);
+ m_buffer += size;
+ }
+
+ bool alignBufferPosition(unsigned alignment, size_t size)
+ {
+ const uint8_t* alignedPosition = alignedBuffer(alignment);
+ if (!alignedBufferIsLargeEnoughToContain(alignedPosition, size)) {
+ // We've walked off the end of this buffer.
+ markInvalid();
+ return false;
+ }
+
+ m_buffer = alignedPosition;
+ return true;
+ }
+
+ const uint8_t* alignedBuffer(unsigned alignment) const
+ {
+ ASSERT(alignment && !(alignment & (alignment - 1)));
+
+ uintptr_t alignmentMask = alignment - 1;
+ return reinterpret_cast<uint8_t*>((reinterpret_cast<uintptr_t>(m_buffer) + alignmentMask) & ~alignmentMask);
+ }
+
+ inline bool alignedBufferIsLargeEnoughToContain(const uint8_t* alignedPosition, size_t size) const
+ {
+ return m_bufferEnd >= alignedPosition && static_cast<size_t>(m_bufferEnd - alignedPosition) >= size;
+ }
+
+ void markInvalid() { m_buffer = m_bufferEnd + 1; }
+
</ins><span class="cx"> const uint8_t* m_buffer;
</span><span class="cx"> const uint8_t* m_bufferEnd;
</span><span class="cx"> };
</span><span class="lines">@@ -214,6 +276,12 @@
</span><span class="cx"> {
</span><span class="cx"> HistoryEntryDataDecoder decoder { CFDataGetBytePtr(historyEntryData), static_cast<size_t>(CFDataGetLength(historyEntryData)) };
</span><span class="cx">
</span><ins>+ uint32_t version;
+ decoder >> version;
+
+ if (version != sessionHistoryEntryDataVersion)
+ return false;
+
</ins><span class="cx"> // FIXME: Implement this.
</span><span class="cx">
</span><span class="cx"> return decoder.finishDecoding();
</span></span></pre>
</div>
</div>
</body>
</html>