<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170159] branches/ftlopt/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170159">170159</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2014-06-19 13:47:15 -0700 (Thu, 19 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[ftlopt] LICM should be able to hoist CheckStructure even if the loop clobbers structures so long as the structures being checked are watchable
https://bugs.webkit.org/show_bug.cgi?id=134056
Unreviewed, just landing the test cases for this attempted optimization. The test cases
will still be valid once we find a smart way of doing this optimization.
* js/regress/hoist-poly-check-structure-effectful-loop-expected.txt: Added.
* js/regress/hoist-poly-check-structure-effectful-loop.html: Added.
* js/regress/hoist-poly-check-structure-expected.txt: Added.
* js/regress/hoist-poly-check-structure.html: Added.
* js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js: Added.
(foo):
(test):
* js/regress/script-tests/hoist-poly-check-structure.js: Added.
(foo):
(test):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesftloptLayoutTestsChangeLog">branches/ftlopt/LayoutTests/ChangeLog</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#branchesftloptLayoutTestsjsregresshoistpolycheckstructureeffectfulloopexpectedtxt">branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-effectful-loop-expected.txt</a></li>
<li><a href="#branchesftloptLayoutTestsjsregresshoistpolycheckstructureeffectfulloophtml">branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-effectful-loop.html</a></li>
<li><a href="#branchesftloptLayoutTestsjsregresshoistpolycheckstructureexpectedtxt">branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-expected.txt</a></li>
<li><a href="#branchesftloptLayoutTestsjsregresshoistpolycheckstructurehtml">branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure.html</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressscripttestshoistpolycheckstructureeffectfulloopjs">branches/ftlopt/LayoutTests/js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressscripttestshoistpolycheckstructurejs">branches/ftlopt/LayoutTests/js/regress/script-tests/hoist-poly-check-structure.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesftloptLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/LayoutTests/ChangeLog (170158 => 170159)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/ChangeLog 2014-06-19 19:59:14 UTC (rev 170158)
+++ branches/ftlopt/LayoutTests/ChangeLog 2014-06-19 20:47:15 UTC (rev 170159)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-06-19 Filip Pizlo <fpizlo@apple.com>
+
+ [ftlopt] LICM should be able to hoist CheckStructure even if the loop clobbers structures so long as the structures being checked are watchable
+ https://bugs.webkit.org/show_bug.cgi?id=134056
+
+ Unreviewed, just landing the test cases for this attempted optimization. The test cases
+ will still be valid once we find a smart way of doing this optimization.
+
+ * js/regress/hoist-poly-check-structure-effectful-loop-expected.txt: Added.
+ * js/regress/hoist-poly-check-structure-effectful-loop.html: Added.
+ * js/regress/hoist-poly-check-structure-expected.txt: Added.
+ * js/regress/hoist-poly-check-structure.html: Added.
+ * js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js: Added.
+ (foo):
+ (test):
+ * js/regress/script-tests/hoist-poly-check-structure.js: Added.
+ (foo):
+ (test):
+
</ins><span class="cx"> 2014-06-18 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><span class="cx"> DFG AI and constant folder should be able to precisely prune MultiGetByOffset/MultiPutByOffset even if the base structure abstract value is not a singleton
</span></span></pre></div>
<a id="branchesftloptLayoutTestsjsregresshoistpolycheckstructureeffectfulloopexpectedtxt"></a>
<div class="addfile"><h4>Added: branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-effectful-loop-expected.txt (0 => 170159)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-effectful-loop-expected.txt (rev 0)
+++ branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-effectful-loop-expected.txt 2014-06-19 20:47:15 UTC (rev 170159)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+JSRegress/hoist-poly-check-structure-effectful-loop
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS no exception thrown
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="branchesftloptLayoutTestsjsregresshoistpolycheckstructureeffectfulloophtml"></a>
<div class="addfile"><h4>Added: branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-effectful-loop.html (0 => 170159)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-effectful-loop.html (rev 0)
+++ branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-effectful-loop.html 2014-06-19 20:47:15 UTC (rev 170159)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script src="../../resources/regress-pre.js"></script>
+<script src="script-tests/hoist-poly-check-structure-effectful-loop.js"></script>
+<script src="../../resources/regress-post.js"></script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="branchesftloptLayoutTestsjsregresshoistpolycheckstructureexpectedtxt"></a>
<div class="addfile"><h4>Added: branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-expected.txt (0 => 170159)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-expected.txt (rev 0)
+++ branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure-expected.txt 2014-06-19 20:47:15 UTC (rev 170159)
</span><span class="lines">@@ -0,0 +1,10 @@
</span><ins>+JSRegress/hoist-poly-check-structure
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS no exception thrown
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="branchesftloptLayoutTestsjsregresshoistpolycheckstructurehtml"></a>
<div class="addfile"><h4>Added: branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure.html (0 => 170159)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure.html (rev 0)
+++ branches/ftlopt/LayoutTests/js/regress/hoist-poly-check-structure.html 2014-06-19 20:47:15 UTC (rev 170159)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script src="../../resources/regress-pre.js"></script>
+<script src="script-tests/hoist-poly-check-structure.js"></script>
+<script src="../../resources/regress-post.js"></script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressscripttestshoistpolycheckstructureeffectfulloopjs"></a>
<div class="addfile"><h4>Added: branches/ftlopt/LayoutTests/js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js (0 => 170159)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js (rev 0)
+++ branches/ftlopt/LayoutTests/js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js 2014-06-19 20:47:15 UTC (rev 170159)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+function foo(o, p) {
+ var result = 0;
+ for (var i = 0; i < 100; ++i) {
+ result += o.f;
+ p.g = 42;
+ }
+ return result;
+}
+
+noInline(foo);
+
+function test(o) {
+ if (foo(o, {}) != 100)
+ throw new Error("Error: bad result: " + result);
+}
+
+for (var i = 0; i < 100; ++i) {
+ test({f:1, g:2});
+ test({f:1, h:2});
+ test({f:1, i:2});
+ test({f:1, j:2});
+ test({f:1, k:2});
+ test({f:1, l:2});
+}
+
+for (var i = 0; i < 10000; ++i)
+ test({f:1, g:2});
</ins></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressscripttestshoistpolycheckstructurejs"></a>
<div class="addfile"><h4>Added: branches/ftlopt/LayoutTests/js/regress/script-tests/hoist-poly-check-structure.js (0 => 170159)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/script-tests/hoist-poly-check-structure.js (rev 0)
+++ branches/ftlopt/LayoutTests/js/regress/script-tests/hoist-poly-check-structure.js 2014-06-19 20:47:15 UTC (rev 170159)
</span><span class="lines">@@ -0,0 +1,25 @@
</span><ins>+function foo(o) {
+ var result = 0;
+ for (var i = 0; i < 100; ++i)
+ result += o.f;
+ return result;
+}
+
+noInline(foo);
+
+function test(o) {
+ if (foo(o) != 100)
+ throw new Error("Error: bad result: " + result);
+}
+
+for (var i = 0; i < 100; ++i) {
+ test({f:1});
+ test({f:1, g:2});
+ test({f:1, g:2, h:3});
+ test({f:1, g:2, h:3, i:4});
+ test({f:1, g:2, h:3, i:4, j:5});
+ test({f:1, g:2, h:3, i:4, j:5, k:6});
+}
+
+for (var i = 0; i < 10000; ++i)
+ test({f:1});
</ins></span></pre>
</div>
</div>
</body>
</html>