<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170065] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170065">170065</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-06-17 12:03:04 -0700 (Tue, 17 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web process main thread priority is lower than some network process threads.
<https://webkit.org/b/133987>
<rdar://problem/17330300>
Source/WebKit2:
Mark the main thread as "user initiated" in process entry.
Reviewed by Maciej Stachowiak.
* Shared/ChildProcess.cpp:
(WebKit::ChildProcess::initialize):
Source/WTF:
Bring all of our threads to the appropriate priority level by opting in to the
threading QoS APIs. By marking them "user initiated", they still yield to UI
interaction, but take priority over background tasks.
Reviewed by Maciej Stachowiak.
* wtf/Platform.h:
* wtf/Threading.cpp:
(WTF::setCurrentThreadIsUserInitiated):
* wtf/Threading.h:
* wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfPlatformh">trunk/Source/WTF/wtf/Platform.h</a></li>
<li><a href="#trunkSourceWTFwtfThreadingcpp">trunk/Source/WTF/wtf/Threading.cpp</a></li>
<li><a href="#trunkSourceWTFwtfThreadingh">trunk/Source/WTF/wtf/Threading.h</a></li>
<li><a href="#trunkSourceWTFwtfThreadingPthreadscpp">trunk/Source/WTF/wtf/ThreadingPthreads.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedChildProcesscpp">trunk/Source/WebKit2/Shared/ChildProcess.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (170064 => 170065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2014-06-17 19:01:55 UTC (rev 170064)
+++ trunk/Source/WTF/ChangeLog 2014-06-17 19:03:04 UTC (rev 170065)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-06-17 Andreas Kling <akling@apple.com>
+
+ Web process main thread priority is lower than some network process threads.
+ <https://webkit.org/b/133987>
+ <rdar://problem/17330300>
+
+ Bring all of our threads to the appropriate priority level by opting in to the
+ threading QoS APIs. By marking them "user initiated", they still yield to UI
+ interaction, but take priority over background tasks.
+
+ Reviewed by Maciej Stachowiak.
+
+ * wtf/Platform.h:
+ * wtf/Threading.cpp:
+ (WTF::setCurrentThreadIsUserInitiated):
+ * wtf/Threading.h:
+ * wtf/ThreadingPthreads.cpp:
+ (WTF::createThreadInternal):
+
</ins><span class="cx"> 2014-06-17 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Enable css jit for armv7 on iOS.
</span></span></pre></div>
<a id="trunkSourceWTFwtfPlatformh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Platform.h (170064 => 170065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Platform.h 2014-06-17 19:01:55 UTC (rev 170064)
+++ trunk/Source/WTF/wtf/Platform.h 2014-06-17 19:03:04 UTC (rev 170065)
</span><span class="lines">@@ -1001,7 +1001,7 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #ifndef HAVE_QOS_CLASSES
</span><del>-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
</del><ins>+#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000)
</ins><span class="cx"> #define HAVE_QOS_CLASSES 1
</span><span class="cx"> #endif
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWTFwtfThreadingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Threading.cpp (170064 => 170065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Threading.cpp 2014-06-17 19:01:55 UTC (rev 170064)
+++ trunk/Source/WTF/wtf/Threading.cpp 2014-06-17 19:03:04 UTC (rev 170065)
</span><span class="lines">@@ -91,6 +91,13 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void setCurrentThreadIsUserInitiated()
+{
+#if HAVE(QOS_CLASSES)
+ pthread_set_qos_class_self_np(QOS_CLASS_USER_INITIATED, 0);
+#endif
+}
+
</ins><span class="cx"> #if PLATFORM(MAC) || PLATFORM(WIN)
</span><span class="cx">
</span><span class="cx"> // For ABI compatibility with Safari on Mac / Windows: Safari uses the private
</span></span></pre></div>
<a id="trunkSourceWTFwtfThreadingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/Threading.h (170064 => 170065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/Threading.h 2014-06-17 19:01:55 UTC (rev 170064)
+++ trunk/Source/WTF/wtf/Threading.h 2014-06-17 19:03:04 UTC (rev 170065)
</span><span class="lines">@@ -84,6 +84,8 @@
</span><span class="cx"> // Mark the current thread as requiring UI responsiveness.
</span><span class="cx"> WTF_EXPORT_PRIVATE void setCurrentThreadIsUserInteractive();
</span><span class="cx">
</span><ins>+WTF_EXPORT_PRIVATE void setCurrentThreadIsUserInitiated();
+
</ins><span class="cx"> // Internal platform-specific createThread implementation.
</span><span class="cx"> ThreadIdentifier createThreadInternal(ThreadFunction, void*, const char* threadName);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWTFwtfThreadingPthreadscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/ThreadingPthreads.cpp (170064 => 170065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/ThreadingPthreads.cpp 2014-06-17 19:01:55 UTC (rev 170064)
+++ trunk/Source/WTF/wtf/ThreadingPthreads.cpp 2014-06-17 19:03:04 UTC (rev 170065)
</span><span class="lines">@@ -175,7 +175,14 @@
</span><span class="cx"> {
</span><span class="cx"> auto invocation = std::make_unique<ThreadFunctionInvocation>(entryPoint, data);
</span><span class="cx"> pthread_t threadHandle;
</span><del>- if (pthread_create(&threadHandle, 0, wtfThreadEntryPoint, invocation.get())) {
</del><ins>+ pthread_attr_t attr;
+ pthread_attr_init(&attr);
+#if HAVE(QOS_CLASSES)
+ pthread_attr_set_qos_class_np(&attr, QOS_CLASS_USER_INITIATED, 0);
+#endif
+ int error = pthread_create(&threadHandle, &attr, wtfThreadEntryPoint, invocation.get());
+ pthread_attr_destroy(&attr);
+ if (error) {
</ins><span class="cx"> LOG_ERROR("Failed to create pthread at entry point %p with data %p", wtfThreadEntryPoint, invocation.get());
</span><span class="cx"> return 0;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (170064 => 170065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-06-17 19:01:55 UTC (rev 170064)
+++ trunk/Source/WebKit2/ChangeLog 2014-06-17 19:03:04 UTC (rev 170065)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2014-06-17 Andreas Kling <akling@apple.com>
+
+ Web process main thread priority is lower than some network process threads.
+ <https://webkit.org/b/133987>
+ <rdar://problem/17330300>
+
+ Mark the main thread as "user initiated" in process entry.
+
+ Reviewed by Maciej Stachowiak.
+
+ * Shared/ChildProcess.cpp:
+ (WebKit::ChildProcess::initialize):
+
</ins><span class="cx"> 2014-06-17 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Add SPI to get the NSURLRequest from a WKNavigationResponse
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedChildProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/ChildProcess.cpp (170064 => 170065)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/ChildProcess.cpp 2014-06-17 19:01:55 UTC (rev 170064)
+++ trunk/Source/WebKit2/Shared/ChildProcess.cpp 2014-06-17 19:03:04 UTC (rev 170065)
</span><span class="lines">@@ -61,6 +61,8 @@
</span><span class="cx"> {
</span><span class="cx"> platformInitialize();
</span><span class="cx">
</span><ins>+ WTF::setCurrentThreadIsUserInitiated();
+
</ins><span class="cx"> initializeProcess(parameters);
</span><span class="cx"> initializeProcessName(parameters);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>