<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170032] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170032">170032</a></dd>
<dt>Author</dt> <dd>mitz@apple.com</dd>
<dt>Date</dt> <dd>2014-06-16 15:57:16 -0700 (Mon, 16 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre><rdar://problem/17327707> [Cocoa] Expose WebPreferences::storageBlockingPolicy
https://bugs.webkit.org/show_bug.cgi?id=133958
Reviewed by Anders Carlsson.
* UIProcess/API/Cocoa/WKPreferences.mm:
(toStorageBlockingPolicy): Added this helper conversion function.
(toAPI): Ditto.
(-[WKPreferences _storageBlockingPolicy]): Added this getter.
(-[WKPreferences _setStorageBlockingPolicy:]): Added this setter.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h: Declared new _storageBlockingPolicy property
and _WKStorageBlockingPolicy enum. </pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKPreferencesmm">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKPreferencesPrivateh">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (170031 => 170032)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2014-06-16 22:46:58 UTC (rev 170031)
+++ trunk/Source/WebKit2/ChangeLog 2014-06-16 22:57:16 UTC (rev 170032)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-06-16 Dan Bernstein <mitz@apple.com>
+
+ <rdar://problem/17327707> [Cocoa] Expose WebPreferences::storageBlockingPolicy
+ https://bugs.webkit.org/show_bug.cgi?id=133958
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (toStorageBlockingPolicy): Added this helper conversion function.
+ (toAPI): Ditto.
+ (-[WKPreferences _storageBlockingPolicy]): Added this getter.
+ (-[WKPreferences _setStorageBlockingPolicy:]): Added this setter.
+ * UIProcess/API/Cocoa/WKPreferencesPrivate.h: Declared new _storageBlockingPolicy property
+ and _WKStorageBlockingPolicy enum.
+
</ins><span class="cx"> 2014-06-16 Anders Carlsson <andersca@apple.com>
</span><span class="cx">
</span><span class="cx"> Don't use AtomicString in HTTPHeaderMap
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (170031 => 170032)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-06-16 22:46:58 UTC (rev 170031)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-06-16 22:57:16 UTC (rev 170032)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx"> #if WK_API_ENABLED
</span><span class="cx">
</span><span class="cx"> #import "WebPreferences.h"
</span><ins>+#import <WebCore/SecurityOrigin.h>
</ins><span class="cx"> #import <wtf/RetainPtr.h>
</span><span class="cx">
</span><span class="cx"> @implementation WKPreferences
</span><span class="lines">@@ -112,6 +113,46 @@
</span><span class="cx"> _preferences->setTelephoneNumberParsingEnabled(telephoneNumberDetectionIsEnabled);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+static WebCore::SecurityOrigin::StorageBlockingPolicy toStorageBlockingPolicy(_WKStorageBlockingPolicy policy)
+{
+ switch (policy) {
+ case _WKStorageBlockingPolicyAllowAll:
+ return WebCore::SecurityOrigin::AllowAllStorage;
+ case _WKStorageBlockingPolicyBlockThirdParty:
+ return WebCore::SecurityOrigin::BlockThirdPartyStorage;
+ case _WKStorageBlockingPolicyBlockAll:
+ return WebCore::SecurityOrigin::BlockAllStorage;
+ }
+
+ ASSERT_NOT_REACHED();
+ return WebCore::SecurityOrigin::AllowAllStorage;
+}
+
+static _WKStorageBlockingPolicy toAPI(WebCore::SecurityOrigin::StorageBlockingPolicy policy)
+{
+ switch (policy) {
+ case WebCore::SecurityOrigin::AllowAllStorage:
+ return _WKStorageBlockingPolicyAllowAll;
+ case WebCore::SecurityOrigin::BlockThirdPartyStorage:
+ return _WKStorageBlockingPolicyBlockThirdParty;
+ case WebCore::SecurityOrigin::BlockAllStorage:
+ return _WKStorageBlockingPolicyBlockAll;
+ }
+
+ ASSERT_NOT_REACHED();
+ return _WKStorageBlockingPolicyAllowAll;
+}
+
+- (_WKStorageBlockingPolicy)_storageBlockingPolicy
+{
+ return toAPI(static_cast<WebCore::SecurityOrigin::StorageBlockingPolicy>(_preferences->storageBlockingPolicy()));
+}
+
+- (void)_setStorageBlockingPolicy:(_WKStorageBlockingPolicy)policy
+{
+ _preferences->setStorageBlockingPolicy(toStorageBlockingPolicy(policy));
+}
+
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> #endif // WK_API_ENABLED
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h (170031 => 170032)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2014-06-16 22:46:58 UTC (rev 170031)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2014-06-16 22:57:16 UTC (rev 170032)
</span><span class="lines">@@ -31,9 +31,16 @@
</span><span class="cx">
</span><span class="cx"> #if WK_API_ENABLED
</span><span class="cx">
</span><ins>+typedef NS_ENUM(NSInteger, _WKStorageBlockingPolicy) {
+ _WKStorageBlockingPolicyAllowAll,
+ _WKStorageBlockingPolicyBlockThirdParty,
+ _WKStorageBlockingPolicyBlockAll,
+} WK_ENUM_AVAILABLE(10_10, 8_0);
+
</ins><span class="cx"> @interface WKPreferences (WKPrivate)
</span><span class="cx">
</span><span class="cx"> @property (nonatomic, setter=_setTelephoneNumberDetectionIsEnabled:) BOOL _telephoneNumberDetectionIsEnabled;
</span><ins>+@property (nonatomic, setter=_setStorageBlockingPolicy:) _WKStorageBlockingPolicy _storageBlockingPolicy;
</ins><span class="cx">
</span><span class="cx"> @end
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>