<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170015] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170015">170015</a></dd>
<dt>Author</dt> <dd>tonikitoo@webkit.org</dd>
<dt>Date</dt> <dd>2014-06-16 10:41:40 -0700 (Mon, 16 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>"nullable" sequence support is incomplete (i.e. sequence<NativeType>?) https://bugs.webkit.org/show_bug.cgi?id=131240
eeviewed by Darin Adler.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
Nullable sequences are not fully supported in WebKit's
code generator machinery. Although the generated code
does add "is nullable" check to the evaluation condition
(i.e. if (arg.isNull() || ...)), when the JSValue
that holds a "null" JSObject is actually to be "converted"
to a native Vector<T>, it fails.
The reason for the failure is in JSDOMBindings::toNativeArray.
This method verifies that JSValue does not hold a "non-null"
object, and it bails out.
Analogly, the "ref ptr" variant of this method (toRefPtrNativeArray)
does support nullables.
Patch fixes it be checking for a "null" JSValue check before hand.
Tests: Binding tests updated.
* bindings/js/JSDOMBinding.h:
(WebCore::toNativeArray):
* bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
* Modules/websocket/WebSocket.idl:
Removed one overload ctor now that
we can use nullable sequences.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWebSocketidl">trunk/Source/WebCore/Modules/websockets/WebSocket.idl</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBindingh">trunk/Source/WebCore/bindings/js/JSDOMBinding.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjh">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestTestObjidl">trunk/Source/WebCore/bindings/scripts/test/TestObj.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170014 => 170015)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-16 17:23:49 UTC (rev 170014)
+++ trunk/Source/WebCore/ChangeLog 2014-06-16 17:41:40 UTC (rev 170015)
</span><span class="lines">@@ -1,3 +1,35 @@
</span><ins>+2014-04-05 Antonio Gomes <a1.gomes@sisa.samsung.com>
+
+ [Bindings] "nullable" sequence support is incomplete (i.e. sequence<NativeType>?)
+ https://bugs.webkit.org/show_bug.cgi?id=131240
+
+ Reviewed by Darin Adler.
+
+ Nullable sequences are not fully supported in WebKit's
+ code generator machinery. Although the generated code
+ does add "is nullable" check to the evaluation condition
+ (i.e. if (arg.isNull() || ...)), when the JSValue
+ that holds a "null" JSObject is actually to be "converted"
+ to a native Vector<T>, it fails.
+
+ The reason for the failure is in JSDOMBindings::toNativeArray.
+ This method verifies that JSValue does not hold a "non-null"
+ object, and it bails out.
+ Analogly, the "ref ptr" variant of this method (toRefPtrNativeArray)
+ does support nullables.
+
+ Patch fixes it be checking for a "null" JSValue check before hand.
+
+ Tests: Binding tests updated.
+
+ * bindings/js/JSDOMBinding.h:
+ (WebCore::toNativeArray):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (JSValueToNative):
+ * Modules/websocket/WebSocket.idl:
+ Removed one overload ctor now that
+ we can use nullable sequences.
+
</ins><span class="cx"> 2014-06-16 Jer Noble <jer.noble@apple.com>
</span><span class="cx">
</span><span class="cx"> [MSE][Mac] Occasional image corruption after seeking
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWebSocketidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.idl (170014 => 170015)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2014-06-16 17:23:49 UTC (rev 170014)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2014-06-16 17:41:40 UTC (rev 170015)
</span><span class="lines">@@ -34,8 +34,7 @@
</span><span class="cx"> EnabledAtRuntime,
</span><span class="cx"> Conditional=WEB_SOCKETS,
</span><span class="cx"> ActiveDOMObject,
</span><del>- Constructor(DOMString url),
- Constructor(DOMString url, sequence<DOMString> protocols),
</del><ins>+ Constructor(DOMString url, [Default=Undefined] optional sequence<DOMString>? protocols),
</ins><span class="cx"> Constructor(DOMString url, DOMString protocol),
</span><span class="cx"> ConstructorRaisesException,
</span><span class="cx"> ConstructorCallWith=ScriptExecutionContext,
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBindingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (170014 => 170015)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2014-06-16 17:23:49 UTC (rev 170014)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2014-06-16 17:41:40 UTC (rev 170015)
</span><span class="lines">@@ -513,6 +513,10 @@
</span><span class="cx">
</span><span class="cx"> template<typename T> Vector<T> toNativeArray(JSC::ExecState* exec, JSC::JSValue value)
</span><span class="cx"> {
</span><ins>+ JSC::JSObject* object = value.getObject();
+ if (!object)
+ return Vector<T>();
+
</ins><span class="cx"> unsigned length = 0;
</span><span class="cx"> if (isJSArray(value)) {
</span><span class="cx"> JSC::JSArray* array = asArray(value);
</span><span class="lines">@@ -520,7 +524,6 @@
</span><span class="cx"> } else
</span><span class="cx"> toJSSequence(exec, value, length);
</span><span class="cx">
</span><del>- JSC::JSObject* object = value.getObject();
</del><span class="cx"> Vector<T> result;
</span><span class="cx"> result.reserveInitialCapacity(length);
</span><span class="cx"> typedef NativeValueTraits<T> TraitsType;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (170014 => 170015)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2014-06-16 17:23:49 UTC (rev 170014)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2014-06-16 17:41:40 UTC (rev 170015)
</span><span class="lines">@@ -315,7 +315,7 @@
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><del>- { 125, -1 },
</del><ins>+ { 127, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="lines">@@ -333,7 +333,7 @@
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { 5, -1 },
</span><del>- { 133, -1 },
</del><ins>+ { 135, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="lines">@@ -418,11 +418,11 @@
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><del>- { 126, -1 },
</del><ins>+ { 128, -1 },
+ { 121, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><del>- { -1, -1 },
</del><span class="cx"> { 71, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="lines">@@ -500,10 +500,10 @@
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { 8, 512 },
</span><span class="cx"> { -1, -1 },
</span><del>- { 129, -1 },
</del><ins>+ { 131, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { 58, 528 },
</span><del>- { 134, -1 },
</del><ins>+ { 136, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="lines">@@ -512,7 +512,7 @@
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><del>- { 130, -1 },
</del><ins>+ { 132, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { 102, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="lines">@@ -558,8 +558,8 @@
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><del>- { 127, -1 },
- { 122, -1 },
</del><ins>+ { 129, -1 },
+ { 124, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="lines">@@ -586,13 +586,13 @@
</span><span class="cx"> { 43, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><ins>+ { 120, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><del>- { -1, -1 },
</del><span class="cx"> { 12, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { 59, -1 },
</span><span class="lines">@@ -609,7 +609,7 @@
</span><span class="cx"> { 28, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><del>- { 123, -1 },
</del><ins>+ { 125, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { 35, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="lines">@@ -714,7 +714,7 @@
</span><span class="cx"> { 52, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { 73, -1 },
</span><del>- { 131, -1 },
</del><ins>+ { 133, -1 },
</ins><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="lines">@@ -753,11 +753,11 @@
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { 7, 525 },
</span><span class="cx"> { -1, -1 },
</span><del>- { 124, -1 },
</del><ins>+ { 126, -1 },
</ins><span class="cx"> { 105, -1 },
</span><span class="cx"> { 74, 520 },
</span><span class="cx"> { -1, -1 },
</span><del>- { 121, -1 },
</del><ins>+ { 123, -1 },
</ins><span class="cx"> { 82, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="cx"> { -1, -1 },
</span><span class="lines">@@ -780,9 +780,9 @@
</span><span class="cx"> { 103, -1 },
</span><span class="cx"> { 114, -1 },
</span><span class="cx"> { 115, -1 },
</span><del>- { 120, -1 },
- { 128, -1 },
- { 132, -1 },
</del><ins>+ { 122, -1 },
+ { 130, -1 },
+ { 134, -1 },
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -936,6 +936,8 @@
</span><span class="cx"> { "methodWithUnsignedLongSequence", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence), (intptr_t) (1) },
</span><span class="cx"> { "stringArrayFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionStringArrayFunction), (intptr_t) (1) },
</span><span class="cx"> { "domStringListFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionDomStringListFunction), (intptr_t) (1) },
</span><ins>+ { "methodWithAndWithoutNullableSequence", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence), (intptr_t) (2) },
+ { "methodWithAndWithoutNullableSequence2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence2), (intptr_t) (2) },
</ins><span class="cx"> { "getSVGDocument", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionGetSVGDocument), (intptr_t) (0) },
</span><span class="cx"> { "convert1", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionConvert1), (intptr_t) (1) },
</span><span class="cx"> { "convert2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionConvert2), (intptr_t) (1) },
</span><span class="lines">@@ -953,7 +955,7 @@
</span><span class="cx"> { "any", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionAny), (intptr_t) (2) },
</span><span class="cx"> };
</span><span class="cx">
</span><del>-static const HashTable JSTestObjPrototypeTable = { 135, 511, true, JSTestObjPrototypeTableValues, 0, JSTestObjPrototypeTableIndex };
</del><ins>+static const HashTable JSTestObjPrototypeTable = { 137, 511, true, JSTestObjPrototypeTableValues, 0, JSTestObjPrototypeTableIndex };
</ins><span class="cx"> const ClassInfo JSTestObjPrototype::s_info = { "TestObjectPrototype", &Base::s_info, &JSTestObjPrototypeTable, 0, CREATE_METHOD_TABLE(JSTestObjPrototype) };
</span><span class="cx">
</span><span class="cx"> JSObject* JSTestObjPrototype::self(VM& vm, JSGlobalObject* globalObject)
</span><span class="lines">@@ -4363,6 +4365,46 @@
</span><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence(ExecState* exec)
+{
+ JSValue thisValue = exec->thisValue();
+ JSTestObj* castedThis = jsDynamicCast<JSTestObj*>(thisValue);
+ if (UNLIKELY(!castedThis))
+ return throwThisTypeError(*exec, "TestObj", "methodWithAndWithoutNullableSequence");
+ ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
+ TestObj& impl = castedThis->impl();
+ if (exec->argumentCount() < 2)
+ return throwVMError(exec, createNotEnoughArgumentsError(exec));
+ Vector<unsigned> arrayArg(toNativeArray<unsigned>(exec, exec->argument(0)));
+ if (UNLIKELY(exec->hadException()))
+ return JSValue::encode(jsUndefined());
+ Vector<unsigned> nullableArrayArg(toNativeArray<unsigned>(exec, exec->argument(1)));
+ if (UNLIKELY(exec->hadException()))
+ return JSValue::encode(jsUndefined());
+ impl.methodWithAndWithoutNullableSequence(arrayArg, nullableArrayArg);
+ return JSValue::encode(jsUndefined());
+}
+
+EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence2(ExecState* exec)
+{
+ JSValue thisValue = exec->thisValue();
+ JSTestObj* castedThis = jsDynamicCast<JSTestObj*>(thisValue);
+ if (UNLIKELY(!castedThis))
+ return throwThisTypeError(*exec, "TestObj", "methodWithAndWithoutNullableSequence2");
+ ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
+ TestObj& impl = castedThis->impl();
+ if (exec->argumentCount() < 2)
+ return throwVMError(exec, createNotEnoughArgumentsError(exec));
+ Vector<unsigned> arrayArg(toNativeArray<unsigned>(exec, exec->argument(0)));
+ if (UNLIKELY(exec->hadException()))
+ return JSValue::encode(jsUndefined());
+ Vector<unsigned> nullableArrayArg(toNativeArray<unsigned>(exec, exec->argument(1)));
+ if (UNLIKELY(exec->hadException()))
+ return JSValue::encode(jsUndefined());
+ impl.methodWithAndWithoutNullableSequence2(arrayArg, nullableArrayArg);
+ return JSValue::encode(jsUndefined());
+}
+
</ins><span class="cx"> EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionGetSVGDocument(ExecState* exec)
</span><span class="cx"> {
</span><span class="cx"> JSValue thisValue = exec->thisValue();
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h (170014 => 170015)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h 2014-06-16 17:23:49 UTC (rev 170014)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h 2014-06-16 17:41:40 UTC (rev 170015)
</span><span class="lines">@@ -221,6 +221,8 @@
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence(JSC::ExecState*);
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionStringArrayFunction(JSC::ExecState*);
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionDomStringListFunction(JSC::ExecState*);
</span><ins>+JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence(JSC::ExecState*);
+JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence2(JSC::ExecState*);
</ins><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionGetSVGDocument(JSC::ExecState*);
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionConvert1(JSC::ExecState*);
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionConvert2(JSC::ExecState*);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestTestObjidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/TestObj.idl (170014 => 170015)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2014-06-16 17:23:49 UTC (rev 170014)
+++ trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2014-06-16 17:41:40 UTC (rev 170015)
</span><span class="lines">@@ -207,6 +207,9 @@
</span><span class="cx"> void methodWithUnsignedLongSequence(sequence<unsigned long> unsignedLongSequence);
</span><span class="cx"> [RaisesException] DOMString[] stringArrayFunction(DOMString[] values);
</span><span class="cx"> [RaisesException] DOMStringList domStringListFunction(DOMStringList values);
</span><ins>+
+ void methodWithAndWithoutNullableSequence(sequence<unsigned long> arrayArg, sequence<unsigned long>? nullableArrayArg);
+ void methodWithAndWithoutNullableSequence2(unsigned long[] arrayArg, unsigned long[]? nullableArrayArg);
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> [CheckSecurityForNode] readonly attribute Document contentDocument;
</span></span></pre>
</div>
</div>
</body>
</html>