<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[170027] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/170027">170027</a></dd>
<dt>Author</dt> <dd>zandobersek@gmail.com</dd>
<dt>Date</dt> <dd>2014-06-16 14:22:41 -0700 (Mon, 16 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed. Add more GStreamer-specific header names that are required
after changes in <a href="http://trac.webkit.org/projects/webkit/changeset/170021">r170021</a>, fixing the build for ports using GStreamer.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived):
* platform/network/HTTPHeaderNames.in:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsgstreamerWebKitWebSourceGStreamercpp">trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformnetworkHTTPHeaderNamesin">trunk/Source/WebCore/platform/network/HTTPHeaderNames.in</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (170026 => 170027)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-16 21:01:35 UTC (rev 170026)
+++ trunk/Source/WebCore/ChangeLog 2014-06-16 21:22:41 UTC (rev 170027)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2014-06-16 Zan Dobersek <zdobersek@igalia.com>
+
+ Unreviewed. Add more GStreamer-specific header names that are required
+ after changes in r170021, fixing the build for ports using GStreamer.
+
+ * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+ (StreamingClient::handleResponseReceived):
+ * platform/network/HTTPHeaderNames.in:
+
</ins><span class="cx"> 2014-06-16 Chris Fleizach <cfleizach@apple.com>
</span><span class="cx">
</span><span class="cx"> AX: Crash at WebCore::AXObjectCache::textChanged
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsgstreamerWebKitWebSourceGStreamercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (170026 => 170027)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2014-06-16 21:01:35 UTC (rev 170026)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp 2014-06-16 21:22:41 UTC (rev 170027)
</span><span class="lines">@@ -847,34 +847,34 @@
</span><span class="cx"> length += priv->requestedOffset;
</span><span class="cx">
</span><span class="cx"> priv->size = length >= 0 ? length : 0;
</span><del>- priv->seekable = length > 0 && g_ascii_strcasecmp("none", response.httpHeaderField("Accept-Ranges").utf8().data());
</del><ins>+ priv->seekable = length > 0 && g_ascii_strcasecmp("none", response.httpHeaderField(HTTPHeaderName::AcceptRanges).utf8().data());
</ins><span class="cx">
</span><span class="cx"> // Wait until we unlock to send notifications
</span><span class="cx"> g_object_freeze_notify(G_OBJECT(src));
</span><span class="cx">
</span><span class="cx"> GstTagList* tags = gst_tag_list_new_empty();
</span><del>- String value = response.httpHeaderField("icy-name");
</del><ins>+ String value = response.httpHeaderField(HTTPHeaderName::IcyName);
</ins><span class="cx"> if (!value.isEmpty()) {
</span><span class="cx"> g_free(priv->iradioName);
</span><span class="cx"> priv->iradioName = g_strdup(value.utf8().data());
</span><span class="cx"> g_object_notify(G_OBJECT(src), "iradio-name");
</span><span class="cx"> gst_tag_list_add(tags, GST_TAG_MERGE_REPLACE, GST_TAG_ORGANIZATION, priv->iradioName, NULL);
</span><span class="cx"> }
</span><del>- value = response.httpHeaderField("icy-genre");
</del><ins>+ value = response.httpHeaderField(HTTPHeaderName::IcyGenre);
</ins><span class="cx"> if (!value.isEmpty()) {
</span><span class="cx"> g_free(priv->iradioGenre);
</span><span class="cx"> priv->iradioGenre = g_strdup(value.utf8().data());
</span><span class="cx"> g_object_notify(G_OBJECT(src), "iradio-genre");
</span><span class="cx"> gst_tag_list_add(tags, GST_TAG_MERGE_REPLACE, GST_TAG_GENRE, priv->iradioGenre, NULL);
</span><span class="cx"> }
</span><del>- value = response.httpHeaderField("icy-url");
</del><ins>+ value = response.httpHeaderField(HTTPHeaderName::IcyURL);
</ins><span class="cx"> if (!value.isEmpty()) {
</span><span class="cx"> g_free(priv->iradioUrl);
</span><span class="cx"> priv->iradioUrl = g_strdup(value.utf8().data());
</span><span class="cx"> g_object_notify(G_OBJECT(src), "iradio-url");
</span><span class="cx"> gst_tag_list_add(tags, GST_TAG_MERGE_REPLACE, GST_TAG_LOCATION, priv->iradioUrl, NULL);
</span><span class="cx"> }
</span><del>- value = response.httpHeaderField("icy-title");
</del><ins>+ value = response.httpHeaderField(HTTPHeaderName::IcyTitle);
</ins><span class="cx"> if (!value.isEmpty()) {
</span><span class="cx"> g_free(priv->iradioTitle);
</span><span class="cx"> priv->iradioTitle = g_strdup(value.utf8().data());
</span><span class="lines">@@ -892,7 +892,7 @@
</span><span class="cx"> gst_app_src_set_size(priv->appsrc, -1);
</span><span class="cx">
</span><span class="cx"> // icecast stuff
</span><del>- value = response.httpHeaderField("icy-metaint");
</del><ins>+ value = response.httpHeaderField(HTTPHeaderName::IcyMetaInt);
</ins><span class="cx"> if (!value.isEmpty()) {
</span><span class="cx"> gchar* endptr = 0;
</span><span class="cx"> gint64 icyMetaInt = g_ascii_strtoll(value.utf8().data(), &endptr, 10);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformnetworkHTTPHeaderNamesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/network/HTTPHeaderNames.in (170026 => 170027)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/network/HTTPHeaderNames.in 2014-06-16 21:01:35 UTC (rev 170026)
+++ trunk/Source/WebCore/platform/network/HTTPHeaderNames.in 2014-06-16 21:22:41 UTC (rev 170027)
</span><span class="lines">@@ -92,5 +92,11 @@
</span><span class="cx"> X-WebKit-CSP-Report-Only
</span><span class="cx">
</span><span class="cx"> // These headers are specific to GStreamer.
</span><ins>+Accept-Ranges
+Icy-Genre
+Icy-MetaInt
</ins><span class="cx"> Icy-Metadata
</span><ins>+Icy-Name
+Icy-Title
+Icy-URL
</ins><span class="cx"> TransferMode.DLNA
</span></span></pre>
</div>
</div>
</body>
</html>