<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169823] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169823">169823</a></dd>
<dt>Author</dt> <dd>akling@apple.com</dd>
<dt>Date</dt> <dd>2014-06-11 13:16:42 -0700 (Wed, 11 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Always inline JSValue::get() and Structure::get().
<https://webkit.org/b/133755>
Reviewed by Ryosuke Niwa.
These functions get really hot, so ask the compiler to be more
aggressive about inlining them.
~28% speed-up on Ryosuke's microbenchmark for accessing nextSibling
through GetByVal.
* runtime/JSArrayIterator.cpp:
* runtime/JSCJSValue.cpp:
* runtime/JSCJSValueInlines.h:
(JSC::JSValue::get):
* runtime/JSPromiseDeferred.cpp:
* runtime/StructureInlines.h:
(JSC::Structure::get):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSArrayIteratorcpp">trunk/Source/JavaScriptCore/runtime/JSArrayIterator.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSCJSValueInlinesh">trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeJSPromiseDeferredcpp">trunk/Source/JavaScriptCore/runtime/JSPromiseDeferred.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeStructureInlinesh">trunk/Source/JavaScriptCore/runtime/StructureInlines.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (169822 => 169823)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2014-06-11 20:15:30 UTC (rev 169822)
+++ trunk/Source/JavaScriptCore/ChangeLog 2014-06-11 20:16:42 UTC (rev 169823)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-06-11 Andreas Kling <akling@apple.com>
+
+ Always inline JSValue::get() and Structure::get().
+ <https://webkit.org/b/133755>
+
+ Reviewed by Ryosuke Niwa.
+
+ These functions get really hot, so ask the compiler to be more
+ aggressive about inlining them.
+
+ ~28% speed-up on Ryosuke's microbenchmark for accessing nextSibling
+ through GetByVal.
+
+ * runtime/JSArrayIterator.cpp:
+ * runtime/JSCJSValue.cpp:
+ * runtime/JSCJSValueInlines.h:
+ (JSC::JSValue::get):
+ * runtime/JSPromiseDeferred.cpp:
+ * runtime/StructureInlines.h:
+ (JSC::Structure::get):
+
</ins><span class="cx"> 2014-06-11 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Structure::get should instantiate DeferGC only when materializing property map
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSArrayIteratorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSArrayIterator.cpp (169822 => 169823)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSArrayIterator.cpp 2014-06-11 20:15:30 UTC (rev 169822)
+++ trunk/Source/JavaScriptCore/runtime/JSArrayIterator.cpp 2014-06-11 20:16:42 UTC (rev 169823)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx"> #include "JSCJSValueInlines.h"
</span><span class="cx"> #include "JSCellInlines.h"
</span><span class="cx"> #include "SlotVisitorInlines.h"
</span><ins>+#include "StructureInlines.h"
</ins><span class="cx">
</span><span class="cx"> namespace JSC {
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSCJSValueInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h (169822 => 169823)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h 2014-06-11 20:15:30 UTC (rev 169822)
+++ trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h 2014-06-11 20:16:42 UTC (rev 169823)
</span><span class="lines">@@ -665,13 +665,13 @@
</span><span class="cx"> return isCell() ? asCell()->methodTable(exec->vm())->toThis(asCell(), exec, ecmaMode) : toThisSlowCase(exec, ecmaMode);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline JSValue JSValue::get(ExecState* exec, PropertyName propertyName) const
</del><ins>+ALWAYS_INLINE JSValue JSValue::get(ExecState* exec, PropertyName propertyName) const
</ins><span class="cx"> {
</span><span class="cx"> PropertySlot slot(asValue());
</span><span class="cx"> return get(exec, propertyName, slot);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline JSValue JSValue::get(ExecState* exec, PropertyName propertyName, PropertySlot& slot) const
</del><ins>+ALWAYS_INLINE JSValue JSValue::get(ExecState* exec, PropertyName propertyName, PropertySlot& slot) const
</ins><span class="cx"> {
</span><span class="cx"> // If this is a primitive, we'll need to synthesize the prototype -
</span><span class="cx"> // and if it's a string there are special properties to check first.
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeJSPromiseDeferredcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/JSPromiseDeferred.cpp (169822 => 169823)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/JSPromiseDeferred.cpp 2014-06-11 20:15:30 UTC (rev 169822)
+++ trunk/Source/JavaScriptCore/runtime/JSPromiseDeferred.cpp 2014-06-11 20:16:42 UTC (rev 169823)
</span><span class="lines">@@ -35,6 +35,7 @@
</span><span class="cx"> #include "JSPromiseConstructor.h"
</span><span class="cx"> #include "JSPromiseFunctions.h"
</span><span class="cx"> #include "SlotVisitorInlines.h"
</span><ins>+#include "StructureInlines.h"
</ins><span class="cx">
</span><span class="cx"> namespace JSC {
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeStructureInlinesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/StructureInlines.h (169822 => 169823)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/StructureInlines.h 2014-06-11 20:15:30 UTC (rev 169822)
+++ trunk/Source/JavaScriptCore/runtime/StructureInlines.h 2014-06-11 20:16:42 UTC (rev 169823)
</span><span class="lines">@@ -73,7 +73,7 @@
</span><span class="cx"> return object->structure();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline PropertyOffset Structure::get(VM& vm, PropertyName propertyName)
</del><ins>+ALWAYS_INLINE PropertyOffset Structure::get(VM& vm, PropertyName propertyName)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!isCompilationThread());
</span><span class="cx"> ASSERT(structure()->classInfo() == info());
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> return entry ? entry->offset : invalidOffset;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline PropertyOffset Structure::get(VM& vm, const WTF::String& name)
</del><ins>+ALWAYS_INLINE PropertyOffset Structure::get(VM& vm, const WTF::String& name)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!isCompilationThread());
</span><span class="cx"> ASSERT(structure()->classInfo() == info());
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx"> return entry ? entry->offset : invalidOffset;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline PropertyOffset Structure::get(VM& vm, PropertyName propertyName, unsigned& attributes, JSCell*& specificValue)
</del><ins>+ALWAYS_INLINE PropertyOffset Structure::get(VM& vm, PropertyName propertyName, unsigned& attributes, JSCell*& specificValue)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(!isCompilationThread());
</span><span class="cx"> ASSERT(structure()->classInfo() == info());
</span></span></pre>
</div>
</div>
</body>
</html>