<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169747] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169747">169747</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2014-06-10 10:19:05 -0700 (Tue, 10 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: WK2: iOS: text editing does not work
https://bugs.webkit.org/show_bug.cgi?id=133666
Reviewed by Mario Sanchez Prada.
In WK2, all the text editing is handled by the WebProcess, so selectedTextRange and setSelectedTextRange
need to be implemented, as well as posting the right value change notification.
* accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::postPlatformNotification):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper postValueChangedNotification]):
(-[WebAccessibilityObjectWrapper _accessibilitySelectedTextRange]):
(-[WebAccessibilityObjectWrapper _accessibilitySetSelectedTextRange:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosAXObjectCacheIOSmm">trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSh">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm">trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169746 => 169747)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-10 16:02:03 UTC (rev 169746)
+++ trunk/Source/WebCore/ChangeLog 2014-06-10 17:19:05 UTC (rev 169747)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2014-06-10 Chris Fleizach <cfleizach@apple.com>
+
+ AX: WK2: iOS: text editing does not work
+ https://bugs.webkit.org/show_bug.cgi?id=133666
+
+ Reviewed by Mario Sanchez Prada.
+
+ In WK2, all the text editing is handled by the WebProcess, so selectedTextRange and setSelectedTextRange
+ need to be implemented, as well as posting the right value change notification.
+
+ * accessibility/ios/AXObjectCacheIOS.mm:
+ (WebCore::AXObjectCache::postPlatformNotification):
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper postValueChangedNotification]):
+ (-[WebAccessibilityObjectWrapper _accessibilitySelectedTextRange]):
+ (-[WebAccessibilityObjectWrapper _accessibilitySetSelectedTextRange:]):
+
</ins><span class="cx"> 2014-06-10 Andreas Kling <akling@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS WebKit2] Stay in "memory pressure" mode until told otherwise.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosAXObjectCacheIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm (169746 => 169747)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm 2014-06-10 16:02:03 UTC (rev 169746)
+++ trunk/Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm 2014-06-10 17:19:05 UTC (rev 169747)
</span><span class="lines">@@ -82,8 +82,10 @@
</span><span class="cx"> case AXInvalidStatusChanged:
</span><span class="cx"> [obj->wrapper() postInvalidStatusChangedNotification];
</span><span class="cx"> break;
</span><ins>+ case AXValueChanged:
+ [obj->wrapper() postValueChangedNotification];
+ break;
</ins><span class="cx"> case AXSelectedChildrenChanged:
</span><del>- case AXValueChanged:
</del><span class="cx"> case AXCheckedStateChanged:
</span><span class="cx"> default:
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h (169746 => 169747)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h 2014-06-10 16:02:03 UTC (rev 169746)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h 2014-06-10 17:19:05 UTC (rev 169747)
</span><span class="lines">@@ -62,6 +62,7 @@
</span><span class="cx"> - (void)postInvalidStatusChangedNotification;
</span><span class="cx"> - (void)postLiveRegionCreatedNotification;
</span><span class="cx"> - (void)postScrollStatusChangeNotification;
</span><ins>+- (void)postValueChangedNotification;
</ins><span class="cx">
</span><span class="cx"> @end
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityiosWebAccessibilityObjectWrapperIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (169746 => 169747)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-06-10 16:02:03 UTC (rev 169746)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2014-06-10 17:19:05 UTC (rev 169747)
</span><span class="lines">@@ -1479,6 +1479,11 @@
</span><span class="cx"> // The UIKit accessibility wrapper will override and post appropriate notification.
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (void)postValueChangedNotification
+{
+ // The UIKit accessibility wrapper will override and post appropriate notification.
+}
+
</ins><span class="cx"> - (void)postScrollStatusChangeNotification
</span><span class="cx"> {
</span><span class="cx"> // The UIKit accessibility wrapper will override and post appropriate notification.
</span><span class="lines">@@ -2030,6 +2035,25 @@
</span><span class="cx"> return [self _stringForRange:range attributed:YES];
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (NSRange)_accessibilitySelectedTextRange
+{
+ if (![self _prepareAccessibilityCall] || !m_object->isTextControl())
+ return NSMakeRange(NSNotFound, 0);
+
+ PlainTextRange textRange = m_object->selectedTextRange();
+ if (textRange.isNull())
+ return NSMakeRange(NSNotFound, 0);
+ return NSMakeRange(textRange.start, textRange.length);
+}
+
+- (void)_accessibilitySetSelectedTextRange:(NSRange)range
+{
+ if (![self _prepareAccessibilityCall] || !m_object->isTextControl())
+ return;
+
+ m_object->setSelectedTextRange(PlainTextRange(range.location, range.length));
+}
+
</ins><span class="cx"> // A convenience method for getting the accessibility objects of a NSRange. Currently used only by DRT.
</span><span class="cx"> - (NSArray *)elementsForRange:(NSRange)range
</span><span class="cx"> {
</span></span></pre>
</div>
</div>
</body>
</html>