<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169689] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169689">169689</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-06-09 09:01:14 -0700 (Mon, 09 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[SVG] Subpixel rendering: Mask with transformed text does not render.
https://bugs.webkit.org/show_bug.cgi?id=133626
<rdar://problem/17123070>
Reviewed by Simon Fraser.
Replace IntRect::infiniteRect() with Layout::infiniteRect(). A transformed IntRect::infiniteRect()
overflows and produces invalid repaint rect. -also remove IntRect::infiniteRect() as no one calls
it anymore.
Source/WebCore:
Tests: svg/masking/mask-transformed-text-missing-expected.svg
svg/masking/mask-transformed-text-missing.svg
* platform/graphics/IntRect.h:
(WebCore::IntRect::infiniteRect): Deleted.
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):
LayoutTests:
* svg/masking/mask-transformed-text-missing-expected.svg: Added.
* svg/masking/mask-transformed-text-missing.svg: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsIntRecth">trunk/Source/WebCore/platform/graphics/IntRect.h</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgSVGRenderingContextcpp">trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgmaskingmasktransformedtextmissingexpectedsvg">trunk/LayoutTests/svg/masking/mask-transformed-text-missing-expected.svg</a></li>
<li><a href="#trunkLayoutTestssvgmaskingmasktransformedtextmissingsvg">trunk/LayoutTests/svg/masking/mask-transformed-text-missing.svg</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169688 => 169689)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2014-06-09 10:29:46 UTC (rev 169688)
+++ trunk/LayoutTests/ChangeLog        2014-06-09 16:01:14 UTC (rev 169689)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2014-06-09 Zalan Bujtas <zalan@apple.com>
+
+ [SVG] Subpixel rendering: Mask with transformed text does not render.
+ https://bugs.webkit.org/show_bug.cgi?id=133626
+ <rdar://problem/17123070>
+
+ Reviewed by Simon Fraser.
+
+ Replace IntRect::infiniteRect() with Layout::infiniteRect(). A transformed IntRect::infiniteRect()
+ overflows and produces invalid repaint rect. -also remove IntRect::infiniteRect() as no one calls
+ it anymore.
+
+ * svg/masking/mask-transformed-text-missing-expected.svg: Added.
+ * svg/masking/mask-transformed-text-missing.svg: Added.
+
</ins><span class="cx"> 2014-06-05 Grzegorz Czajkowski <g.czajkowski@samsung.com>
</span><span class="cx">
</span><span class="cx"> Share mac/editing/spelling/editing-word-with-marker-2.html with other platforms
</span></span></pre></div>
<a id="trunkLayoutTestssvgmaskingmasktransformedtextmissingexpectedsvg"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/masking/mask-transformed-text-missing-expected.svg (0 => 169689)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/masking/mask-transformed-text-missing-expected.svg         (rev 0)
+++ trunk/LayoutTests/svg/masking/mask-transformed-text-missing-expected.svg        2014-06-09 16:01:14 UTC (rev 169689)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="100px" height="100px">
+ <text fill="#000" font-family="Ahem" font-size="12px" transform="rotate(90 50 50)" x="50" y="50">foobar</text>
+</svg>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestssvgmaskingmasktransformedtextmissingsvg"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/masking/mask-transformed-text-missing.svg (0 => 169689)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/masking/mask-transformed-text-missing.svg         (rev 0)
+++ trunk/LayoutTests/svg/masking/mask-transformed-text-missing.svg        2014-06-09 16:01:14 UTC (rev 169689)
</span><span class="lines">@@ -0,0 +1,8 @@
</span><ins>+<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="100px" height="100px">
+ <defs xmlns="http://www.w3.org/2000/svg">
+ <mask id="mask">
+ <text fill="#fff" font-family="Ahem" font-size="12px" transform="rotate(90 50 50)" x="50%" y='50%'>foobar</text>
+ </mask>
+ </defs>
+ <rect width="100%" height="100%" x="0" y="0" mask="url(#mask)"/>
+</svg>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169688 => 169689)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog        2014-06-09 10:29:46 UTC (rev 169688)
+++ trunk/Source/WebCore/ChangeLog        2014-06-09 16:01:14 UTC (rev 169689)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2014-06-09 Zalan Bujtas <zalan@apple.com>
+
+ [SVG] Subpixel rendering: Mask with transformed text does not render.
+ https://bugs.webkit.org/show_bug.cgi?id=133626
+ <rdar://problem/17123070>
+
+ Reviewed by Simon Fraser.
+
+ Replace IntRect::infiniteRect() with Layout::infiniteRect(). A transformed IntRect::infiniteRect()
+ overflows and produces invalid repaint rect. -also remove IntRect::infiniteRect() as no one calls
+ it anymore.
+
+ Tests: svg/masking/mask-transformed-text-missing-expected.svg
+ svg/masking/mask-transformed-text-missing.svg
+
+ * platform/graphics/IntRect.h:
+ (WebCore::IntRect::infiniteRect): Deleted.
+ * rendering/svg/SVGRenderingContext.cpp:
+ (WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):
+
</ins><span class="cx"> 2014-06-08 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> [Mac] checkboxes and radio buttons animate incorrectly
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsIntRecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/IntRect.h (169688 => 169689)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/IntRect.h        2014-06-09 10:29:46 UTC (rev 169688)
+++ trunk/Source/WebCore/platform/graphics/IntRect.h        2014-06-09 16:01:14 UTC (rev 169689)
</span><span class="lines">@@ -196,9 +196,6 @@
</span><span class="cx">
</span><span class="cx"> void dump(WTF::PrintStream& out) const;
</span><span class="cx">
</span><del>- static IntRect infiniteRect();
- bool isInfinite() const;
-
</del><span class="cx"> private:
</span><span class="cx"> IntPoint m_location;
</span><span class="cx"> IntSize m_size;
</span><span class="lines">@@ -228,17 +225,6 @@
</span><span class="cx"> return a.location() != b.location() || a.size() != b.size();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline IntRect IntRect::infiniteRect()
-{
- static IntRect infiniteRect(-LayoutUnit::max() / 2, -LayoutUnit::max() / 2, LayoutUnit::max(), LayoutUnit::max());
- return infiniteRect;
-}
-
-inline bool IntRect::isInfinite() const
-{
- return *this == infiniteRect();
-}
-
</del><span class="cx"> #if USE(CG)
</span><span class="cx"> IntRect enclosingIntRect(const CGRect&);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgSVGRenderingContextcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp (169688 => 169689)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp        2014-06-09 10:29:46 UTC (rev 169688)
+++ trunk/Source/WebCore/rendering/svg/SVGRenderingContext.cpp        2014-06-09 16:01:14 UTC (rev 169689)
</span><span class="lines">@@ -298,7 +298,7 @@
</span><span class="cx"> ASSERT(image);
</span><span class="cx"> ASSERT(image->context());
</span><span class="cx">
</span><del>- PaintInfo info(image->context(), IntRect::infiniteRect(), PaintPhaseForeground, PaintBehaviorNormal);
</del><ins>+ PaintInfo info(image->context(), LayoutRect::infiniteRect(), PaintPhaseForeground, PaintBehaviorNormal);
</ins><span class="cx">
</span><span class="cx"> AffineTransform& contentTransformation = currentContentTransformation();
</span><span class="cx"> AffineTransform savedContentTransformation = contentTransformation;
</span></span></pre>
</div>
</div>
</body>
</html>