<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169687] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169687">169687</a></dd>
<dt>Author</dt> <dd>g.czajkowski@samsung.com</dd>
<dt>Date</dt> <dd>2014-06-08 23:58:00 -0700 (Sun, 08 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Share mac/editing/spelling/editing-word-with-marker-2.html with other platforms
https://bugs.webkit.org/show_bug.cgi?id=133544
Reviewed by Darin Adler.
Move mac/editing/spelling/editing-word-with-marker-2.html into
common editing/spelling to be available for other platforms.
Additionally, verify spelling markers asynchronously as the sync
path it's likely to be removed.
Add test case which tests spelling markers without any
selection change.
* editing/spelling/editing-word-with-marker-2-expected.txt:
Renamed from platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt.
* editing/spelling/editing-word-with-marker-2.html:
Renamed from platform/mac/editing/spelling/editing-word-with-marker-2.html.
* platform/gtk/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
Mark editing/spelling/editing-word-with-marker-2.html as failing since those
platforms didn't turn on asynchronous spellchecking.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacwk2TestExpectations">trunk/LayoutTests/platform/mac-wk2/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformwinTestExpectations">trunk/LayoutTests/platform/win/TestExpectations</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestseditingspellingeditingwordwithmarker2expectedtxt">trunk/LayoutTests/editing/spelling/editing-word-with-marker-2-expected.txt</a></li>
<li><a href="#trunkLayoutTestseditingspellingeditingwordwithmarker2html">trunk/LayoutTests/editing/spelling/editing-word-with-marker-2.html</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmaceditingspellingeditingwordwithmarker2expectedtxt">trunk/LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmaceditingspellingeditingwordwithmarker2html">trunk/LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-2.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169686 => 169687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-06-09 06:26:27 UTC (rev 169686)
+++ trunk/LayoutTests/ChangeLog 2014-06-09 06:58:00 UTC (rev 169687)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2014-06-05 Grzegorz Czajkowski <g.czajkowski@samsung.com>
+
+ Share mac/editing/spelling/editing-word-with-marker-2.html with other platforms
+ https://bugs.webkit.org/show_bug.cgi?id=133544
+
+ Reviewed by Darin Adler.
+
+ Move mac/editing/spelling/editing-word-with-marker-2.html into
+ common editing/spelling to be available for other platforms.
+
+ Additionally, verify spelling markers asynchronously as the sync
+ path it's likely to be removed.
+
+ Add test case which tests spelling markers without any
+ selection change.
+
+ * editing/spelling/editing-word-with-marker-2-expected.txt:
+ Renamed from platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt.
+
+ * editing/spelling/editing-word-with-marker-2.html:
+ Renamed from platform/mac/editing/spelling/editing-word-with-marker-2.html.
+
+ * platform/gtk/TestExpectations:
+ * platform/mac-wk2/TestExpectations:
+ * platform/win/TestExpectations:
+ Mark editing/spelling/editing-word-with-marker-2.html as failing since those
+ platforms didn't turn on asynchronous spellchecking.
+
</ins><span class="cx"> 2014-06-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed EFL gardening. Skip a test which generates "No bad fd found." error.
</span></span></pre></div>
<a id="trunkLayoutTestseditingspellingeditingwordwithmarker2expectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/spelling/editing-word-with-marker-2-expected.txt (0 => 169687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/spelling/editing-word-with-marker-2-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/spelling/editing-word-with-marker-2-expected.txt 2014-06-09 06:58:00 UTC (rev 169687)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+The test verifies if the spelling markers remain if a whitespace is added before or after the misspelled word. The test succeeds if the word 'meagesga' has red underline.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS internals.hasSpellingMarker(expectedMisspelledPosition, 8) became true
+
+execMoveSelectionBackwardByWordCommand()
+typeCharacterCommand(' ')
+PASS internals.hasSpellingMarker(expectedMisspelledPosition, 8) became true
+
+execMoveSelectionBackwardByCharacterCommand()
+typeCharacterCommand(' ')
+PASS internals.hasSpellingMarker(expectedMisspelledPosition, 8) became true
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins><span class="cx">Property changes on: trunk/LayoutTests/editing/spelling/editing-word-with-marker-2-expected.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkLayoutTestseditingspellingeditingwordwithmarker2html"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/editing/spelling/editing-word-with-marker-2.html (0 => 169687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/editing/spelling/editing-word-with-marker-2.html (rev 0)
+++ trunk/LayoutTests/editing/spelling/editing-word-with-marker-2.html 2014-06-09 06:58:00 UTC (rev 169687)
</span><span class="lines">@@ -0,0 +1,90 @@
</span><ins>+<html>
+<head>
+<script src="../editing.js"></script>
+</head>
+<body>
+<textarea id="test"></textarea>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("The test verifies if the spelling markers remain if a whitespace "
+ + "is added before or after the misspelled word. "
+ + "The test succeeds if the word 'meagesga' has red underline.");
+
+jsTestIsAsync = true;
+
+if (window.internals) {
+ internals.settings.setUnifiedTextCheckerEnabled(true);
+ internals.settings.setAsynchronousSpellCheckingEnabled(true);
+}
+
+function resetText() {
+ document.getElementById('test').focus();
+ execSelectAllCommand();
+ execDeleteCommand();
+ typeCharacterCommand('i');
+ typeCharacterCommand('t');
+ typeCharacterCommand('\'');
+ typeCharacterCommand('s');
+ typeCharacterCommand(' ');
+ typeCharacterCommand('a');
+ typeCharacterCommand(' ');
+ typeCharacterCommand('m');
+ typeCharacterCommand('e');
+ typeCharacterCommand('a');
+ typeCharacterCommand('g');
+ typeCharacterCommand('e');
+ typeCharacterCommand('s');
+ typeCharacterCommand('g');
+ typeCharacterCommand('a');
+ typeCharacterCommand(' ');
+}
+
+var expectedMisspelledPosition;
+function checkSpellingMarkerAfterAddingWhitespace(testCase)
+{
+ resetText();
+
+ if (testCase.updateCaretPosition) {
+ testCase.updateCaretPosition();
+ evalAndLog("typeCharacterCommand(' ')");
+ }
+
+ expectedMisspelledPosition = testCase.misspelledPosition;
+
+ if (window.internals) {
+ shouldBecomeEqual("internals.hasSpellingMarker(expectedMisspelledPosition, 8)", "true", function() {
+ debug("");
+ done();
+ });
+ } else
+ done();
+}
+
+var testCases = [
+ {
+ updateCaretPosition: null,
+ misspelledPosition: 7
+ },
+ {
+ updateCaretPosition: function() { evalAndLog("execMoveSelectionBackwardByWordCommand()"); },
+ misspelledPosition: 8
+ },
+ {
+ updateCaretPosition: function() { evalAndLog("execMoveSelectionBackwardByCharacterCommand()"); },
+ misspelledPosition: 7
+ }
+];
+
+function done()
+{
+ var testCase = testCases.shift();
+ if (testCase)
+ return setTimeout(checkSpellingMarkerAfterAddingWhitespace(testCase), 0);
+
+ finishJSTest();
+}
+done();
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins><span class="cx">Property changes on: trunk/LayoutTests/editing/spelling/editing-word-with-marker-2.html
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4>Added: svn:eol-style</h4></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (169686 => 169687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-06-09 06:26:27 UTC (rev 169686)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-06-09 06:58:00 UTC (rev 169687)
</span><span class="lines">@@ -1133,6 +1133,7 @@
</span><span class="cx"> # Missing TextChecker::requestCheckingOfString() implementation for Gtk.
</span><span class="cx"> webkit.org/b/73003 editing/spelling/delete-into-misspelled-word.html [ Skip ]
</span><span class="cx"> webkit.org/b/73003 editing/spelling/editing-multiple-words-with-markers.html [ Skip ]
</span><ins>+webkit.org/b/73003 editing/spelling/editing-word-with-marker-2.html [ Skip ]
</ins><span class="cx"> webkit.org/b/73003 editing/spelling/move-cursor-around-misspelled-word.html [ Skip ]
</span><span class="cx"> webkit.org/b/73003 editing/spelling/spellcheck-async-mutation.html [ Skip ]
</span><span class="cx"> webkit.org/b/73003 editing/spelling/spellcheck-async-remove-frame.html [ Skip ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmaceditingspellingeditingwordwithmarker2expectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt (169686 => 169687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt 2014-06-09 06:26:27 UTC (rev 169686)
+++ trunk/LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-2-expected.txt 2014-06-09 06:58:00 UTC (rev 169687)
</span><span class="lines">@@ -1,6 +0,0 @@
</span><del>-The test verified that when appending a whitespace before or after a word, its Spelling and Autocorrection markers are remain. When manully testing, type "it's a meagesga", then add whitespace before or after "meagesga". You should see the underline on "meagesga".
-
-
-SUCCESS
-SUCCESS
-
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmaceditingspellingeditingwordwithmarker2html"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-2.html (169686 => 169687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-2.html 2014-06-09 06:26:27 UTC (rev 169686)
+++ trunk/LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-2.html 2014-06-09 06:58:00 UTC (rev 169687)
</span><span class="lines">@@ -1,65 +0,0 @@
</span><del>-<html>
-<head>
-<script src=../../../../editing/editing.js language="javascript" type="text/javascript"></script>
-<title>Editing word with marker test 2</title>
-</head>
-<body>
-<p>The test verified that when appending a whitespace before or after a word, its Spelling and
-Autocorrection markers are remain.
-When manully testing, type "it's a meagesga", then add whitespace before or after "meagesga".
-You should see the underline on "meagesga".</p>
-<textarea id="test" cols="80" rows="10"></textarea>
-<div id="console"></div>
-<script language="javascript" type="text/javascript">
-function resetText() {
- document.getElementById('test').focus();
- execSelectAllCommand();
- execDeleteCommand();
- typeCharacterCommand('i');
- typeCharacterCommand('t');
- typeCharacterCommand('\'');
- typeCharacterCommand('s');
- typeCharacterCommand(' ');
- typeCharacterCommand('a');
- typeCharacterCommand(' ');
- typeCharacterCommand('m');
- typeCharacterCommand('e');
- typeCharacterCommand('a');
- typeCharacterCommand('g');
- typeCharacterCommand('e');
- typeCharacterCommand('s');
- typeCharacterCommand('g');
- typeCharacterCommand('a');
- typeCharacterCommand(' ');
-}
-
-if (window.testRunner) {
- testRunner.dumpAsText();
-}
-
-resetText();
-textarea = document.getElementById('test');
-textarea.setSelectionRange(7,7);
-typeCharacterCommand(' ');
-if (window.internals && window.internals.hasSpellingMarker) {
- if (window.internals.hasSpellingMarker(8,8) == 1) {
- document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + 'SUCCESS<br>';
- } else {
- document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + "FAILURE. The word 'meagesga' doesn't have underline.<br>";
- }
-}
-
-resetText();
-textarea = document.getElementById('test');
-textarea.setSelectionRange(15,15);
-typeCharacterCommand(' ');
-if (window.internals && window.internals.hasSpellingMarker) {
- if (window.internals.hasSpellingMarker(7,8) == 1) {
- document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + 'SUCCESS<br>';
- } else {
- document.getElementById('console').innerHTML = document.getElementById('console').innerHTML + "FAILURE. The word 'meagesga' doesn't have underline.<br>";
- }
-}
-</script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsplatformmacwk2TestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (169686 => 169687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-06-09 06:26:27 UTC (rev 169686)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2014-06-09 06:58:00 UTC (rev 169687)
</span><span class="lines">@@ -121,6 +121,7 @@
</span><span class="cx"> webkit.org/b/105616 editing/spelling/context-menu-suggestions-subword-selection.html
</span><span class="cx"> webkit.org/b/105616 editing/spelling/delete-into-misspelled-word.html
</span><span class="cx"> webkit.org/b/105616 editing/spelling/editing-multiple-words-with-markers.html
</span><ins>+webkit.org/b/105616 editing/spelling/editing-word-with-marker-2.html
</ins><span class="cx"> webkit.org/b/105616 editing/spelling/move-cursor-around-misspelled-word.html
</span><span class="cx"> webkit.org/b/105616 editing/inserting/inserting-slash-inside-url-with-smart-link.html
</span><span class="cx"> webkit.org/b/105616 editing/spelling/spelling-changed-text.html
</span></span></pre></div>
<a id="trunkLayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/win/TestExpectations (169686 => 169687)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/win/TestExpectations 2014-06-09 06:26:27 UTC (rev 169686)
+++ trunk/LayoutTests/platform/win/TestExpectations 2014-06-09 06:58:00 UTC (rev 169687)
</span><span class="lines">@@ -2001,6 +2001,7 @@
</span><span class="cx"> # Spellchecker behavior tests.
</span><span class="cx"> webkit.org/b/108370 editing/spelling/delete-into-misspelled-word.html [ Failure ]
</span><span class="cx"> webkit.org/b/108370 editing/spelling/editing-multiple-words-with-markers.html [ Failure ]
</span><ins>+webkit.org/b/108370 editing/spelling/editing-word-with-marker-2.html [ Failure ]
</ins><span class="cx"> webkit.org/b/108370 editing/spelling/design-mode-spellcheck-off.html [ Failure ]
</span><span class="cx"> webkit.org/b/108370 editing/spelling/context-menu-suggestions-multiword-selection.html [ Failure ]
</span><span class="cx"> webkit.org/b/108370 editing/spelling/context-menu-suggestions-subword-selection.html [ Failure ]
</span></span></pre>
</div>
</div>
</body>
</html>