<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169646] trunk/LayoutTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169646">169646</a></dd>
<dt>Author</dt> <dd>mario.prada@samsung.com</dd>
<dt>Date</dt> <dd>2014-06-06 09:19:54 -0700 (Fri, 06 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Layout Test accessibility/table-fallback-roles-expose-element-attributes.html is failing
https://bugs.webkit.org/show_bug.cgi?id=133519
Reviewed by Chris Fleizach.
Adapted test to play nicely with the different types of
accessibility hierarchies exposed for Mac and ATK.
* accessibility/table-fallback-roles-expose-element-attributes.html:
Updated text to print information of cells from every platform but
only print information of their children in the Mac.
* accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
Updated expectation to match ATK platforms (GTK & EFL).
* platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
Copied from LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt.
* platform/gtk/TestExpectations: Removed expected failure.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilitytablefallbackrolesexposeelementattributesexpectedtxt">trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitytablefallbackrolesexposeelementattributeshtml">trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes.html</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsplatformmacaccessibilitytablefallbackrolesexposeelementattributesexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169645 => 169646)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-06-06 15:49:08 UTC (rev 169645)
+++ trunk/LayoutTests/ChangeLog 2014-06-06 16:19:54 UTC (rev 169646)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2014-06-06 Mario Sanchez Prada <mario.prada@samsung.com>
+
+ [GTK] Layout Test accessibility/table-fallback-roles-expose-element-attributes.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=133519
+
+ Reviewed by Chris Fleizach.
+
+ Adapted test to play nicely with the different types of
+ accessibility hierarchies exposed for Mac and ATK.
+
+ * accessibility/table-fallback-roles-expose-element-attributes.html:
+ Updated text to print information of cells from every platform but
+ only print information of their children in the Mac.
+
+ * accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
+ Updated expectation to match ATK platforms (GTK & EFL).
+ * platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
+ Copied from LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt.
+
+ * platform/gtk/TestExpectations: Removed expected failure.
+
</ins><span class="cx"> 2014-06-06 Frédéric Wang <fred.wang@free.fr>
</span><span class="cx">
</span><span class="cx"> Add test references for horizontal stretchy operators.
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitytablefallbackrolesexposeelementattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt (169645 => 169646)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt 2014-06-06 15:49:08 UTC (rev 169645)
+++ trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt 2014-06-06 16:19:54 UTC (rev 169646)
</span><span class="lines">@@ -6,11 +6,11 @@
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="cx">
</span><span class="cx">
</span><del>-cellChild: AXRole: AXStaticText, AXValue: item1
</del><ins>+cell: AXRole: AXCell, AXValue: item1
</ins><span class="cx">
</span><del>-cellChild: AXRole: AXStaticText, AXValue: item1
</del><ins>+cell: AXRole: AXCell, AXValue: item1
</ins><span class="cx">
</span><del>-cellChild: AXRole: AXStaticText, AXValue: item1
</del><ins>+cell: AXRole: AXCell, AXValue: item1
</ins><span class="cx">
</span><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitytablefallbackrolesexposeelementattributeshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes.html (169645 => 169646)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes.html 2014-06-06 15:49:08 UTC (rev 169645)
+++ trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes.html 2014-06-06 16:19:54 UTC (rev 169646)
</span><span class="lines">@@ -28,11 +28,14 @@
</span><span class="cx">
</span><span class="cx"> for (var k = 1; k < 4; k++) {
</span><span class="cx"> var grid = accessibilityController.accessibleElementById("grid" + k);
</span><del>- var cellChild = grid.cellForColumnAndRow(0, 0).childAtIndex(0);
- debug("cellChild: " + cellChild.role + ", " + cellChild.stringValue + "\n");
</del><ins>+ var cell = grid.cellForColumnAndRow(0, 0);
+ debug("cell: " + cell.role + ", " + cell.stringValue + "\n");
+ if (accessibilityController.platformName != "atk") {
+ var cellChild = cell.childAtIndex(0);
+ debug("cellChild: " + cellChild.role + ", " + cellChild.stringValue + "\n");
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><del>-
</del><span class="cx"> </script>
</span><span class="cx">
</span><span class="cx"> <script src="../resources/js-test-post.js"></script>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (169645 => 169646)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-06-06 15:49:08 UTC (rev 169645)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-06-06 16:19:54 UTC (rev 169646)
</span><span class="lines">@@ -1972,8 +1972,6 @@
</span><span class="cx"> webkit.org/b/133147 fast/shapes/shape-outside-floats/shape-outside-floats-inset-rounded-large-radius.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/133147 fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html [ ImageOnlyFailure ]
</span><span class="cx">
</span><del>-webkit.org/b/133519 accessibility/table-fallback-roles-expose-element-attributes.html [ Failure ]
-
</del><span class="cx"> #////////////////////////////////////////////////////////////////////////////////////////
</span><span class="cx"> # End of Tests failing
</span><span class="cx"> #////////////////////////////////////////////////////////////////////////////////////////
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilitytablefallbackrolesexposeelementattributesexpectedtxtfromrev169645trunkLayoutTestsaccessibilitytablefallbackrolesexposeelementattributesexpectedtxt"></a>
<div class="copfile"><h4>Copied: trunk/LayoutTests/platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt (from rev 169645, trunk/LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt) (0 => 169646)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt 2014-06-06 16:19:54 UTC (rev 169646)
</span><span class="lines">@@ -0,0 +1,24 @@
</span><ins>+item1
+item1
+item1
+This tests if an element is using fallback role tokens, it will still become the 'correct' element which will expose the correct attributes.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+cell: AXRole: AXCell, AXValue:
+
+cellChild: AXRole: AXStaticText, AXValue: item1
+
+cell: AXRole: AXCell, AXValue:
+
+cellChild: AXRole: AXStaticText, AXValue: item1
+
+cell: AXRole: AXCell, AXValue:
+
+cellChild: AXRole: AXStaticText, AXValue: item1
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre>
</div>
</div>
</body>
</html>