<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169615] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169615">169615</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2014-06-05 08:59:37 -0700 (Thu, 05 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Subpixel rendering: Buttons in default media controls shift vertically when controls fade in or out.
https://bugs.webkit.org/show_bug.cgi?id=133488
Reviewed by Simon Fraser.
Filter effects are not subpixel aware yet. They paint to integrally sized image buffers.
In order to ensure that the content is rendered to the the same position on the filter
source context as if there was no filter, the repaint rects need to be adjusted to match with
the internal filter snapping (enclosingIntRect).
This is a temporary change until after filter effects get subpixelized.
However, this changeset regresses RenderNameFlow clipping when the content is on subpixel position
and filter effect is present. Instead of adding the failing test cases to TestExpectations, I removed
the video controls from the <video> to make the tests pass, when possible (they just happen to have <video>)
and filed webkit.org/b/133523 to track the regression.
Source/WebCore:
Test: css3/filters/filter-is-on-subpixel-position.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFilters):
LayoutTests:
* css3/filters/filter-is-on-subpixel-position-expected.html: Added.
* css3/filters/filter-is-on-subpixel-position.html: Added.
* fast/regions/inline-block-inside-anonymous-overflow.html:
* fast/regions/inline-block-overflow.html:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastregionsinlineblockoverflowexpectedhtml">trunk/LayoutTests/fast/regions/inline-block-overflow-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastregionsinlineblockoverflowhtml">trunk/LayoutTests/fast/regions/inline-block-overflow.html</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayercpp">trunk/Source/WebCore/rendering/RenderLayer.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscss3filtersfilterisonsubpixelpositionexpectedhtml">trunk/LayoutTests/css3/filters/filter-is-on-subpixel-position-expected.html</a></li>
<li><a href="#trunkLayoutTestscss3filtersfilterisonsubpixelpositionhtml">trunk/LayoutTests/css3/filters/filter-is-on-subpixel-position.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (169614 => 169615)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2014-06-05 13:45:17 UTC (rev 169614)
+++ trunk/LayoutTests/ChangeLog 2014-06-05 15:59:37 UTC (rev 169615)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2014-06-05 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Buttons in default media controls shift vertically when controls fade in or out.
+ https://bugs.webkit.org/show_bug.cgi?id=133488
+
+ Reviewed by Simon Fraser.
+
+ Filter effects are not subpixel aware yet. They paint to integrally sized image buffers.
+ In order to ensure that the content is rendered to the the same position on the filter
+ source context as if there was no filter, the repaint rects need to be adjusted to match with
+ the internal filter snapping (enclosingIntRect).
+ This is a temporary change until after filter effects get subpixelized.
+
+ However, this changeset regresses RenderNameFlow clipping when the content is on subpixel position
+ and filter effect is present. Instead of adding the failing test cases to TestExpectations, I removed
+ the video controls from the <video> to make the tests pass, when possible (they just happen to have <video>)
+ and filed webkit.org/b/133523 to track the regression.
+
+ * css3/filters/filter-is-on-subpixel-position-expected.html: Added.
+ * css3/filters/filter-is-on-subpixel-position.html: Added.
+ * fast/regions/inline-block-inside-anonymous-overflow.html:
+ * fast/regions/inline-block-overflow.html:
+
</ins><span class="cx"> 2014-06-05 Andrzej Badowski <a.badowski@samsung.com>
</span><span class="cx">
</span><span class="cx"> [EFL] Change expectations for three layout tests.
</span></span></pre></div>
<a id="trunkLayoutTestscss3filtersfilterisonsubpixelpositionexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/filters/filter-is-on-subpixel-position-expected.html (0 => 169615)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/filters/filter-is-on-subpixel-position-expected.html (rev 0)
+++ trunk/LayoutTests/css3/filters/filter-is-on-subpixel-position-expected.html 2014-06-05 15:59:37 UTC (rev 169615)
</span><span class="lines">@@ -0,0 +1,25 @@
</span><ins>+<!DOCTYPE HTML>
+<html>
+<head>
+<title>This tests that we paint the filter result image properly, when the source is on a non-device pixel position.</title>
+<style>
+ .outer {
+ height: 26px;
+ width: 50px;
+ display: -webkit-flex;
+ -webkit-align-items: center;
+ }
+
+ .inner {
+ border: 1px solid red;
+ width: 50px;
+ height: 20px;
+ margin-bottom: 1px;
+ }
+</style>
+<head>
+<body>
+ <div class=outer>
+ <div class=inner></div>
+ </div>
+</body>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestscss3filtersfilterisonsubpixelpositionhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/css3/filters/filter-is-on-subpixel-position.html (0 => 169615)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/css3/filters/filter-is-on-subpixel-position.html (rev 0)
+++ trunk/LayoutTests/css3/filters/filter-is-on-subpixel-position.html 2014-06-05 15:59:37 UTC (rev 169615)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<!DOCTYPE HTML>
+<html>
+<head>
+<title>This tests that we paint the filter result image properly, when the source is on a non-device pixel position.</title>
+<style>
+ .outer {
+ height: 26px;
+ width: 50px;
+ display: -webkit-flex;
+ -webkit-align-items: center;
+ }
+
+ .inner {
+ border: 1px solid red;
+ width: 50px;
+ height: 20px;
+ margin-bottom: 1px;
+
+ -webkit-filter: drop-shadow(black 0 0px 0px);
+ }
+</style>
+<head>
+<body>
+ <div class=outer>
+ <div class=inner></div>
+ </div>
+</body>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsinlineblockoverflowexpectedhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/regions/inline-block-overflow-expected.html (169614 => 169615)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/inline-block-overflow-expected.html 2014-06-05 13:45:17 UTC (rev 169614)
+++ trunk/LayoutTests/fast/regions/inline-block-overflow-expected.html 2014-06-05 15:59:37 UTC (rev 169615)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> <p>This test passes if the <span style="color:#00BB00">green text</span> is positioned at the very top of the second <span style="color:blue">region</span>.</p>
</span><span class="cx"> <div class="region" id="region1">
</span><span class="cx"> <div class="article" id="article1">
</span><del>- <video id="video" controls></video>
</del><ins>+ <video id="video"></video>
</ins><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionsinlineblockoverflowhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/regions/inline-block-overflow.html (169614 => 169615)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/inline-block-overflow.html 2014-06-05 13:45:17 UTC (rev 169614)
+++ trunk/LayoutTests/fast/regions/inline-block-overflow.html 2014-06-05 15:59:37 UTC (rev 169615)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> <div class="region" id="region1"></div>
</span><span class="cx"> <div class="region" id="region2"></div>
</span><span class="cx"> <div class="article" id="article1">
</span><del>- <video id="video" controls></video>
</del><ins>+ <video id="video"></video>
</ins><span class="cx"> </div>
</span><span class="cx"> <div class="article" id="article2">
</span><span class="cx"> <div id="after" style="color:#00FF00">This div is flowed after the video element.</div>
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (169614 => 169615)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2014-06-05 13:45:17 UTC (rev 169614)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2014-06-05 15:59:37 UTC (rev 169615)
</span><span class="lines">@@ -1288,6 +1288,8 @@
</span><span class="cx"> # These tests require fractional text widths. Ahem can't provide it -> using LucidaGrandeUI -> fails on ML due to different font size.
</span><span class="cx"> [ MountainLion ] fast/inline/hidpi-selection-gap-overlaps-inline-selection.html [ ImageOnlyFailure ]
</span><span class="cx"> [ MountainLion ] fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html [ ImageOnlyFailure ]
</span><ins>+# clipping filter effects when region is present.
+webkit.org/b/133523 fast/regions/inline-block-inside-anonymous-overflow.html [ ImageOnlyFailure ]
</ins><span class="cx"> # End of subpixel failures.
</span><span class="cx">
</span><span class="cx"> webkit.org/b/35297 media/video-display-aspect-ratio.html [ Pass Failure ]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (169614 => 169615)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2014-06-05 13:45:17 UTC (rev 169614)
+++ trunk/Source/WebCore/ChangeLog 2014-06-05 15:59:37 UTC (rev 169615)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2014-06-05 Zalan Bujtas <zalan@apple.com>
+
+ Subpixel rendering: Buttons in default media controls shift vertically when controls fade in or out.
+ https://bugs.webkit.org/show_bug.cgi?id=133488
+
+ Reviewed by Simon Fraser.
+
+ Filter effects are not subpixel aware yet. They paint to integrally sized image buffers.
+ In order to ensure that the content is rendered to the the same position on the filter
+ source context as if there was no filter, the repaint rects need to be adjusted to match with
+ the internal filter snapping (enclosingIntRect).
+ This is a temporary change until after filter effects get subpixelized.
+
+ However, this changeset regresses RenderNameFlow clipping when the content is on subpixel position
+ and filter effect is present. Instead of adding the failing test cases to TestExpectations, I removed
+ the video controls from the <video> to make the tests pass, when possible (they just happen to have <video>)
+ and filed webkit.org/b/133523 to track the regression.
+
+ Test: css3/filters/filter-is-on-subpixel-position.html
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::setupFilters):
+
</ins><span class="cx"> 2014-06-05 Kiran <kiran.guduru@samsung.com>
</span><span class="cx">
</span><span class="cx"> [MediaStream] MediaStream.addTrack should not check for tracks ended state.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (169614 => 169615)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-06-05 13:45:17 UTC (rev 169614)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2014-06-05 15:59:37 UTC (rev 169615)
</span><span class="lines">@@ -3884,7 +3884,7 @@
</span><span class="cx"> rootRelativeBoundsComputed = true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (filterPainter->prepareFilterEffect(this, rootRelativeBounds, paintingInfo.paintDirtyRect, filterRepaintRect)) {
</del><ins>+ if (filterPainter->prepareFilterEffect(this, enclosingIntRect(rootRelativeBounds), enclosingIntRect(paintingInfo.paintDirtyRect), enclosingIntRect(filterRepaintRect))) {
</ins><span class="cx"> // Now we know for sure, that the source image will be updated, so we can revert our tracking repaint rect back to zero.
</span><span class="cx"> filterInfo->resetDirtySourceRect();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>