<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[169582] branches/ftlopt</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/169582">169582</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2014-06-03 21:28:20 -0700 (Tue, 03 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>[ftlopt] FTL native inlining tests take far too long
https://bugs.webkit.org/show_bug.cgi?id=133498
Unreviewed test gardening.
Source/JavaScriptCore:
Added a new exceptions test since the other one appears to not work.
* tests/stress/ftl-library-exception.js:
* tests/stress/ftl-library-inline-gettimezoneoffset.js: Added.
(foo):
* tests/stress/ftl-library-inlining-exceptions-dataview.js: Added.
(foo):
* tests/stress/ftl-library-inlining-exceptions.js: Copied from LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js.
* tests/stress/ftl-library-inlining-loops.js: Copied from LayoutTests/js/regress/script-tests/ftl-library-inlining-loops.js.
* tests/stress/ftl-library-inlining-random.js:
* tests/stress/ftl-library-substring.js:
LayoutTests:
Move long-running tests that focus on correctness into JSC/tests/stress.
Speed up the performance tests by reducing allocation and call overhead.
* js/regress/ftl-library-inlining-exceptions-expected.txt: Removed.
* js/regress/ftl-library-inlining-exceptions.html: Removed.
* js/regress/ftl-library-inlining-folding-expected.txt: Removed.
* js/regress/ftl-library-inlining-folding.html: Removed.
* js/regress/ftl-library-inlining-loops-expected.txt: Removed.
* js/regress/ftl-library-inlining-loops.html: Removed.
* js/regress/script-tests/ftl-library-inlining-dataview.js:
(foo): Deleted.
* js/regress/script-tests/ftl-library-inlining-exceptions.js: Removed.
* js/regress/script-tests/ftl-library-inlining-folding.js: Removed.
* js/regress/script-tests/ftl-library-inlining-loops.js: Removed.
* js/regress/script-tests/ftl-library-inlining.js:
(foo): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branchesftloptLayoutTestsChangeLog">branches/ftlopt/LayoutTests/ChangeLog</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningdataviewjs">branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-dataview.js</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningjs">branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining.js</a></li>
<li><a href="#branchesftloptSourceJavaScriptCoreChangeLog">branches/ftlopt/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#branchesftloptSourceJavaScriptCoretestsstressftllibraryexceptionjs">branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-exception.js</a></li>
<li><a href="#branchesftloptSourceJavaScriptCoretestsstressftllibraryinliningrandomjs">branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-random.js</a></li>
<li><a href="#branchesftloptSourceJavaScriptCoretestsstressftllibrarysubstringjs">branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-substring.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#branchesftloptSourceJavaScriptCoretestsstressftllibraryinlinegettimezoneoffsetjs">branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inline-gettimezoneoffset.js</a></li>
<li><a href="#branchesftloptSourceJavaScriptCoretestsstressftllibraryinliningexceptionsdataviewjs">branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-exceptions-dataview.js</a></li>
<li><a href="#branchesftloptSourceJavaScriptCoretestsstressftllibraryinliningexceptionsjs">branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-exceptions.js</a></li>
<li><a href="#branchesftloptSourceJavaScriptCoretestsstressftllibraryinliningloopsjs">branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-loops.js</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#branchesftloptLayoutTestsjsregressftllibraryinliningexceptionsexpectedtxt">branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-exceptions-expected.txt</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressftllibraryinliningexceptionshtml">branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-exceptions.html</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressftllibraryinliningfoldingexpectedtxt">branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-folding-expected.txt</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressftllibraryinliningfoldinghtml">branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-folding.html</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressftllibraryinliningloopsexpectedtxt">branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-loops-expected.txt</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressftllibraryinliningloopshtml">branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-loops.html</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningexceptionsjs">branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningfoldingjs">branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-folding.js</a></li>
<li><a href="#branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningloopsjs">branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-loops.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branchesftloptLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/LayoutTests/ChangeLog (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/ChangeLog 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/ChangeLog 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2014-06-03 Filip Pizlo <fpizlo@apple.com>
+
+ [ftlopt] FTL native inlining tests take far too long
+ https://bugs.webkit.org/show_bug.cgi?id=133498
+
+ Unreviewed test gardening.
+
+ Move long-running tests that focus on correctness into JSC/tests/stress.
+ Speed up the performance tests by reducing allocation and call overhead.
+
+ * js/regress/ftl-library-inlining-exceptions-expected.txt: Removed.
+ * js/regress/ftl-library-inlining-exceptions.html: Removed.
+ * js/regress/ftl-library-inlining-folding-expected.txt: Removed.
+ * js/regress/ftl-library-inlining-folding.html: Removed.
+ * js/regress/ftl-library-inlining-loops-expected.txt: Removed.
+ * js/regress/ftl-library-inlining-loops.html: Removed.
+ * js/regress/script-tests/ftl-library-inlining-dataview.js:
+ (foo): Deleted.
+ * js/regress/script-tests/ftl-library-inlining-exceptions.js: Removed.
+ * js/regress/script-tests/ftl-library-inlining-folding.js: Removed.
+ * js/regress/script-tests/ftl-library-inlining-loops.js: Removed.
+ * js/regress/script-tests/ftl-library-inlining.js:
+ (foo): Deleted.
+
</ins><span class="cx"> 2014-06-03 Matthew Mirman <mmirman@apple.com>
</span><span class="cx">
</span><span class="cx"> [ftlopt] Added system for inlining native functions via the FTL.
</span></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressftllibraryinliningexceptionsexpectedtxt"></a>
<div class="delfile"><h4>Deleted: branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-exceptions-expected.txt (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-exceptions-expected.txt 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-exceptions-expected.txt 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-JSRegress/ftl-library-inlining-exceptions
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS no exception thrown
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressftllibraryinliningexceptionshtml"></a>
<div class="delfile"><h4>Deleted: branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-exceptions.html (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-exceptions.html 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-exceptions.html 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,12 +0,0 @@
</span><del>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../../resources/js-test-pre.js"></script>
-</head>
-<body>
-<script src="../../resources/regress-pre.js"></script>
-<script src="script-tests/ftl-library-inlining-exceptions.js"></script>
-<script src="../../resources/regress-post.js"></script>
-<script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressftllibraryinliningfoldingexpectedtxt"></a>
<div class="delfile"><h4>Deleted: branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-folding-expected.txt (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-folding-expected.txt 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-folding-expected.txt 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-JSRegress/ftl-library-inlining-folding
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS no exception thrown
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressftllibraryinliningfoldinghtml"></a>
<div class="delfile"><h4>Deleted: branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-folding.html (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-folding.html 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-folding.html 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,12 +0,0 @@
</span><del>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../../resources/js-test-pre.js"></script>
-</head>
-<body>
-<script src="../../resources/regress-pre.js"></script>
-<script src="script-tests/ftl-library-inlining-folding.js"></script>
-<script src="../../resources/regress-post.js"></script>
-<script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressftllibraryinliningloopsexpectedtxt"></a>
<div class="delfile"><h4>Deleted: branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-loops-expected.txt (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-loops-expected.txt 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-loops-expected.txt 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-JSRegress/ftl-library-inlining-loops
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS no exception thrown
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressftllibraryinliningloopshtml"></a>
<div class="delfile"><h4>Deleted: branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-loops.html (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-loops.html 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/ftl-library-inlining-loops.html 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,12 +0,0 @@
</span><del>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../../resources/js-test-pre.js"></script>
-</head>
-<body>
-<script src="../../resources/regress-pre.js"></script>
-<script src="script-tests/ftl-library-inlining-loops.js"></script>
-<script src="../../resources/regress-post.js"></script>
-<script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningdataviewjs"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-dataview.js (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-dataview.js 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-dataview.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,17 +1,13 @@
</span><del>-function foo(d){
- d.setInt8(0, 4);
- d.setInt8(1, 2);
- d.setInt8(2, 6);
- d.setInt16(0, 20);
- return d.getInt8(2) + d.getInt8(0);
-}
-
-noInline(foo);
-
-var result = 0;
-for (var i = 0 ; i < 4000000; i++){
- result += foo(new DataView(new ArrayBuffer(5)));
-}
-
-if(result != 24000000)
- throw "Bad result: " + result;
</del><span class="cx">\ No newline at end of file
</span><ins>+(function() {
+ var result = 0;
+ var d = new DataView(new ArrayBuffer(5));
+ for (var i = 0; i < 1000000; i++) {
+ d.setInt8(0, 4);
+ d.setInt8(1, 2);
+ d.setInt8(2, 6);
+ d.setInt16(0, 20);
+ result += d.getInt8(2) + d.getInt8(0);
+ }
+ if (result != 6000000)
+ throw "Bad result: " + result;
+})();
</ins></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningexceptionsjs"></a>
<div class="delfile"><h4>Deleted: branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,19 +0,0 @@
</span><del>-function foo(d){
- return Date.prototype.getTimezoneOffset.call(d);
-}
-
-noInline(foo);
-
-var x;
-var count = 1000000;
-for (var i = 0 ; i < count; i++){
- try {
- foo(i < count - 1000 ? new Date() : "a");
- x = false;
- } catch (e) {
- x = true;
- }
-}
-
-if (!x)
- throw "bad result: "+ x;
</del><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningfoldingjs"></a>
<div class="delfile"><h4>Deleted: branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-folding.js (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-folding.js 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-folding.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,18 +0,0 @@
</span><del>-function foo(){
- var d = new DataView(new ArrayBuffer(5));
- d.setInt8(0, 4);
- d.setInt8(1, 2);
- d.setInt8(2, 6);
- d.setInt16(0, 20);
- return d.getInt8(2) + d.getInt8(0);
-}
-
-noInline(foo);
-
-var result = 0;
-for (var i = 0 ; i < 3000000; i++){
- result += foo();
-}
-
-if (result != 18000000)
- throw "Bad result: " + result;
</del></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningloopsjs"></a>
<div class="delfile"><h4>Deleted: branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-loops.js (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-loops.js 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-loops.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,28 +0,0 @@
</span><del>-function foo(){
- var count = 100;
- var d = new DataView(new ArrayBuffer(count));
-
- for (var i = 0; i < count / 4; i++){
- d.setInt32(i, i);
- }
-
- for (var i = 0; i < count; i++){
- d.setInt8(i, i);
- }
- var result = 0;
- for (var i = 0; i < count; i++){
- result += d.getInt8(i);
- }
- return result;
-}
-
-noInline(foo);
-
-var r = 0;
-for (var i = 0 ; i < 500000; i++){
- r += foo();
-}
-
-if (r != 2475000000)
- throw "Bad result: " + r;
-
</del></span></pre></div>
<a id="branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningjs"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining.js (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining.js 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,10 +1,4 @@
</span><del>-function foo(x, d){
- return x + Math.random() + d.getTimezoneOffset();
-}
-
-noInline(foo);
-
-for (var i = 0 ; i < 1000000; i++){
- foo(i, new Date());
-}
-
</del><ins>+(function() {
+ for (var i = 0 ; i < 10000000; i++)
+ Math.random();
+})();
</ins></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/Source/JavaScriptCore/ChangeLog (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/ChangeLog 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/Source/JavaScriptCore/ChangeLog 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2014-06-03 Filip Pizlo <fpizlo@apple.com>
+
+ [ftlopt] FTL native inlining tests take far too long
+ https://bugs.webkit.org/show_bug.cgi?id=133498
+
+ Unreviewed test gardening.
+
+ Added a new exceptions test since the other one appears to not work.
+
+ * tests/stress/ftl-library-exception.js:
+ * tests/stress/ftl-library-inline-gettimezoneoffset.js: Added.
+ (foo):
+ * tests/stress/ftl-library-inlining-exceptions-dataview.js: Added.
+ (foo):
+ * tests/stress/ftl-library-inlining-exceptions.js: Copied from LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js.
+ * tests/stress/ftl-library-inlining-loops.js: Copied from LayoutTests/js/regress/script-tests/ftl-library-inlining-loops.js.
+ * tests/stress/ftl-library-inlining-random.js:
+ * tests/stress/ftl-library-substring.js:
+
</ins><span class="cx"> 2014-06-03 Matthew Mirman <mmirman@apple.com>
</span><span class="cx">
</span><span class="cx"> [ftlopt] Added system for inlining native functions via the FTL.
</span></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoretestsstressftllibraryexceptionjs"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-exception.js (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-exception.js 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-exception.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx"> noInline(foo);
</span><span class="cx">
</span><span class="cx"> var x;
</span><del>-var count = 1000000;
</del><ins>+var count = 100000;
</ins><span class="cx"> var z = 0;
</span><span class="cx"> for (var i = 0 ; i < count; i++){
</span><span class="cx"> try {
</span></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoretestsstressftllibraryinlinegettimezoneoffsetjs"></a>
<div class="addfile"><h4>Added: branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inline-gettimezoneoffset.js (0 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inline-gettimezoneoffset.js (rev 0)
+++ branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inline-gettimezoneoffset.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+function foo(x, d){
+ return x + d.getTimezoneOffset();
+}
+
+noInline(foo);
+
+var d = new Date();
+var expected = foo(0, d);
+var count = 1000000;
+var result = 0;
+for (var i = 0 ; i < count; i++){
+ result += foo(0, d);
+}
+
+if (result != count * expected)
+ throw "Error: bad result: " + result;
</ins></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoretestsstressftllibraryinliningexceptionsdataviewjs"></a>
<div class="addfile"><h4>Added: branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-exceptions-dataview.js (0 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-exceptions-dataview.js (rev 0)
+++ branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-exceptions-dataview.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+function foo(d){
+ return d.getInt8(42);
+}
+
+noInline(foo);
+
+var d = new DataView(new ArrayBuffer(43));
+d.setInt8(42, 43);
+for (var i = 0; i < 100000; ++i) {
+ var result = foo(d);
+ if (result != 43)
+ throw "Error: bad result: " + result;
+}
+
+for (var i = 0; i < 10; ++i) {
+ var didThrow = false;
+ try {
+ foo(new DataView(new ArrayBuffer(42)));
+ } catch (e) {
+ didThrow = true;
+ if (e.message.indexOf("Out of bounds") < 0)
+ throw "Error: bad exception: " + e.message;
+ }
+ if (!didThrow)
+ throw "Error: did not throw";
+}
</ins></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoretestsstressftllibraryinliningexceptionsjsfromrev169578branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningexceptionsjs"></a>
<div class="copfile"><h4>Copied: branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-exceptions.js (from rev 169578, branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js) (0 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-exceptions.js (rev 0)
+++ branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-exceptions.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -0,0 +1,19 @@
</span><ins>+function foo(d){
+ return Date.prototype.getTimezoneOffset.call(d);
+}
+
+noInline(foo);
+
+var x;
+var count = 100000;
+for (var i = 0 ; i < count; i++){
+ try {
+ foo(i < count - 1000 ? new Date() : "a");
+ x = false;
+ } catch (e) {
+ x = true;
+ }
+}
+
+if (!x)
+ throw "bad result: "+ x;
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoretestsstressftllibraryinliningloopsjsfromrev169578branchesftloptLayoutTestsjsregressscripttestsftllibraryinliningloopsjs"></a>
<div class="copfile"><h4>Copied: branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-loops.js (from rev 169578, branches/ftlopt/LayoutTests/js/regress/script-tests/ftl-library-inlining-loops.js) (0 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-loops.js (rev 0)
+++ branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-loops.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -0,0 +1,28 @@
</span><ins>+function foo(){
+ var count = 100;
+ var d = new DataView(new ArrayBuffer(count));
+
+ for (var i = 0; i < count / 4; i++){
+ d.setInt32(i, i);
+ }
+
+ for (var i = 0; i < count; i++){
+ d.setInt8(i, i);
+ }
+ var result = 0;
+ for (var i = 0; i < count; i++){
+ result += d.getInt8(i);
+ }
+ return result;
+}
+
+noInline(foo);
+
+var r = 0;
+for (var i = 0 ; i < 50000; i++){
+ r += foo();
+}
+
+if (r != 247500000)
+ throw "Bad result: " + r;
+
</ins></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoretestsstressftllibraryinliningrandomjs"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-random.js (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-random.js 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-inlining-random.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -6,6 +6,6 @@
</span><span class="cx">
</span><span class="cx"> var x = 0;
</span><span class="cx">
</span><del>-for (var i = 0 ; i < 10000000; i++){
</del><ins>+for (var i = 0 ; i < 100000; i++){
</ins><span class="cx"> x = foo(i);
</span><span class="cx"> }
</span></span></pre></div>
<a id="branchesftloptSourceJavaScriptCoretestsstressftllibrarysubstringjs"></a>
<div class="modfile"><h4>Modified: branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-substring.js (169581 => 169582)</h4>
<pre class="diff"><span>
<span class="info">--- branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-substring.js 2014-06-04 04:22:10 UTC (rev 169581)
+++ branches/ftlopt/Source/JavaScriptCore/tests/stress/ftl-library-substring.js 2014-06-04 04:28:20 UTC (rev 169582)
</span><span class="lines">@@ -6,7 +6,7 @@
</span><span class="cx">
</span><span class="cx"> var x = "";
</span><span class="cx">
</span><del>-for (var i = 0 ; i < 1000000; i++){
</del><ins>+for (var i = 0 ; i < 100000; i++){
</ins><span class="cx"> x = foo(i, "lkajsx");
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>